Re: [LinPrj] experiences with tzafrir's r2l-0.1.0

[mulix]

On Tue, 11 Sep 2001, Tzafrir Cohen wrote:

> I've updated only the r2l-package and r2l tarballs (the rpm managed to
> build just fine anyway)
>
> http://www.technion.ac.il/~tzafrir/R2L/r2l-tarball/r2l-0.1.1.tar.gz
> http://www.technion.ac.il/~tzafrir/R2L/r2l-tarball/r2l-package.0.1.1.tar.gz

r2l-package gives me a 404. what is it?

> BTW: emil: the only warning I saw was:
>
> g++ -g -D_REENTRANT  -Wall -pedantic
> -I/home/tzafrir/projects/LinClub/BiditextGui/r2l-tarball/r2l-0.1.1/include
> -I/home/tzafrir/projects/LinClub/BiditextGui/r2l-tarball/r2l-0.1.1/include
> -O2 -c communication.cc
> In file included from /usr/include/sys/socket.h:34,
>                  from communication.cc:5:
> /usr/include/bits/socket.h:226: warning: ANSI C++ forbids zero-size array 
>`__cmsg_data'

i saw some other errors when compiling with gcc3.0. i'll make a patch
later.

here's the patch for the 'r2l' crashes.

--- r2l-0.1.1/src/r2llib/r2l.c  Mon Aug 27 16:39:38 2001
+++ r2l-0.1.1-mulix/src/r2llib/r2l.c    Tue Sep 11 20:47:41 2001
@@ -90,7 +90,7 @@
          exit(LIBR2L_FAILED);
      }

-     if (argc < 1 || argv[1] == NULL) {
+     if (argc < 2 || argv[1] == NULL) {
          print_usage_message("Command missing");
          r2l_destroy(rtl);
          exit(INCORRECT_ARGUMENT);
@@ -98,7 +98,7 @@

      switch (argv[1][0]) {
      case 'p': /* print */
-         if ((argc < 2) || (argv[2] == NULL)) {
+         if ((argc < 3) || (argv[2] == NULL)) {
               print_usage_message("Missing Print argument");
               ret_val = INCORRECT_ARGUMENT;
               break;
@@ -138,9 +138,10 @@
          }
          break;
      case 's': /* change State */
-         if (argc < 2 || argv[2] == NULL) {
+         if (argc < 3 || argv[2] == NULL) {
               print_usage_message("Missing State argument");
               ret_val = INCORRECT_ARGUMENT;
+              break;
          }
          if        (!strcasecmp(argv[2],"disable")) {
               ret_val = r2l_disable(rtl);
@@ -160,9 +161,10 @@
          }
          break;
      case 'b': /* change Base direction */
-         if (argc < 2 || argv[2] == NULL) {
+         if (argc < 3 || argv[2] == NULL) {
               print_usage_message("Missing Base direction argument");
               ret_val = INCORRECT_ARGUMENT;
+              break;
          }
          if        (!strcasecmp(argv[2],"neutral")) {
               ret_val = r2l_set_biditext_base_state_neutral(rtl);

-- 
mulix

http://www.advogato.com/person/mulix
http://www.sf.net/projects/syscalltrack



-------------------------------------------------------------------------
Haifa Linux Club Projects Mailing List (http://linuxclub.il.eu.org)
To unsub send an empty message to [EMAIL PROTECTED]