From: Sebastian Andrzej Siewior <bige...@linutronix.de>

stp_work_fn() holds get_online_cpus() while invoking stop_machine().

stop_machine() invokes get_online_cpus() as well. This is correct, but
prevents the conversion of the hotplug locking to a percpu rwsem.

Use stop_machine_cpuslocked() to avoid the nested call. Convert
*_online_cpus() to the new interfaces while at it.

Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de>
Signed-off-by: Thomas Gleixner <t...@linutronix.de>
Cc: linux-s...@vger.kernel.org
Cc: Peter Zijlstra <pet...@infradead.org>
Cc: Heiko Carstens <heiko.carst...@de.ibm.com>
Cc: Steven Rostedt <rost...@goodmis.org>
Cc: David Hildenbrand <d...@linux.vnet.ibm.com>
Cc: Martin Schwidefsky <schwidef...@de.ibm.com>

---
 arch/s390/kernel/time.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- a/arch/s390/kernel/time.c
+++ b/arch/s390/kernel/time.c
@@ -636,10 +636,10 @@ static void stp_work_fn(struct work_stru
                goto out_unlock;
 
        memset(&stp_sync, 0, sizeof(stp_sync));
-       get_online_cpus();
+       cpus_read_lock();
        atomic_set(&stp_sync.cpus, num_online_cpus() - 1);
-       stop_machine(stp_sync_clock, &stp_sync, cpu_online_mask);
-       put_online_cpus();
+       stop_machine_cpuslocked(stp_sync_clock, &stp_sync, cpu_online_mask);
+       cpus_read_unlock();
 
        if (!check_sync_clock())
                /*


Reply via email to