Felipe Balbi
Thu, 18 Mar 2010 08:36:59 -0700
Hi, first of all you shouldn't top-post.
On Thu, Mar 18, 2010 at 04:06:48PM +0200, Dmitry Kasatkin wrote: > omap_sha1_md5_init() only able to get global dd > no other choice. > > so what is the point to have it as ctx->dd. the point of not having to global variables is that the driver should work if with multiples instances of the HW. Besides omap_sha1_md5_init() is a static function for your driver to use only so you can change that prototype as much as you want. > convinced? no. You should fix the driver before sending it to the public. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html