Hey Sagi, On 05/04/17 11:47 PM, Sagi Grimberg wrote: > Because the user can get it wrong, and its our job to do what we can in > order to prevent the user from screwing itself.
Well, "screwing" themselves seems a bit strong. It wouldn't be much different from a lot of other tunables in the system. For example, it would be similar to the user choosing the wrong io scheduler for their disk or workload. If you change this setting without measuring performance you probably don't care too much about the result anyway. > I wasn't against it that much, I'm all for making things "just work" > with minimal configuration steps, but I'm not sure we can get it > right without it. Ok, well in that case I may reconsider this in the next series. >>>> Ideally, we'd want to use an NVME CMB buffer as p2p memory. This would >>>> save an extra PCI transfer as the NVME card could just take the data >>>> out of it's own memory. However, at this time, cards with CMB buffers >>>> don't seem to be available. >>> >>> Even if it was available, it would be hard to make real use of this >>> given that we wouldn't know how to pre-post recv buffers (for in-capsule >>> data). But let's leave this out of the scope entirely... >> >> I don't understand what you're referring to. We'd simply use the CMB >> buffer as a p2pmem device, why does that change anything? > > I'm referring to the in-capsule data buffers pre-posts that we do. > Because we prepare a buffer that would contain in-capsule data, we have > no knowledge to which device the incoming I/O is directed to, which > means we can (and will) have I/O where the data lies in CMB of device > A but it's really targeted to device B - which sorta defeats the purpose > of what we're trying to optimize here... Well, the way I've had it is that each port gets one p2pmem device. So you'd only want to put NVMe devices that will work with that p2pmem device behind that port. Though, I can see that being a difficult restriction seeing it probably means you'll need to have one port per nvme device if you want to use the CMB buffer of each device. I'll have to think about that some. Also, it's worth noting that we aren't even optimizing in-capsule data at this time. > Still the user can get it wrong. Not sure we can get a way without > keeping track of this as new devices join the subsystem. Yeah, I understand. I'll have to think some more about all of this. I'm starting to see some ways to improve thing.s Thanks, Logan
