On Fri, 2017-05-19 at 14:53 -0700, Himanshu Madhani wrote:
> @@ -1851,17 +1851,13 @@ static int __qlt_24xx_handle_abts(struct 
> scsi_qla_host *vha,
>       struct se_session *se_sess = sess->se_sess;
>       struct qla_tgt_mgmt_cmd *mcmd;
>       struct se_cmd *se_cmd;
> -     u32 lun = 0;
>       int rc;
>       bool found_lun = false;
>       unsigned long flags;
>  
>       spin_lock_irqsave(&se_sess->sess_cmd_lock, flags);
>       list_for_each_entry(se_cmd, &se_sess->sess_cmd_list, se_cmd_list) {
> -             struct qla_tgt_cmd *cmd =
> -                     container_of(se_cmd, struct qla_tgt_cmd, se_cmd);
>               if (se_cmd->tag == abts->exchange_addr_to_abort) {
> -                     lun = cmd->unpacked_lun;
>                       found_lun = true;
>                       break;
>               }
> @@ -1900,7 +1896,7 @@ static int __qlt_24xx_handle_abts(struct scsi_qla_host 
> *vha,
>       mcmd->reset_count = vha->hw->chip_reset;
>       mcmd->tmr_func = QLA_TGT_ABTS;
>  
> -     rc = ha->tgt.tgt_ops->handle_tmr(mcmd, lun, mcmd->tmr_func,
> +     rc = ha->tgt.tgt_ops->handle_tmr(mcmd, 0, mcmd->tmr_func,
>           abts->exchange_addr_to_abort);
>       if (rc != 0) {
>               ql_dbg(ql_dbg_tgt_mgt, vha, 0xf052,

Hello Himanshu and Quinn,

A LIO target driver should not make any assumptions about whether or not LUN 0
exists. Please modify this patch such that the LUN through which the task
management function was received is passed to the LIO core instead of passing 0.

Bart.

Reply via email to