On Wednesday 14 April 2004 15:30, Oliver Neukum wrote: > Am Mittwoch, 14. April 2004 12:45 schrieb Duncan Sands: > > The remaining three patches contain miscellaneous fixes to usbfs. > > This one fixes up the disconnect callback to only shoot down urbs > > on the disconnected interface, and not on all interfaces. It also adds > > a sanity check (this check is pointless because the interface could > > never have been claimed in the first place if it failed, but I feel > > better having it there). > > Well, I don't. If you care about it, add a WARN_ON(). > Checking without consequences is bad.
If the check fails then you are scribbling over kernel memory. So the consequences of the check failing are bad. Also, it is in a slow path. Thus I prefer to have the check even if it is supposed to never fail. I agree that a message should also be output. Duncan. ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
