Re: [bincimap] Patch for 1.2.2

[Henry Baragar]

Hi Andy,

Gees, go off line for a couple of days and come back to find the world (of 
IMAPdir subscriptions) has changed;-)

See the rest of my comments below...

Henry

On Sun, 14 Sep 2003 10:42:31 +0200 (CEST), Andreas Aardal Hanssen 
<[EMAIL PROTECTED]> wrote:

Hi, everyone :-).

http://www.bincimap.org/dl/tarballs/1.2/bincimap-1.2.2-patch001-subscribe

- bincimap-subscribed is now called .bincimap-subscribed, and has
  a much simpler format (refer to Henry Barager's suggestion in
  earlier thread). Difference is that mailboxes are stored with their
  IMAP name (groups/bincimap instead of groups.bincimap), but it should
  still be easy to generate automatically. 1.2.3 will contain a scripts
  directory for common maintenance tasks, such as generating files like
  this.
Thank you... it is much easier to generate, but still not as easy as "ls 
bincimap-subscribed".  What is the possibility of using the routine that 
is used to transform the a directory name structure to an IMAP name (which 
you must have for the "subscribe" operator, if nothing else) to also 
transform the names in .bincimap-subscribed to IMAP names?

BTW is line 465 of session.cc [    if ((ok = 
subs.load("bincimap-subscribed")))] correct?  That is, there is supposed 
to be no "." in front of bincimap-subscribed?

<NOTE>
You made the same change to the Maildir++ depot, which has now as 
.bincimap-subscribed polluting the Maildir++ namespace.  Since 
Maildir++ is backwards from IMAPdir, I would suggest that 
"bincimap-subscribed" should have been converted to the new format while 
retaining its original name.  Similarly, I would like to see the 
transformation routines applied to this subscribed folder so that an "ls 
.?? >bincimap-subscribed" creates a new completely subscribed list.  
However, I care much less about Maildir++ than I do about IMAPdir!-)
</NOTE>

- A file descriptor leak fix in LIST/LSUB.

This seems to be fixed... at least I have not yet been able to exceed the 
limit!-)  Now, SquirrelMail does not go squirrelly with more than 27 
folders;-)


- Changes to subscription commands. Binc IMAP now works exactly the way
  the IMAP standard says (rfc2060 / rfc3501). I can not find any reason
  for any client to not show all levels of mailboxes. I have studied the
  responses in Henry's posts and can only find a real difference in
  the CHILDREN extension. However, with the changes to subscription in
  this patch, I am unable to reproduce any problems with Mozilla, using
  the same depository for both Courier-IMAP and Binc IMAP.
My quick check of this indicates that there little or no change in 
behaviour.  Would you like me to rerun the test?

Because of the file descriptor leak, this patch is moderately important
and I encourage everyone to apply it. Those who use RPM packages will get
these changes in version 1.2.3, or replace the bincimap-up and bincimapd
binaries from the tarball with patches applied.
Andy :-)



--
Henry Baragar
Principal, Technical Architecture
416-453-5626
Instantiated Software Inc.
http://www.instantiated.ca