On Sun, Dec 04, 2016 at 06:38:42PM +0100, Guillaume Munch wrote:

> commit 588d939722f4a516e8e4a932086e574bc3b13065
> Author: Guillaume Munch <g...@lyx.org>
> Date:   Sun Dec 4 18:28:03 2016 +0100
> 
>     Cosmetic changes to the needauth dialogs
>     
>     * Use rich text for this complicated message
>     
>     * More concise
>     
>     * Fix line breaking issues
>     
>     * Remove "Do not show again" checkbox
> 
[...]
>  
> +// FIXME: This dialog has issues with line breaking and size, in particular 
> with
> +// html. But it could easily be reimplemented as a QMessageBox using
> +// QMessageBox::setCheckBox() available starting from Qt 5.2
>  class GuiToggleWarningDialog : public QDialog, public Ui::ToggleWarningUi
>  {
>  public:

If this is true, it would be better to actually reimplement it and
conditionally compile for Qt >= 5.2, otherwise this risks staying so
for ever (or almost so).

-- 
Enrico

Reply via email to