Steve Hay wrote:
> I still haven't found out what the problem with the server crashing on 
> startup is, but the attached patch against CVS seems to fix the 
> fprintf() problem that you refer to.

Your patch passes the current interpreter context to
modperl_hash_seed_init(), and thus the interpreter-wide variables. I
don't see problems with it, but I don't know anything about the mod_perl
2 internals.

I've a minor comment :

> @@ -63,7 +63,8 @@
>          if (s) {
>              int i = atoi(s);
>              if (i == 1) {
> -                fprintf(stderr, "\nmod_perl: using init hash seed: %"UVuf"\n",
> +                PerlIO_printf(PerlIO_stderr(),

When possible, try to use Perl_error_log instead of PerlIO_stderr().
It's equivalent to it, but checks for the availability of STDERR
beforehand. And BTW the trace below should probably be out#defined for
non-debug builds.

> +                     "\nmod_perl: using init hash seed: %"UVuf"\n",
>                          MP_init_hash_seed);
>              }
>          }
> @@ -587,10 +588,12 @@

Reply via email to