Laine Stump
Thu, 22 Oct 2009 10:20:34 -0700
On 10/22/2009 12:53 PM, David Lutterkort wrote:
> On Thu, 2009-10-22 at 09:43 -0400, Laine Stump wrote:
>
>> This patch removes add_ipv4_state_to_xml_doc() (which uses
>> ioctl(SIOCGIFADDR)), whose functionality was replaced in the previous
>> commit with the new add_state_to_xml_doc() (which uses the netlink
>> socket).
>> ---
>> src/dutil.c | 79
>> -----------------------------------------------------------
>> src/dutil.h | 3 --
>> 2 files changed, 0 insertions(+), 82 deletions(-)
>>
> Looks good. Shouldn't if_ipv4_{address,netmask,prefix} go, too ?
>
Well, it is quite a bit more involved to get an IP address using netlink, and someone in the future might want to get a single address per interface for some kind of naming or indexing or something. But I guess if that ever happens, they can just rewrite these functions (and do them the right way). I'll modify the patch to remove those too. _______________________________________________ netcf-devel mailing list netcf-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/netcf-devel