Daniel P. Berrange
Fri, 23 Oct 2009 10:03:16 -0700
On Fri, Oct 23, 2009 at 12:58:12PM -0400, Laine Stump wrote: > On 10/23/2009 12:32 PM, Daniel P. Berrange wrote: > >>2) Would it be useful to also add this information to the xml of > >>ncf_if_xml_state()? If so, any suggestions on what it should look like? > >> > >I don't think it is relevant there, because whether an interface is up > >or down is not configuration information. > > > > ncf_if_xml_desc() is the config, ncf_if_xml_state() is only the > information we got directly from the kernel.
Sorry, terminology mixup. By 'configuration information' here, I meant stuff about IP addresses, routes, type of interfaces, etc, regardless of whether the information comes from a config file, or the kernel Whether an interface is up or down isn't a configuration property in this sense, so is outside scope of the XML description IMHO. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| _______________________________________________ netcf-devel mailing list netcf-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/netcf-devel