>From Hussain Towaileb <[email protected]>: Hussain Towaileb has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21956?usp=email )
Change subject: [NO ISSUE][EXT]: Fix decimal test NPE ...................................................................... [NO ISSUE][EXT]: Fix decimal test NPE ParquetDecimalToDoubleTest built its ParquetReadSupport without a filter value embedder, which the root converter dereferences on every record, so the test failed on its first row. Give it the no-op embedder, as production readers always set one. Ext-ref: MB-74262 Generated-by: Claude Opus 5.5 <[email protected]> Change-Id: Ic7aaf493a17bdc613eac10a8daa8f2cc53d1f75a --- M asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/hdfs/parquet/ParquetDecimalToDoubleTest.java 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/56/21956/1 diff --git a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/hdfs/parquet/ParquetDecimalToDoubleTest.java b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/hdfs/parquet/ParquetDecimalToDoubleTest.java index eae8e1b..21a8d00 100644 --- a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/hdfs/parquet/ParquetDecimalToDoubleTest.java +++ b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/hdfs/parquet/ParquetDecimalToDoubleTest.java @@ -28,6 +28,7 @@ import java.util.Map; import org.apache.asterix.dataflow.data.nontagged.serde.AObjectSerializerDeserializer; +import org.apache.asterix.external.input.filter.NoOpFilterValueEmbedder; import org.apache.asterix.external.util.ExternalDataConstants.ParquetOptions; import org.apache.asterix.om.base.ADouble; import org.apache.asterix.om.base.ARecord; @@ -79,9 +80,10 @@ Path path = new Path(new File(tempFolder.getRoot(), "decimals.parquet").toURI()); write(path, conf); + ParquetReadSupport readSupport = new ParquetReadSupport(); + readSupport.setValueEmbedder(NoOpFilterValueEmbedder.INSTANCE); int row = 0; - try (ParquetReader<IValueReference> reader = - ParquetReader.builder(new ParquetReadSupport(), path).withConf(conf).build()) { + try (ParquetReader<IValueReference> reader = ParquetReader.builder(readSupport, path).withConf(conf).build()) { for (IValueReference value = reader.read(); value != null; value = reader.read()) { Map<String, Double> actual = toDoubles(value); for (Column column : COLUMNS) { -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21956?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ic7aaf493a17bdc613eac10a8daa8f2cc53d1f75a Gerrit-Change-Number: 21956 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb <[email protected]>
