>From Ali Alsuliman <[email protected]>:
Attention is currently required from: Ali Alsuliman.
Hello Anon. E. Moose #1000171, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21683?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Contrib-2 by Anon. E. Moose #1000171, Integration-Tests+1 by Jenkins,
Verified+1 by Jenkins
Change subject: [ASTERIXDB-3817][STO] Name the search cursor instead of
flagging it
......................................................................
[ASTERIXDB-3817][STO] Name the search cursor instead of flagging it
Which class implemented a vector search was decided by a Boolean under
USE_TOPK_SEARCH in the index-access-parameters map: the search operator
put it there, and LSMVTreeIndexAccessor overrode createSearchCursor to
read it back and hand out the top-K cursor. Two layers apart, through an
untyped map, for a decision the operator makes.
IndexSearchOperatorNodePushable already has the hook for this --
createCursor(IIndex, IIndexAccessor) -- so
VTreeSearchOperatorNodePushable overrides it and calls the public
createTopKSearchCursor directly. The flag, its constant, and the
accessor subclass are gone; LSMVTreeIndexAccessor existed for nothing
else, so LSMVTree now returns a plain LSMTreeIndexAccessor.
This also settles the concern that cursor selection and the index's
quantization were independent flags that had to agree with nothing
checking they did. There is no selection flag now. The cursor still
verifies the index is quantized, because being asked for still does not
establish it -- the caller chooses the cursor, the index decides its own
layout -- but the message no longer blames a parameter that no longer
exists.
The test paths that used the flag to pick a cursor now name it the same
way. That reads better than it did: the cursor-agreement tests compare
two implementations, and saying which two is the point of the test,
rather than leaving it to an access-parameter lookup.
Ext-ref: MB-73194
Generated-by: Claude Opus 5 <[email protected]>
Change-Id: Iaa22c8d92458e0fedd30edf13b629e84cb8f2731
---
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-vtree/src/main/java/org/apache/hyracks/storage/am/lsm/vector/dataflow/VTreeSearchOperatorNodePushable.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-vtree/src/main/java/org/apache/hyracks/storage/am/lsm/vector/impls/LSMVTree.java
D
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-vtree/src/main/java/org/apache/hyracks/storage/am/lsm/vector/impls/LSMVTreeIndexAccessor.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-vtree/src/main/java/org/apache/hyracks/storage/am/lsm/vector/impls/LSMVTreeTopKSearchCursor.java
M
hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/vector/VectorTreeTestUtils.java
M
hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-vtree-test/src/test/java/org/apache/hyracks/storage/am/lsm/vector/LSMVTreeCursorAgreementTest.java
M
hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-vtree-test/src/test/java/org/apache/hyracks/storage/am/lsm/vector/LSMVTreeMultiClusterAgreementTest.java
M
hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-vtree-test/src/test/java/org/apache/hyracks/storage/am/lsm/vector/quantized/LSMVTreeTopKSearchComponentReleaseTest.java
8 files changed, 47 insertions(+), 106 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/83/21683/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21683?usp=email
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Iaa22c8d92458e0fedd30edf13b629e84cb8f2731
Gerrit-Change-Number: 21683
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>