>From Ian Maxon <[email protected]>: Attention is currently required from: Murtadha Hubail.
Ian Maxon has posted comments on this change by Murtadha Hubail. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21959?usp=email ) Change subject: [NO ISSUE][EXT] Fix the library listing when databases are in use ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: > Any specific reason? Doesn't this patch make the existing API work for both > cloud and non-cloud mode […] the specific reason is that it is making the traversal code more permissive (i.e. allowing CONTINUE where currently any file leads to TERMINATE). this is dangerous, and i strongly advise against doing it without careful inspection. i don't disagree with fixing it eventually, but it cannot be something claude oneshots (with no tests) and i give a terse look to. this is intricate code which if it does not: - only allow the *exact* file pattern we expect from storage to be traversed - only allows the names of the paths we expect to be components of the library name to be retrieved can lead to a critical security vulnerability. because it has before. if you want to merge it i can't stop you, but don't say i didn't say anything. i agree that it should be done a different way (e.g. simply proxying metadata). that is further evidence to just leave it be for now. the way it's done here is not a good idea in general, and if you do it this way, you have to be exceedingly careful. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21959?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ic0300108f9ee051415b68b05932dab6effc1dbaf Gerrit-Change-Number: 21959 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Comment-Date: Fri, 02 Oct 2026 14:43:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Murtadha Hubail <[email protected]> Comment-In-Reply-To: Ian Maxon <[email protected]>
