>From Hongyu Shi <[email protected]>: Attention is currently required from: Shahrzad Shirazi.
Hongyu Shi has posted comments on this change by Shahrzad Shirazi. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21985?usp=email ) Change subject: [NO ISSUE][COMP][RT] CLUSTER BY: share the k-means vector store ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: I went through this carefully and it looks correct to me and indeed actually an potential resource optimization in my backlog (never got the chance to do but it's good to be caught by perf tests ...). note: Under kmeans_parallel, both loops used to write the same per-partition vector file. Now the oversampling loop keeps its file and the Lloyd loop reads it, then deletes it after its last iteration. That saves a second decode pass over the input and a second input-sized write per partition, and halves the peak disk space for vectors. The per-iteration reads are unchanged and results stay identical (should be) since the Lloyd loop reads exactly the vectors it would have stored. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21985?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I2d34e7e35ae889edbce294e96889d187186c9d14 Gerrit-Change-Number: 21985 Gerrit-PatchSet: 1 Gerrit-Owner: Shahrzad Shirazi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hongyu Shi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Shahrzad Shirazi <[email protected]> Gerrit-Comment-Date: Sat, 03 Oct 2026 06:45:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
