>From Michael Blow <[email protected]>:

Attention is currently required from: Ali Alsuliman, Ian Maxon, Murtadha 
Hubail, Ritik Raj.

Michael Blow has posted comments on this change by Michael Blow. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21627?usp=email )

Change subject: [ASTERIXDB-3940][STO] Reclaim idle memory components when vbc 
is full
......................................................................


Patch Set 3:

(2 comments)

Commit Message:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21627/comment/83dee45d_d7aef0c9?usp=email
 :
PS2, Line 46: Change-Id: I4cccd9857d277b1a32017f0afcbd644e33388f2f
> should be the last line shouldn't it? though i guess it worked
Last paragraph is all that is required by Gerrit.


File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/GlobalVirtualBufferCache.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21627/comment/a296e7b8_945635c4?usp=email
 :
PS2, Line 519:          * {@link #selectFlushIndex()} will never select, 
because it only selects components which are not empty.
> I looked at that, but it doesn't work. […]
Done



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21627?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: totoro
Gerrit-Change-Id: I4cccd9857d277b1a32017f0afcbd644e33388f2f
Gerrit-Change-Number: 21627
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Blow <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Ritik Raj <[email protected]>
Gerrit-Attention: Murtadha Hubail <[email protected]>
Gerrit-Attention: Ian Maxon <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Attention: Ritik Raj <[email protected]>
Gerrit-Comment-Date: Sat, 03 Oct 2026 17:08:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ian Maxon <[email protected]>
Comment-In-Reply-To: Michael Blow <[email protected]>

Reply via email to