>From Michael Blow <[email protected]>:

Attention is currently required from: Ali Alsuliman, Ian Maxon, Murtadha 
Hubail, Ritik Raj.

Michael Blow has posted comments on this change by Michael Blow. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21627?usp=email )

Change subject: [ASTERIXDB-3940][STO] Reclaim idle memory components when vbc 
is full
......................................................................


Patch Set 3:

(2 comments)

Commit Message:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21627/comment/bfb78fa7_c4600cd1?usp=email
 :
PS2, Line 7: NO ISSUE]
> this seems like a substantial enough change to merit an issue, because it is 
> changing longstanding c […]
Done


File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/GlobalVirtualBufferCache.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21627/comment/176d77e6_5217ee52?usp=email
 :
PS2, Line 518: * behind for data that never arrived, and enough such indexes 
fill the cache with components that
             :          * {@link #selectFlushIndex()} will never select, 
because it only selects components which are not empty.
> if this is the specific situation this method fixes, why not instead make it 
> so that selectFlushInde […]
Done



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21627?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: totoro
Gerrit-Change-Id: I4cccd9857d277b1a32017f0afcbd644e33388f2f
Gerrit-Change-Number: 21627
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Blow <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Ritik Raj <[email protected]>
Gerrit-Attention: Murtadha Hubail <[email protected]>
Gerrit-Attention: Ian Maxon <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Attention: Ritik Raj <[email protected]>
Gerrit-Comment-Date: Sat, 03 Oct 2026 17:08:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ian Maxon <[email protected]>

Reply via email to