>From Ian Maxon <[email protected]>: Attention is currently required from: Hussain Towaileb.
Ian Maxon has posted comments on this change by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21987?usp=email ) Change subject: [ASTERIXDB-3935][EXT]: Guard Iceberg string ranges ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Patchset: PS1: i don't like the duplicated tests and i don't think that its true that asterix-external-data has no test jar. if it doesn't it can have one, that's better than copying the class twice. however it's a test issue so it can get fixed later File asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/util/iceberg/StringOrderCorpus.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21987/comment/799162da_dc5e98f2?usp=email : PS1, Line 30: module publishes no test-jar i don't think that's true? maybe it doesn't exist in maven central but i think it does exist locally -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21987?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ib53c1d5785584787df7e4ca3b48386b1b46ebca6 Gerrit-Change-Number: 21987 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Mon, 05 Oct 2026 01:13:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
