Simon Wilkinson
Wed, 06 Jan 2010 08:05:05 -0800
Marc Aurele La France wrote:
src/afs/LINUX*/osi_file.c (all versions) should set the inode's S_NOATIME, instead of MS_NOATIME, as the latter is a super block flag, which in recent kernels collides with another inode flag. This means preventing atime updates for cache files isn't currently effective.
The split between MS_NOATIME (as a super block flag) and S_NOATIME (as an inode flag) seems to have happened with 2.4.0.
I've put a patch to address this into gerrit as http://gerrit.openafs.org/1070
Also, given AFS itself doesn't appear to track access times, shouldn't src/afs/LINUX*/osi_vfsops.c (again, all versions) set MS_NOATIME in its super block?
Yes, I think it probably should. A patch for this is in gerrit as http://gerrit.openafs.org/1071I suspect this one will require a lot of testing, just to make sure the mount options change has no unintended side effects.
S. -- The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336. _______________________________________________ OpenAFS-devel mailing list OpenAFS-devel@openafs.org https://lists.openafs.org/mailman/listinfo/openafs-devel