W dniu 2013-01-22 16:13, CeDeROM pisze: > On Tue, Jan 22, 2013 at 4:02 PM, Spencer Oliver <[email protected]> wrote: >> If you feel this name needs changing then that should be a separate >> change, otherwise it is hard for us to review. >> I do not see any value in adding oocd_ prefix to names, just more noise. > > I have done smaller changes like that with comments for example and > these were a "noise" for you as well. > > Because YOU can't see any value it does not mean there is no value. > Except there is a new transport capability, I have presented way the > code should look also in other places. I had two free weeks to > introduce other changes and that time is now wasted.
If you're refering to the patches that changed some debug outputs, renamed files or changed some comments in the places that were affected by one of your previous changes I also think it's good to have them merged. It would not be a blocker for me, but I don't mind that being squshed... What's the value of adding file abc.c and renaming it to def.c 3 changes later? Why not have def.c from the beginning, with complete history, without any renames? 4\/3!! ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnnow-d2d _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
