W dniu 2013-01-22 17:18, CeDeROM pisze: > Debug output is extremely important in OpenOCD because: > 1. Program fail on error and the debug messages are the only way to > know what went wrong and why. > 2. Current debug messages does not state origin and time of the > message - this is why prefix from which layer comes the message is > very important. The goal should be the LOG script modification in a > way that will tell which file on which line produced a message and > when... > 3. I want things to be clear and unambiguous, while most of the > current messages are abmoguous, this is my step towards something > better. > > Regarding the file names it simply means that proper directory > structure is better than flat file list with prefix when the directory > structure represents code organization :-) > > I know these are simple things but small nice simple things make life good :-)
I of course agree, but we're probably not on the same case here... If you have a patch series: 1. ... 2. ... 3. add file abc.c and abc.h 4. ... 5. ... 6. change abc.c -> def.c, abc.h -> def.h, because original name did not fit well 7. add debug output to xxx.c 8. ... 9. ... 10. change debug output in xxx.c like this: "%s" -> "xxx module - %s" just to show that you're in xxx module 11. ... 12 ... Then commits 6 and 10 just don't make any sense - this can be "right" right from the beginning, that's why Spencer merged them - in the above example 6 is merged with 3, and 10 with 7. There's absolutely no point in having a separate commit change your change that wasn't merged yet (; 4\/3!! ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnnow-d2d _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
