Andreas Fritiofson wrote:
> >    clang: fix warning by adding assert that shows that a variable is used
..
> >
> > +       assert(e == JIM_OK);
> > +
..

> I'm not very fond of the idea of merging patches with the sole
> purpose of fixing scan-build false positives.

+1


> if we start tweaking perfectly good code and adding nonsense checks
> just to get a clean scan-build output, I think that's a step
> backwards in terms of code quality.

Yes, I agree. I'm not at all fond of throwing assert() at the clang
warnings.


Thanks

//Peter
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to