opensg-core  

[Opensg-core] [OpenSG 2] Suspect loop in OSGRenderPartition.cpp:dropFunctor

Carsten Neumann
Sun, 08 Jul 2007 04:24:12 -0700

        Hi,

the loop below is around line 636 in OSGRenderPartition.cpp in the
occlusion culling case of dropFunctor.
Please note that i is not used inside the loop, which looks strange.

        for(UInt32 i = 1; i < 8; i++)
        {
            if(p[0][2] < objPos[2])
            {
                objPos[2] = p[0][2];
            }
        }

I guess the loop attempts to find the point (p is declared: Pnt3f p[8])
with the smallest z value, so it should probably look like:

        for(UInt32 i = 1; i < 8; ++i)
        {
            if(p[i][2] < objPos[2])
                objPos[2] = p[i][2];
        }

Could someone familiar with this code verify it please.

        Thanks,
                Carsten

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Opensg-core mailing list
Opensg-core@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensg-core