Re: [OpenWrt-Devel] [PATCH] add BIRD Internet Routing Daemon package

[Ondrej Zajicek]

On Sat, Nov 14, 2009 at 07:52:51PM +0100, Felix Fietkau wrote:
> > I just don't understand why there are
> > 
> > ifeq ($(BUILD_VARIANT),full)
> >   Package/hostapd/install = $(Package/InstallTemplate)
> > else
> >   Package/hostapd-mini/install = $(Package/InstallTemplate)
> > endif
> > 
> > and not just
> > 
> > Package/hostapd/install = $(Package/InstallTemplate)
> > Package/hostapd-mini/install = $(Package/InstallTemplate)
>
> make is run twice on the package, each time with a different
> BUILD_VARIANT. The reason for the ifeq is that the full variant must
> only generate the hostapd package and the other one must only generate
> hostapd-mini. For hostapd-utils it does not matter which variant is
> used, hence it is enabled for both build variants.

It looks strange to me because setting  Package/hostapd/install  is just
setting of some variable which is a part of package building process,
but proper solution for 'the full variant must only generate the hostapd
package and the other one must only generate hostapd-mini' seems to
me that makefile targets related to hostapd-mini should not be requested
during make of hostapd full (and vice versa).

-- 
Elen sila lumenn' omentielvo

Ondrej 'SanTiago' Zajicek (email: santi...@crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."

signature.asc
Description: Digital signature

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel