Hadoop QA (JIRA)
Mon, 08 Feb 2010 16:49:54 -0800
[
https://issues.apache.org/jira/browse/PIG-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831224#action_12831224
]
Hadoop QA commented on PIG-1230: -------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12435203/pig-1230.patch against trunk revision 907760. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/204/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/204/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/204/console This message is automatically generated. > Streaming input in POJoinPackage should use nonspillable bag to collect tuples > ------------------------------------------------------------------------------ > > Key: PIG-1230 > URL: https://issues.apache.org/jira/browse/PIG-1230 > Project: Pig > Issue Type: Bug > Components: impl > Affects Versions: 0.6.0 > Reporter: Ashutosh Chauhan > Assignee: Ashutosh Chauhan > Fix For: 0.7.0 > > Attachments: pig-1230.patch > > > Last table of join statement is streamed through instead of collecting all > its tuple in a bag. As a further optimization of that, tuples of that > relation are collected in chunks in a bag. Since we don't want to spill the > tuples from this bag, NonSpillableBag should be used to hold tuples for this > relation. Initially, DefaultDataBag was used, which was later changed to > InternalCachedBag as a part of PIG-1209. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.