Tom Chiverton
Thu, 17 Apr 2008 05:11:43 -0700
Some of you may remember that I've posted in the past about Reactor causing 'branch offset too large for short' ColdFusion errors because of the length of the files it generates. If you don't recall, the archive is here: http://www.mail-archive.com/reactor@reactorframework.com/msg01792.html The solution at the time was to use a view that had a sub set of the tables columns, and happened to be below the magic limit. But it's possible this work around will not always work for users, because there may be no sub set, and splitting the table in half into two views only postpones the problem again. So - maybe we should change how the files (reactor/project/<name>/Dao/<table>Dao.cfc in this case) are built. Options that spring to mind are: 1) Trim whitspace in file - may still have too many properties 2) change what the code does - rather than several lines for each property of the record in create() and update(): #Convention.formatInsertFieldName('case_id', 'veo_short')# , #Convention.formatInsertFieldName('client', 'veo_short')# , .... , <cfqueryparam cfsqltype="cf_sql_varchar" maxlength="60" value="#arguments.to.incidentLocation1#" null="#Iif(NOT Len(arguments.to.incidentLocation1), DE(true), DE(false))#" /> , <cfqueryparam cfsqltype="cf_sql_varchar" maxlength="60" value="#arguments.to.incidentLocation2#" null="#Iif(NOT Len(arguments.to.incidentLocation2), DE(true), DE(false))#" /> ... <cfset arguments.to.totalCostDamagesReserve = qRead.totalCostDamagesReserve /> <cfset arguments.to.division = qRead.division /> ... #Convention.formatUpdateFieldName('case_id')# = <cfqueryparam cfsqltype="cf_sql_integer" maxlength="10" value="#arguments.to.id#" null="#Iif(NOT Len(arguments.to.id), DE(true), DE(false))#" /> , #Convention.formatUpdateFieldName('client')# = <cfqueryparam cfsqltype="cf_sql_varchar" maxlength="8" value="#arguments.to.clientCode#" null="#Iif(NOT Len(arguments.to.clientCode), DE(true), DE(false))#" /> We could use a loop over the relevant properties, and/or do these Convention look ups once at generation time and just leave the string result in the template ? Would that be a good way forward ? I can't promise to implement this, but would aim to at least take a crack at it now and again at home (can't do this in work, because then you guys will never get the changes back). -- Tom Chiverton **************************************************** This email is sent for and on behalf of Halliwells LLP. Halliwells LLP is a limited liability partnership registered in England and Wales under registered number OC307980 whose registered office address is at Halliwells LLP, 3 Hardman Square, Spinningfields, Manchester, M3 3EB. A list of members is available for inspection at the registered office. Any reference to a partner in relation to Halliwells LLP means a member of Halliwells LLP. Regulated by The Solicitors Regulation Authority. CONFIDENTIALITY This email is intended only for the use of the addressee named above and may be confidential or legally privileged. If you are not the addressee you must not read it and must not use any information contained in nor copy it nor inform any person other than Halliwells LLP or the addressee of its existence or contents. If you have received this email in error please delete it and notify Halliwells LLP IT Department on 0870 365 2500. For more information about Halliwells LLP visit www.halliwells.com. -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- Reactor for ColdFusion Mailing List [EMAIL PROTECTED] Archives at: http://www.mail-archive.com/reactor%40doughughes.net/ -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --