On Jun 21, 2008, at 12:48 PM, Denis Washington wrote:
On Sat, 2008-06-21 at 12:27 -0400, Jeff Johnson wrote:
On Jun 21, 2008, at 12:05 PM, Denis Washington wrote:
What if the transaction fails? register_package() would have
returned
without error although the registration was unsuccessful then,
and all
files would already be installed.
What if you've added a header, but your daemon exits before
successfully computing and adding RPMTAG_SIZE withthe
_close_package() method?
Got me. Although, if a dummy value (e.g. 0) was added in
_register_package(), an unsuccessful _close_package() wouldn't be a
harm
at all. The header would be complete anyway.
Hint: RPMTAG_SIZE simply does not matter. Nor do Vendor: Packager:
Description: Summary: and all the other goopiness carried in
markup (because its easy to add) and rpmdb Headers.
OTOH, RPMTAG_FILESTATES is gonna matter a _LOT_. So
will leaving stale locks, and forgetting to attach stderr when
your widdle daemon forks.
(aside) You won't be the first to write stderr directly into
an rpmdb. At least 2 major linux vendors have forgotten
to do the right thing with stderr when forking a daemon,
and error messages got written to customer databases because of the
astonishing lack of QA associated with Linux vendors.
Guess who got to fox the problem?
Same issue, sh*t happens. I'm just trying to minimize the window
where disasters occur because I _WILL_ have to do the support
even if your "Berlin API" code is flawed.
Which motivates me to do the best I can to avoid the "desaster
window".
Really.
Good.
Too little: currently yes. Too late: no. Just my opinion. We both
know
that our thoughts on this differ quite much.
I've been at RPM packaging for over a decade, you mebbe a month.
Wanna bet on whose opinion is correct? ;-)
Despite thinking that opinions can hardly be measured in terms of
"correctness", there are enough people that keep flawed opinions for
their entire life without reflecting on after some time. Maybe my
comparatively little experience just gives my the flexibility of mind
that you might be missing after more than ten years. But I was
actually
not planning to start a whose-right flame war.
My interest in opinions is directly related to the amount
of money I've wagered, so far none on the LSB "Berlin API".
And I've heard all the "trust" foolishness on the packaging
list for years.
No SHA1 == no trust is the engineering answer.
73 de Jeff
______________________________________________________________________
RPM Package Manager http://rpm5.org
LSB Communication List rpm-lsb@rpm5.org
