Re: [asterisk-dev] [Code Review] 4460: res_pjsip_refer: Fix occasional unexpected BYE sent after receiving a REFER.

2015-03-06 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4460/ --- (Updated March 6, 2015, 5:27 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 4463: core: Introduce chaos into memory allocations

2015-03-06 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4463/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4460: res_pjsip_refer: Fix occasional unexpected BYE sent after receiving a REFER.

2015-03-06 Thread rmudgett
On March 5, 2015, 2:24 p.m., Ashley Sanders wrote: /branches/13/res/res_pjsip_refer.c, line 477 https://reviewboard.asterisk.org/r/4460/diff/1/?file=71745#file71745line477 For clarity, I suggest using a default case in the switch statement rather than representing the default

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

2015-03-06 Thread Ed Hynan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4450/ --- (Updated March 6, 2015, 10:59 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4460: res_pjsip_refer: Fix occasional unexpected BYE sent after receiving a REFER.

2015-03-06 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4460/#review14605 --- Logically, this looks sound. Structurally, I agree with

Re: [asterisk-dev] [Code Review] 4455: res_pjsip: conflicting endpoint identifiers

2015-03-06 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4455/#review14606 --- Ship it! Ship It! - Mark Michelson On March 5, 2015, 11:40

Re: [asterisk-dev] [Code Review] 4437: dns: Define a core DNS API with examples.

2015-03-06 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4437/ --- (Updated March 6, 2015, 6:45 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4454: chan_sip: Fix realtime locking inversion when poking a just built peer.

2015-03-06 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4454/ --- (Updated March 6, 2015, 1:18 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4452: Testsuite: ARI channel subscription tests

2015-03-06 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4452/ --- (Updated March 6, 2015, 1:45 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4444: chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

2015-03-06 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r// --- (Updated March 6, 2015, 1:52 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 4462: DNS core unit tests

2015-03-06 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4462/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

2015-03-06 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4450/#review14608 --- Ship it! I've given this several looks, and I think it's good

Re: [asterisk-dev] [Code Review] 4459: Asterisk terminates when playing a voicemail stored in LDAP

2015-03-06 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4459/#review14609 --- Ship it! Ship It! - Mark Michelson On March 4, 2015, 9:07

Re: [asterisk-dev] [Code Review] 4463: core: Introduce chaos into memory allocations

2015-03-06 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4463/ --- (Updated March 7, 2015, 12:01 a.m.) Review request for Asterisk