Re: [Bridge] brigde does not relay BPDU multicast pkgs
Ross Vandegrift wrote on 12/05/2009 15:06:22: > > On Tue, May 12, 2009 at 11:43:17AM +0200, Joakim Tjernlund wrote: > > Looking into this I got a question: > > Should the bridge forward the whole bridge multicast group except PAUSE > > or only the STP multicast address? > > If you're implementing that, it should only forward the STP address. > > 802.1X and LACP will be very suprised (and very broken) when their > PDUs start being forwarded to entities on other bridges... > > Ross I just sent a patch "bridge: relay bridge multicast pkgs if !STP" to the list. Let me know what you think. Jocke ___ Bridge mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/bridge
Re: [Bridge] brigde does not relay BPDU multicast pkgs
On Tue, May 12, 2009 at 08:44:44AM -0500, [email protected] wrote: > > If you're implementing that, it should only forward the STP address. > > > > 802.1X and LACP will be very suprised (and very broken) when their > > PDUs start being forwarded to entities on other bridges... > > They break when there's a simple hub on the network? Correct. Both technologies depend on being run over point-to-point ethernet links - they are communications between entities that manage individual bridge port roles. -- Ross Vandegrift [email protected] "If the fight gets hot, the songs get hotter. If the going gets tough, the songs get tougher." --Woody Guthrie ___ Bridge mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/bridge
Re: [Bridge] brigde does not relay BPDU multicast pkgs
On Tue, May 12, 2009 at 8:06 AM, Ross Vandegrift wrote: > On Tue, May 12, 2009 at 11:43:17AM +0200, Joakim Tjernlund wrote: >> Looking into this I got a question: >> Should the bridge forward the whole bridge multicast group except PAUSE >> or only the STP multicast address? > > If you're implementing that, it should only forward the STP address. > > 802.1X and LACP will be very suprised (and very broken) when their > PDUs start being forwarded to entities on other bridges... They break when there's a simple hub on the network? > > Ross > > -- > Ross Vandegrift > [email protected] > > "If the fight gets hot, the songs get hotter. If the going gets tough, > the songs get tougher." > --Woody Guthrie > ___ > Bridge mailing list > [email protected] > https://lists.linux-foundation.org/mailman/listinfo/bridge > ___ Bridge mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/bridge
Re: [Bridge] brigde does not relay BPDU multicast pkgs
On Tue, May 12, 2009 at 11:43:17AM +0200, Joakim Tjernlund wrote: > Looking into this I got a question: > Should the bridge forward the whole bridge multicast group except PAUSE > or only the STP multicast address? If you're implementing that, it should only forward the STP address. 802.1X and LACP will be very suprised (and very broken) when their PDUs start being forwarded to entities on other bridges... Ross -- Ross Vandegrift [email protected] "If the fight gets hot, the songs get hotter. If the going gets tough, the songs get tougher." --Woody Guthrie ___ Bridge mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/bridge
Re: [Bridge] brigde does not relay BPDU multicast pkgs
Joakim Tjernlund/Transmode wrote on 10/05/2009 19:47:19: > > Stephen Hemminger wrote on 08/05/2009 18:02:26: > > > On Fri, 8 May 2009 10:33:37 +0200 > > Joakim Tjernlund wrote: > > > > > > > > Hi List > > > > > > We have noticed that when STP is off in the linux bridge, it won't > > > relay STP pkts received from other bridges. > > > This feels like a bug(a bad one too). I hope this isn't > > > intentional behaviour? > > > > > > Jocke > > > > > > ___ > > > Bridge mailing list > > > [email protected] > > > https://lists.linux-foundation.org/mailman/listinfo/bridge > > > > It is a debatable whether this is correct behaviour. > > My current opinion is that it needs to forward STP packets if > > STP is off. This would allow for loop detection by other bridges > > doing STP. > > Exactly, I had a look at the bride code and it wasn't obvious > too me where to add the code to make this happen. Any pointers? Looking into this I got a question: Should the bridge forward the whole bridge multicast group except PAUSE or only the STP multicast address? Jocke ___ Bridge mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/bridge
Re: [Bridge] brigde does not relay BPDU multicast pkgs
Stephen Hemminger wrote on 08/05/2009 18:02:26: > On Fri, 8 May 2009 10:33:37 +0200 > Joakim Tjernlund wrote: > > > > > Hi List > > > > We have noticed that when STP is off in the linux bridge, it won't > > relay STP pkts received from other bridges. > > This feels like a bug(a bad one too). I hope this isn't > > intentional behaviour? > > > > Jocke > > > > ___ > > Bridge mailing list > > [email protected] > > https://lists.linux-foundation.org/mailman/listinfo/bridge > > It is a debatable whether this is correct behaviour. > My current opinion is that it needs to forward STP packets if > STP is off. This would allow for loop detection by other bridges > doing STP. Exactly, I had a look at the bride code and it wasn't obvious too me where to add the code to make this happen. Any pointers? > > Longer term, RSTP needs to be fully integrated and default to on. > That way the average user will be safe from loops. yes, please :) Jocke ___ Bridge mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/bridge
Re: [Bridge] brigde does not relay BPDU multicast pkgs
On Fri, May 8, 2009 at 11:02 AM, Stephen Hemminger wrote: > On Fri, 8 May 2009 10:33:37 +0200 > Joakim Tjernlund wrote: > >> >> Hi List >> >> We have noticed that when STP is off in the linux bridge, it won't >> relay STP pkts received from other bridges. >> This feels like a bug(a bad one too). I hope this isn't >> intentional behaviour? >> >> Jocke >> >> ___ >> Bridge mailing list >> [email protected] >> https://lists.linux-foundation.org/mailman/listinfo/bridge > > It is a debatable whether this is correct behaviour. > My current opinion is that it needs to forward STP packets if > STP is off. This would allow for loop detection by other bridges > doing STP. Also, if the bridge code forwards them, it's trivially easy to block these packets with ebtables if that's the desired behavior. It's not so easy to forward them if the bridge code drops them. > > Longer term, RSTP needs to be fully integrated and default to on. > That way the average user will be safe from loops. > > -- > ___ > Bridge mailing list > [email protected] > https://lists.linux-foundation.org/mailman/listinfo/bridge > ___ Bridge mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/bridge
Re: [Bridge] brigde does not relay BPDU multicast pkgs
On Fri, 8 May 2009 10:33:37 +0200 Joakim Tjernlund wrote: > > Hi List > > We have noticed that when STP is off in the linux bridge, it won't > relay STP pkts received from other bridges. > This feels like a bug(a bad one too). I hope this isn't > intentional behaviour? > > Jocke > > ___ > Bridge mailing list > [email protected] > https://lists.linux-foundation.org/mailman/listinfo/bridge It is a debatable whether this is correct behaviour. My current opinion is that it needs to forward STP packets if STP is off. This would allow for loop detection by other bridges doing STP. Longer term, RSTP needs to be fully integrated and default to on. That way the average user will be safe from loops. -- ___ Bridge mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/bridge
Re: [Bridge] brigde does not relay BPDU multicast pkgs
Ross Vandegrift wrote on 08/05/2009 14:14:39: > On Fri, May 08, 2009 at 10:33:37AM +0200, Joakim Tjernlund wrote: > > We have noticed that when STP is off in the linux bridge, it won't > > relay STP pkts received from other bridges. > > This feels like a bug(a bad one too). I hope this isn't > > intentional behaviour? > > IEEE 802.1D specifies that no bridge should ever forward packets > destined to the bridge multicast groups. See requirement 7.12.6 in > 802.1D-2004. uhh, that was a surprise. My impression is that normal switches do forward the bridge multicast group, is this true? If so can we add an option to the linux bridge to allow forwarding of bridge multicast groups? Jocke ___ Bridge mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/bridge
Re: [Bridge] brigde does not relay BPDU multicast pkgs
On Fri, May 08, 2009 at 10:33:37AM +0200, Joakim Tjernlund wrote: > We have noticed that when STP is off in the linux bridge, it won't > relay STP pkts received from other bridges. > This feels like a bug(a bad one too). I hope this isn't > intentional behaviour? IEEE 802.1D specifies that no bridge should ever forward packets destined to the bridge multicast groups. See requirement 7.12.6 in 802.1D-2004. -- Ross Vandegrift [email protected] "If the fight gets hot, the songs get hotter. If the going gets tough, the songs get tougher." --Woody Guthrie ___ Bridge mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/bridge
[Bridge] brigde does not relay BPDU multicast pkgs
Hi List We have noticed that when STP is off in the linux bridge, it won't relay STP pkts received from other bridges. This feels like a bug(a bad one too). I hope this isn't intentional behaviour? Jocke ___ Bridge mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/bridge
