Re: working together

2009-04-09 Thread Zhu Han
Jonathan, I can understand why you refactored the code a lot in the last few month. And I saw you were working hard to improve it in the last few months. However, the talents from Facebook has done a lot of work to bring Cassandra to the world. And they have deployed it to the production system

Re: working together

2009-04-09 Thread Zhu Han
, hanzhu -- Forwarded message -- From: Zhu Han schumi@gmail.com Date: Thu, Apr 9, 2009 at 2:24 PM Subject: Re: working together To: cassandra-dev@incubator.apache.org Jonathan, I can understand why you have refactored the code a lot in the last few month. And I saw you were

Re: working together

2009-04-09 Thread Jonathan Ellis
cautious, should we? best regards, hanzhu -- Forwarded message -- From: Zhu Han schumi@gmail.com Date: Thu, Apr 9, 2009 at 2:24 PM Subject: Re: working together To: cassandra-dev@incubator.apache.org Jonathan, I can understand why you have refactored the code a lot

Re: working together

2009-04-08 Thread Neophytos Demetriou
Torsten Curdt wrote: On Wed, Apr 8, 2009 at 05:30, Ian Holsman i...@holsman.net wrote: guys. we have a private list to discuss the pro's and con's of people being a comitter. keep these personal discussions off the development list. It doesn't help anyone. Not sure I agree here. I did not see

Re: working together

2009-04-08 Thread Johan Oskarsson
+1 for Sandeeps development process suggestions. In order to address some of the issues brought forward in this thread I have adapted the following wiki pages from other projects and from various emails. They could serve as the basis for an initial process.

Re: working together

2009-04-08 Thread Roland Dreier
I think we have a handle on this now. All changes are put on Jira for review and are not committed until there is at least one +1 from a reviewer. (I personally prefer post-commit review because manually attaching and applying patches is tedious but we don't have enough people following the

Re: working together

2009-04-08 Thread Sandeep Tata
The refactoring question seems to be a bit of thorn: My understanding was that new committers come in and start with some feature implement that and then slowly start looking into what more they could do going forward. It is NOT come in and refactor the hell out of the system because you like

Re: working together

2009-04-08 Thread Jonathan Ellis
On Wed, Apr 8, 2009 at 6:26 PM, Sandeep Tata sandeep.t...@gmail.com wrote: I think it is reasonable that a codebase that has evolved for over two years has significant opportunity for refactoring when it is opened to a host of new developers. That said, large scale refactoring *at this stage*

Re: working together

2009-04-07 Thread Matthieu Riou
On Tue, Apr 7, 2009 at 1:10 PM, Torsten Curdt tcu...@apache.org wrote: Hey folks, I thought back and forth about whether this email should go to the private list or not. But I have a Cocoon background and in Cocoon land we found it useful to only use the private list when there is really no

Re: working together

2009-04-07 Thread Ian Holsman
just on a point here. They were invited from Day 1 (Actually 20-Jan-2009) to be on there. It wasn't done out of malice. On 08/04/2009, at 6:10 AM, Torsten Curdt wrote: Unfortunately no one noticed that the actual authors bringing the code were NOT on the private list where the vote was

Re: working together

2009-04-07 Thread Matthieu Riou
On Tue, Apr 7, 2009 at 5:39 PM, Ian Holsman i...@holsman.net wrote: just on a point here. They were invited from Day 1 (Actually 20-Jan-2009) to be on there. It wasn't done out of malice. So I'm slightly confused as to what the PPMC composition is now. On 08/04/2009, at 6:10 AM, Torsten

Re: working together

2009-04-07 Thread Avinash Lakshman
I don't think I ever spoke about anyone's skills ever over here. Avinash On Tue, Apr 7, 2009 at 9:12 PM, Ian Holsman i...@holsman.net wrote: Matt. please don't. your comments are just as valuable as anyone else's. just be aware that if you talk about someone's skills on this list, or their

Re: working together

2009-04-07 Thread Matthieu Riou
On Tue, Apr 7, 2009 at 8:11 PM, Avinash Lakshman avinash.laksh...@gmail.com wrote: snipped (2) This is something that I have said many times over. Certain things are the way they are for a reason. For example when I say ConcurrentHashMap is a memory hog I say it because we have seen this in

Re: working together

2009-04-07 Thread Roland Dreier
(2) This is something that I have said many times over. Certain things are the way they are for a reason. For example when I say ConcurrentHashMap is a memory hog I say it because we have seen this in practice. How does it manifest itself? I obviously do not recall since all this was over