Re: Building GNU Classpath on Fedora 17
- Original Message - > On Tue, Mar 12, 2013 at 12:47 PM, Andrew Hughes > wrote: > > Looking at rpm -ql gettext-devel on my RHEL system, it seems to add > > a slew > > of m4 files to /usr/share/aclocal. Maybe if -e > > /usr/share/aclocal/gettext.m4 > > in autogen.sh would be sufficient? > > The attached patch works for me. Does it look OK to commit? > I don't really see the need for the have_gettext variable. Wouldn't: if [ ! -e /usr/share/aclocal/gettext.m4 ] ; then echo echo "You must have gettext installed to compile $PROJECT." DIE=1 fi be simpler? I am a little worried that there are systems where gettext.m4 will not be in that location. Using the result of $(aclocal --print-ac-dir) instead of /usr/share/aclocal would be a better option i.e. if [ ! -e $(aclocal --print-ac-dir)/gettext.m4 ] -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
Re: Building GNU Classpath on Fedora 17
On Tue, Mar 12, 2013 at 12:47 PM, Andrew Hughes wrote: > Looking at rpm -ql gettext-devel on my RHEL system, it seems to add a slew > of m4 files to /usr/share/aclocal. Maybe if -e /usr/share/aclocal/gettext.m4 > in autogen.sh would be sufficient? The attached patch works for me. Does it look OK to commit? 0001-Check-for-gettext-in-autogen.sh.patch Description: Binary data
Re: Building GNU Classpath on Fedora 17
- Original Message - > Hi Brian, > > On Mon, Mar 11, 2013 at 4:41 PM, Brian Jones > wrote: > > Add a configure check for whatever the dependency is... > > I'm having difficult time figuring out what to check for... It seems > that gettext-devel package provides AC_LIB_PREPARE_PREFIX via > /usr/share/aclocal/lib-prefix.m4 that's automagically picked up by > autogen.sh. Surely I can't just go and check if the file exists? > > Pekka > > Looking at rpm -ql gettext-devel on my RHEL system, it seems to add a slew of m4 files to /usr/share/aclocal. Maybe if -e /usr/share/aclocal/gettext.m4 in autogen.sh would be sufficient? configure is the wrong place as this is the script that creates configure :) FWIW, I've never been a fan of these -devel packages. They seem to cause more problems than they solve. -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
Re: Building GNU Classpath on Fedora 17
Hi Brian, On Mon, Mar 11, 2013 at 4:41 PM, Brian Jones wrote: > Add a configure check for whatever the dependency is... I'm having difficult time figuring out what to check for... It seems that gettext-devel package provides AC_LIB_PREPARE_PREFIX via /usr/share/aclocal/lib-prefix.m4 that's automagically picked up by autogen.sh. Surely I can't just go and check if the file exists? Pekka
Re: Building GNU Classpath on Fedora 17
On Mar 11, 2013, at 9:57 AM, Pekka Enberg wrote: > Hello, > > On Mon, Mar 11, 2013 at 3:20 PM, Andrew Hughes wrote: >> I wasn't aware we did. >> >> What version of libtool does F17 have? I build with 2.4.2 at present. > > Oh dear. I was missing gettext-devel package again! How can we add > some magic to "autogen.sh" to be more friendly to the user? I keep > hitting the same problem every time I try to build GNU Classpath on a > fresh installation... :-/ > Add a configure check for whatever the dependency is...
Re: Building GNU Classpath on Fedora 17
Hello, On Mon, Mar 11, 2013 at 3:20 PM, Andrew Hughes wrote: > I wasn't aware we did. > > What version of libtool does F17 have? I build with 2.4.2 at present. Oh dear. I was missing gettext-devel package again! How can we add some magic to "autogen.sh" to be more friendly to the user? I keep hitting the same problem every time I try to build GNU Classpath on a fresh installation... :-/ Pekka
Re: Building GNU Classpath on Fedora 17
- Original Message - > Hello, > > GNU Classpath build fails as follows with stock Fedora 17 libtools: > > [penberg@golgotha classpath]$ sh autogen.sh > configure.ac:505: warning: AC_LIB_PREPARE_PREFIX is m4_require'd but > not m4_defun'd > m4/iconv.m4:11: AM_ICONV_LINKFLAGS_BODY is expanded from... > m4/iconv.m4:22: AM_ICONV_LINK is expanded from... > m4/iconv.m4:77: AM_ICONV is expanded from... > configure.ac:505: the top level > configure.ac:505: warning: AC_LIB_RPATH is m4_require'd but not > m4_defun'd > m4/iconv.m4:11: AM_ICONV_LINKFLAGS_BODY is expanded from... > m4/iconv.m4:22: AM_ICONV_LINK is expanded from... > m4/iconv.m4:77: AM_ICONV is expanded from... > configure.ac:505: the top level > configure.ac:505: warning: AC_LIB_PREPARE_PREFIX is m4_require'd but > not m4_defun'd > m4/iconv.m4:11: AM_ICONV_LINKFLAGS_BODY is expanded from... > m4/iconv.m4:22: AM_ICONV_LINK is expanded from... > m4/iconv.m4:77: AM_ICONV is expanded from... > configure.ac:505: the top level > configure.ac:505: warning: AC_LIB_RPATH is m4_require'd but not > m4_defun'd > m4/iconv.m4:11: AM_ICONV_LINKFLAGS_BODY is expanded from... > m4/iconv.m4:22: AM_ICONV_LINK is expanded from... > m4/iconv.m4:77: AM_ICONV is expanded from... > configure.ac:505: the top level > libtoolize: putting auxiliary files in `.'. > libtoolize: copying file `./ltmain.sh' > libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'. > libtoolize: copying file `m4/libtool.m4' > libtoolize: copying file `m4/ltoptions.m4' > libtoolize: copying file `m4/ltsugar.m4' > libtoolize: copying file `m4/ltversion.m4' > libtoolize: copying file `m4/lt~obsolete.m4' > configure.ac:505: warning: AC_LIB_PREPARE_PREFIX is m4_require'd but > not m4_defun'd > m4/iconv.m4:11: AM_ICONV_LINKFLAGS_BODY is expanded from... > m4/iconv.m4:22: AM_ICONV_LINK is expanded from... > m4/iconv.m4:77: AM_ICONV is expanded from... > configure.ac:505: the top level > configure.ac:505: warning: AC_LIB_RPATH is m4_require'd but not > m4_defun'd > m4/iconv.m4:11: AM_ICONV_LINKFLAGS_BODY is expanded from... > m4/iconv.m4:22: AM_ICONV_LINK is expanded from... > m4/iconv.m4:77: AM_ICONV is expanded from... > configure.ac:505: the top level > configure.ac:505: warning: AC_LIB_PREPARE_PREFIX is m4_require'd but > not m4_defun'd > m4/iconv.m4:11: AM_ICONV_LINKFLAGS_BODY is expanded from... > m4/iconv.m4:22: AM_ICONV_LINK is expanded from... > m4/iconv.m4:77: AM_ICONV is expanded from... > configure.ac:505: the top level > configure.ac:505: warning: AC_LIB_RPATH is m4_require'd but not > m4_defun'd > m4/iconv.m4:11: AM_ICONV_LINKFLAGS_BODY is expanded from... > m4/iconv.m4:22: AM_ICONV_LINK is expanded from... > m4/iconv.m4:77: AM_ICONV is expanded from... > configure.ac:505: the top level > configure:18624: error: possibly undefined macro: > AC_LIB_PREPARE_PREFIX > If this token and others are legitimate, please use > m4_pattern_allow. > See the Autoconf documentation. > configure:18625: error: possibly undefined macro: AC_LIB_RPATH > configure:18630: error: possibly undefined macro: > AC_LIB_LINKFLAGS_BODY > configure:18638: error: possibly undefined macro: AC_LIB_APPENDTOVAR > autoreconf: /usr/bin/autoconf failed with exit status: 1 > > Is there any reason we depend on an older version of libtool? > > Pekka > > I wasn't aware we did. What version of libtool does F17 have? I build with 2.4.2 at present. -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
Re: Building GNU Classpath on Fedora 17
On Mon, Mar 11, 2013 at 09:51:28AM +0200, Pekka Enberg wrote: > GNU Classpath build fails as follows with stock Fedora 17 libtools: I don't see any issue doing the same on Fedora 18. I don't have an f17 setup to test against, sorry. Cheers, Mark
Building GNU Classpath on Fedora 17
Hello, GNU Classpath build fails as follows with stock Fedora 17 libtools: [penberg@golgotha classpath]$ sh autogen.sh configure.ac:505: warning: AC_LIB_PREPARE_PREFIX is m4_require'd but not m4_defun'd m4/iconv.m4:11: AM_ICONV_LINKFLAGS_BODY is expanded from... m4/iconv.m4:22: AM_ICONV_LINK is expanded from... m4/iconv.m4:77: AM_ICONV is expanded from... configure.ac:505: the top level configure.ac:505: warning: AC_LIB_RPATH is m4_require'd but not m4_defun'd m4/iconv.m4:11: AM_ICONV_LINKFLAGS_BODY is expanded from... m4/iconv.m4:22: AM_ICONV_LINK is expanded from... m4/iconv.m4:77: AM_ICONV is expanded from... configure.ac:505: the top level configure.ac:505: warning: AC_LIB_PREPARE_PREFIX is m4_require'd but not m4_defun'd m4/iconv.m4:11: AM_ICONV_LINKFLAGS_BODY is expanded from... m4/iconv.m4:22: AM_ICONV_LINK is expanded from... m4/iconv.m4:77: AM_ICONV is expanded from... configure.ac:505: the top level configure.ac:505: warning: AC_LIB_RPATH is m4_require'd but not m4_defun'd m4/iconv.m4:11: AM_ICONV_LINKFLAGS_BODY is expanded from... m4/iconv.m4:22: AM_ICONV_LINK is expanded from... m4/iconv.m4:77: AM_ICONV is expanded from... configure.ac:505: the top level libtoolize: putting auxiliary files in `.'. libtoolize: copying file `./ltmain.sh' libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'. libtoolize: copying file `m4/libtool.m4' libtoolize: copying file `m4/ltoptions.m4' libtoolize: copying file `m4/ltsugar.m4' libtoolize: copying file `m4/ltversion.m4' libtoolize: copying file `m4/lt~obsolete.m4' configure.ac:505: warning: AC_LIB_PREPARE_PREFIX is m4_require'd but not m4_defun'd m4/iconv.m4:11: AM_ICONV_LINKFLAGS_BODY is expanded from... m4/iconv.m4:22: AM_ICONV_LINK is expanded from... m4/iconv.m4:77: AM_ICONV is expanded from... configure.ac:505: the top level configure.ac:505: warning: AC_LIB_RPATH is m4_require'd but not m4_defun'd m4/iconv.m4:11: AM_ICONV_LINKFLAGS_BODY is expanded from... m4/iconv.m4:22: AM_ICONV_LINK is expanded from... m4/iconv.m4:77: AM_ICONV is expanded from... configure.ac:505: the top level configure.ac:505: warning: AC_LIB_PREPARE_PREFIX is m4_require'd but not m4_defun'd m4/iconv.m4:11: AM_ICONV_LINKFLAGS_BODY is expanded from... m4/iconv.m4:22: AM_ICONV_LINK is expanded from... m4/iconv.m4:77: AM_ICONV is expanded from... configure.ac:505: the top level configure.ac:505: warning: AC_LIB_RPATH is m4_require'd but not m4_defun'd m4/iconv.m4:11: AM_ICONV_LINKFLAGS_BODY is expanded from... m4/iconv.m4:22: AM_ICONV_LINK is expanded from... m4/iconv.m4:77: AM_ICONV is expanded from... configure.ac:505: the top level configure:18624: error: possibly undefined macro: AC_LIB_PREPARE_PREFIX If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. configure:18625: error: possibly undefined macro: AC_LIB_RPATH configure:18630: error: possibly undefined macro: AC_LIB_LINKFLAGS_BODY configure:18638: error: possibly undefined macro: AC_LIB_APPENDTOVAR autoreconf: /usr/bin/autoconf failed with exit status: 1 Is there any reason we depend on an older version of libtool? Pekka
