Bug#1136716: Guile Fluidsynth uploaded to Salsa

2026-05-18 Thread Tommi Höynälänmaa 



Simon Josefsson kirjoitti 18.5.2026 klo 15.44:

Tommi Höynälänmaa  writes:


Hello

Shall I use my own GPG key as the signing key?

Yes -- although nothing checks upstream/x.y.z git signatures today, but
I still find it nice to GPG sign things when possible.  If it is not
convenient for you, then merely disregard this.  But sometimes there is
no real cost involved, beyond setting gbp sign-tags variable, if you
normally have a GPG setup working.

/Simon


I'll use my own key.

     - Tommi

--
Kotisivu / Homepage: http://www.iki.fi/tohoyn/
Sähköposti / E-Mail: [email protected]
GPG-sormenjälki / GPG fingerprint:
55F4 2477 7155 3528 5CB2 2B7A BB86 1FDE 4046 0F83
FT, Debian-ylläpitäjä / PhD, Debian Maintainer

Bug#1136716: Guile Fluidsynth uploaded to Salsa

2026-05-18 Thread Simon Josefsson 
Tommi Höynälänmaa  writes:

> Hello
>
> Shall I use my own GPG key as the signing key?

Yes -- although nothing checks upstream/x.y.z git signatures today, but
I still find it nice to GPG sign things when possible.  If it is not
convenient for you, then merely disregard this.  But sometimes there is
no real cost involved, beyond setting gbp sign-tags variable, if you
normally have a GPG setup working.

/Simon

>      - Tommi
>
> Simon Josefsson kirjoitti 18.5.2026 klo 10.32:
>> Tommi Höynälänmaa  writes:
>>
>>> Hello
>>>
>>> I have uploaded Guile Fluidsynth to Salsa. I have to wait for nyacc to
>>> be updated in Debian unstable before I can upload Guile Fluidsynth to
>>> Debian unstable. See
>>> .
>> Welcome to the team!
>>
>> Quick review:
>>
>> - Add d/upstream/metadata
>>
>> - Send d/patches/ upstream, and mark them as Forwarded.
>>
>> - Fix licenserecon warnings about d/copyright -- there are many
>>copyright notices in the sources not present in d/copyright.
>>
>> - Is it possible to write some non-superficial debian/tests/?  Based on
>>the manual maybe?  Upstream really ought to have a test-suite as part
>>of 'make check', so maybe ask upstream.
>>
>> - Use d/watch v5 - upstream signs git tags, so I suggest adding a
>>d/upstream/signing-key.asc and using a debian/watch like this:
>>
>> Version: 5
>> Source: https://https.git.savannah.gnu.org/git/guile-fluidsynth.git
>> Matching-Pattern: refs/tags/v@ANY_VERSION@
>> Mode: git
>> Pgpmode: gittag
>>
>> - Update Standards-Version, dropping Priority and Rules-Requires-Root.
>>
>> - I see no need for a versioned dependency on texinfo in d/control.
>>
>> - What is the purpose of this in debian/rules?
>> export DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)
>>
>> - Consider adding sign-tags=True and upstream-vcs-tag = v%(version%~%-)s
>>to debian/gbp.conf.
>>
>> /Simon


signature.asc
Description: PGP signature

Bug#1136716: Guile Fluidsynth uploaded to Salsa

2026-05-18 Thread Tommi Höynälänmaa 

Hello

Shall I use my own GPG key as the signing key?

     - Tommi

Simon Josefsson kirjoitti 18.5.2026 klo 10.32:

Tommi Höynälänmaa  writes:


Hello

I have uploaded Guile Fluidsynth to Salsa. I have to wait for nyacc to
be updated in Debian unstable before I can upload Guile Fluidsynth to
Debian unstable. See
.

Welcome to the team!

Quick review:

- Add d/upstream/metadata

- Send d/patches/ upstream, and mark them as Forwarded.

- Fix licenserecon warnings about d/copyright -- there are many
   copyright notices in the sources not present in d/copyright.

- Is it possible to write some non-superficial debian/tests/?  Based on
   the manual maybe?  Upstream really ought to have a test-suite as part
   of 'make check', so maybe ask upstream.

- Use d/watch v5 - upstream signs git tags, so I suggest adding a
   d/upstream/signing-key.asc and using a debian/watch like this:

Version: 5
Source: https://https.git.savannah.gnu.org/git/guile-fluidsynth.git
Matching-Pattern: refs/tags/v@ANY_VERSION@
Mode: git
Pgpmode: gittag

- Update Standards-Version, dropping Priority and Rules-Requires-Root.

- I see no need for a versioned dependency on texinfo in d/control.

- What is the purpose of this in debian/rules?
export DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)

- Consider adding sign-tags=True and upstream-vcs-tag = v%(version%~%-)s
   to debian/gbp.conf.

/Simon


--
Kotisivu / Homepage: http://www.iki.fi/tohoyn/
Sähköposti / E-Mail: [email protected]
GPG-sormenjälki / GPG fingerprint:
55F4 2477 7155 3528 5CB2 2B7A BB86 1FDE 4046 0F83
FT, Debian-ylläpitäjä / PhD, Debian Maintainer

Bug#1136716: Guile Fluidsynth uploaded to Salsa

2026-05-18 Thread Simon Josefsson 
Tommi Höynälänmaa  writes:

> Hello
>
> I have uploaded Guile Fluidsynth to Salsa. I have to wait for nyacc to
> be updated in Debian unstable before I can upload Guile Fluidsynth to
> Debian unstable. See
> .

Welcome to the team!

Quick review:

- Add d/upstream/metadata

- Send d/patches/ upstream, and mark them as Forwarded.

- Fix licenserecon warnings about d/copyright -- there are many
  copyright notices in the sources not present in d/copyright.

- Is it possible to write some non-superficial debian/tests/?  Based on
  the manual maybe?  Upstream really ought to have a test-suite as part
  of 'make check', so maybe ask upstream.

- Use d/watch v5 - upstream signs git tags, so I suggest adding a
  d/upstream/signing-key.asc and using a debian/watch like this:

Version: 5
Source: https://https.git.savannah.gnu.org/git/guile-fluidsynth.git
Matching-Pattern: refs/tags/v@ANY_VERSION@
Mode: git
Pgpmode: gittag

- Update Standards-Version, dropping Priority and Rules-Requires-Root.

- I see no need for a versioned dependency on texinfo in d/control.

- What is the purpose of this in debian/rules?
export DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)

- Consider adding sign-tags=True and upstream-vcs-tag = v%(version%~%-)s
  to debian/gbp.conf.

/Simon


signature.asc
Description: PGP signature

Bug#1136716: Guile Fluidsynth uploaded to Salsa

2026-05-17 Thread Tommi Höynälänmaa 

Hello

I have uploaded Guile Fluidsynth to Salsa. I have to wait for nyacc to 
be updated in Debian unstable before I can upload Guile Fluidsynth to 
Debian unstable. See 
.


     - Tommi

--
Kotisivu / Homepage: http://www.iki.fi/tohoyn/
Sähköposti / E-Mail: [email protected]
GPG-sormenjälki / GPG fingerprint:
55F4 2477 7155 3528 5CB2 2B7A BB86 1FDE 4046 0F83
FT, Debian-ylläpitäjä / PhD, Debian Maintainer