Re: cvs commit: modperl-2.0/ModPerl-Registry/t basic.t

2003-03-08 Thread Stas Bekman
Randy Kobes wrote: On 9 Mar 2003 [EMAIL PROTECTED] wrote: +use Apache::TestConfig (); I didn't put that in before, as I realized later Apache::TestConfig is used by Apache::Test, which was already use()d. Sorry about that, Randy. I thought you have just committed an older patch. Would it be g

Re: cvs commit: modperl-2.0/ModPerl-Registry/t basic.t

2003-03-08 Thread Randy Kobes
On 9 Mar 2003 [EMAIL PROTECTED] wrote: > stas2003/03/08 16:16:26 > > Modified:ModPerl-Registry/t basic.t > Log: > add the missing use Apache::TestConfig > > Revision ChangesPath > 1.13 +1 -0 modperl-2.0/ModPerl-Registry/t/basic.t > > Index: basic.t >

Re: do we need send_http_header in mp2? (was Re: cvs commit: modperl-2.0Changes)

2003-03-08 Thread Stas Bekman
Nick Tonkin wrote: On Sat, 8 Mar 2003, Stas Bekman wrote: [EMAIL PROTECTED] wrote: stas2003/03/08 01:15:16 Modified:lib/Apache compat.pm lib/ModPerl Code.pm src/modules/perl mod_perl.c modperl_filter.c xs/Apache/RequestRec Apache__RequestRe

Re: [mp2] ModPerl-Registry tests

2003-03-08 Thread Randy Kobes
On Sat, 8 Mar 2003, Stas Bekman wrote: > Randy Kobes wrote: [ .. ] > > There's also something with the closure.t test - in running > > 'nmake test', test 4 of closure.t fails, but running closure.t > > individually allows all tests to pass. > > You mean closure.t:4 fails only when some other test

Re: do we need send_http_header in mp2? (was Re: cvs commit:modperl-2.0 Changes)

2003-03-08 Thread Nick Tonkin
On Sat, 8 Mar 2003, Stas Bekman wrote: > [EMAIL PROTECTED] wrote: > > stas2003/03/08 01:15:16 > > > > Modified:lib/Apache compat.pm > >lib/ModPerl Code.pm > >src/modules/perl mod_perl.c modperl_filter.c > >xs/Apache/RequestRec Apache__R

Re: [mp2] $r->args

2003-03-08 Thread Stas Bekman
Kurt George Gjerde wrote: On Sat, 8 Mar 2003, Stas Bekman wrote: test.pl: my $r = shift; $r->content_type('text/plain'); $r->print($r->args); why? because what registry does is wrapping the code into a function handler, passing $r as an argument. However it's also in the scope of the cod

Re: [mp2] $r->args

2003-03-08 Thread Kurt George Gjerde
On Sat, 8 Mar 2003, Stas Bekman wrote: > test.pl: > > my $r = shift; > $r->content_type('text/plain'); > $r->print($r->args); > > why? because what registry does is wrapping the code into a function handler, > passing $r as an argument. However it's also in the scope of the code that > ca

do we need send_http_header in mp2? (was Re: cvs commit: modperl-2.0Changes)

2003-03-08 Thread Stas Bekman
[EMAIL PROTECTED] wrote: stas2003/03/08 01:15:16 Modified:lib/Apache compat.pm lib/ModPerl Code.pm src/modules/perl mod_perl.c modperl_filter.c xs/Apache/RequestRec Apache__RequestRec.h .Changes Log: When PerlOpt

Re: [mp2] ModPerl-Registry tests

2003-03-08 Thread Stas Bekman
Randy Kobes wrote: On Sat, 8 Mar 2003, Randy Kobes wrote: On Win32, there's a couple of minor things with the ModPerl-Registry tests. [ ... ] - in the ModPerl-Registry/t/basic.t test, some tests are made which rely on the setting of the executable bit, which isn't available on Win32. The follo

Re: [mp2] ModPerl-Registry tests

2003-03-08 Thread Stas Bekman
Randy Kobes wrote: On Win32, there's a couple of minor things with the ModPerl-Registry tests. - in ModPerl-Registry/t/TEST.PL, Win32 likes to have the volume letter in a different place, as in the following diff: Index: ModPerl-Registry/t/TEST.PL ===

Re: [mp2] ModPerl-Registry tests

2003-03-08 Thread Randy Kobes
On Sat, 8 Mar 2003, Randy Kobes wrote: > On Win32, there's a couple of minor things with the > ModPerl-Registry tests. [ ... ] > - in the ModPerl-Registry/t/basic.t test, some tests are > made which rely on the setting of the executable bit, which > isn't available on Win32. The following diff:

[mp2] ModPerl-Registry tests

2003-03-08 Thread Randy Kobes
On Win32, there's a couple of minor things with the ModPerl-Registry tests. - in ModPerl-Registry/t/TEST.PL, Win32 likes to have the volume letter in a different place, as in the following diff: Index: ModPerl-Registry/t/TEST.PL ==