Re: [struts-dev] Code review

2014-02-18 16:24 GMT+01:00 Jason Pyeron : > Is the intention to have replies to the github messages on this list be added > to > the pull request comments? Yes, both ways. - To unsubscribe, e-mail: [email protected].

RE: [struts-dev] Code review

> -Original Message- > From: Lukasz Lenart > Sent: Tuesday, February 18, 2014 9:10 > > Hi, > > I have created PR via GitHub so everybody can simple review > the changes. It's far easier to use GH for that than use > Review Board or Fisheye. For now I

Code review

Hi, I have created PR via GitHub so everybody can simple review the changes. It's far easier to use GH for that than use Review Board or Fisheye. For now I think it is preferred way if you want to get others' opinion about your changes. https://github.com/apache/struts/pull/1

Re: IMPORTANT: Major Confluence Upgrade Coming Soon. Please review test instance now.

2013/6/28 Rene Gielen : > Will hopefully being able to check tomorrow I resolved that - wrong path in docs.cfg file ;-) Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ - To unsubscribe, e-mail: dev-unsubscr...@str

Re: IMPORTANT: Major Confluence Upgrade Coming Soon. Please review test instance now.

Will hopefully being able to check tomorrow Am 27.06.13 22:11, schrieb Lukasz Lenart: > Can you take a look on that [1]? I don't know how to setup > SiteExporter to get it running :\ > > [1] https://issues.apache.org/jira/browse/WW-4130 > > > Regards > -- René Gielen http://twitter.com/rgie

Re: IMPORTANT: Major Confluence Upgrade Coming Soon. Please review test instance now.

Can you take a look on that [1]? I don't know how to setup SiteExporter to get it running :\ [1] https://issues.apache.org/jira/browse/WW-4130 Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ - To unsubscribe, e-ma

Re: IMPORTANT: Major Confluence Upgrade Coming Soon. Please review test instance now.

2013/6/25 Lukasz Lenart : > 2013/6/21 Lukasz Lenart : >>> this is a bummer! >>> OK, we're officially having a problem now I guess. >> >> Yeah... we must switch to [1] >> >> [1] >> https://issues.apache.org/jira/browse/INFRA-6406?focusedCommentId=13690207&page=com.atlassian.jira.plugin.system.issue

Re: IMPORTANT: Major Confluence Upgrade Coming Soon. Please review test instance now.

2013/6/21 Lukasz Lenart : >> this is a bummer! >> OK, we're officially having a problem now I guess. > > Yeah... we must switch to [1] > > [1] > https://issues.apache.org/jira/browse/INFRA-6406?focusedCommentId=13690207&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-

Re: IMPORTANT: Major Confluence Upgrade Coming Soon. Please review test instance now.

2013/6/19 Rene Gielen : >>> It looks like we are not exactly in a hurry (we aren't using autoexport >>> but wget, right?) - but looking into alternatives which might fix better >>> in the build and release cycle seems to become more and more important. >> >> autoexport exports each page into cwiki.

Re: IMPORTANT: Major Confluence Upgrade Coming Soon. Please review test instance now.

Am 19.06.13 10:02, schrieb Lukasz Lenart: > 2013/6/19 Rene Gielen : >> CSS for warning / tips / infos is terrible. Editing seems to be more >> painful, though there is some change for adaption. > > Gavin re-ran the export and now editing pages is ok. I tested today, so I guess this was the *ok* e

Re: IMPORTANT: Major Confluence Upgrade Coming Soon. Please review test instance now.

2013/6/19 Rene Gielen : > CSS for warning / tips / infos is terrible. Editing seems to be more > painful, though there is some change for adaption. Gavin re-ran the export and now editing pages is ok. > It looks like we are not exactly in a hurry (we aren't using autoexport > but wget, right?) -

Re: IMPORTANT: Major Confluence Upgrade Coming Soon. Please review test instance now.

Am 18.06.13 15:41, schrieb Lukasz Lenart: > Hi, > > I have edited one page [1] but after migration it will pain-in-the-ass > to change anything :\ Maybe it's time to migrate to Markdown format? > > [1] https://cwiki2.apache.org/confluence/display/WW/Version+Notes+2.3.15 > > > Regards > CSS fo

Re: IMPORTANT: Major Confluence Upgrade Coming Soon. Please review test instance now.

/6/18 Lukasz Lenart : > FYI > > -- Forwarded message -- > From: gmcdonald > Date: 2013/6/18 > Subject: IMPORTANT: Major Confluence Upgrade Coming Soon. Please > review test instance now. > To: [email protected], [email protected] > > >

Fwd: IMPORTANT: Major Confluence Upgrade Coming Soon. Please review test instance now.

FYI -- Forwarded message -- From: gmcdonald Date: 2013/6/18 Subject: IMPORTANT: Major Confluence Upgrade Coming Soon. Please review test instance now. To: [email protected], [email protected] [PMCs please forward to your dev list ; Incubator Mentors please forward to

Struts Master ready for review

Hi, Please review the new Struts Master, is available here [1], I've upgraded to latest Apache Parent POM. If no show-stoppers will be reported I'm going to call Vote on it. Waiting 24*7 = week ;-) [1] https://repository.apache.org/content/groups/staging/org/apache/struts/strut

Re: Review Request: WW-3659 - strange behaviour with tag in the body

2011/7/5 Wesley Wannemacher > > Lukasz, I'm not sure what makes this change backwards incompatible... I > would say "ship it" but I'm more curious about why moving this to the closing > template would make a difference. One thing that I noticed about the original > issue is that the poster is

Re: Review Request: WW-3659 - strange behaviour with tag in the body

Done On 5 July 2011 17:09, Wes Wannemacher wrote: > On Tue, Jul 5, 2011 at 11:05 AM, Maurizio Cucchiara > wrote: > [snip] > > Furthermore I would downgrade the issue's priority to minor (IMHO is a > rare > > case). > > WDYT? > > > Agreed! > > -Wes > > -- > Wes Wannemacher > > Head Engineer, Wan

Re: Review Request: WW-3659 - strange behaviour with tag in the body

On Tue, Jul 5, 2011 at 11:05 AM, Maurizio Cucchiara wrote: [snip] > Furthermore I would downgrade the issue's priority to minor (IMHO is a rare > case). > WDYT? Agreed! -Wes -- Wes Wannemacher Head Engineer, WanTii, Inc. Need Training? Struts, Spring, Maven, Tomcat... Ask me for a quote! --

Re: Review Request: WW-3659 - strange behaviour with tag in the body

rendered differently than the closing template. > > - Wesley > > > On 2011-07-05 14:01:47, Lukasz Lenart wrote: > > > > --- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/1003/ > > -

Re: Review Request: WW-3659 - strange behaviour with tag in the body

reply, visit: > https://reviews.apache.org/r/1003/ > --- > > (Updated 2011-07-05 14:01:47) > > > Review request for Struts2. > > > Summary > --- > > This change will solve https://issues.apache.org/jira/browse/W

Re: Review Request: WW-3659 - strange behaviour with tag in the body

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1003/ --- (Updated 2011-07-05 14:01:47.633497) Review request for Struts2. Summary

Re: Review Request: To solve WW-3659

https://reviews.apache.org/r/1003/ > Review request for Struts2. > By Lukasz Lenart. > Description > > This change will solve https://issues.apache.org/jira/browse/WW-3659 but can > be backward incompatibile > > Diffs > >- ./core/src/main/resources/template/simple/a-close.

Review Request: To solve WW-3659

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1003/ --- Review request for Struts2. Summary --- This change will solve https

Review

Hi, I've updated "Creating and Signing a Struts 2.2.x Distribution" [1] could someone review it? Thanks in advance! [1] https://cwiki.apache.org/confluence/display/WW/Creating+and+Signing+a+Struts+2.2.x+Distribution Kind regards -- Łukasz + 48 606 323 122 http://www.lenart.o

Re: Initial Struts 2 Tutorials Completed - Please Review

based simple project) and they are very well-written... Keep up > the good work! > > > -- View this message in context: http://old.nabble.com/Initial-Struts-2-Tutorials-Completed---Please-Review-tp27386684p27647161.html Sent from the Struts - D

Re: Initial Struts 2 Tutorials Completed - Please Review

ocDraft/Tutorials > http://cwiki.apache.org/confluence/display/S2NewDocDraft/Tutorials . > > Please review and provide feedback. > > I hope we can soon move these tutorials to the main Struts 2 documentation > web site and also include them in the Struts 2 download.  The easier we make

Initial Struts 2 Tutorials Completed - Please Review

I've completed the initial set of new tutorials for Struts 2. See: http://cwiki.apache.org/confluence/display/S2NewDocDraft/Tutorials http://cwiki.apache.org/confluence/display/S2NewDocDraft/Tutorials . Please review and provide feedback. I hope we can soon move these tutorials to the

for review - split content type handler manager in REST plugin

Could someone with an interest in the REST plugin please glance at the changes I've committed for WW-2641? The change allows a different content-type in the request than the response. This was added specifically to allow a x-www-form-urlencoded request with a response in a different content-t

Re: struts/xwork patch submission. Please Review.

t; I suggest that the following three lines be removed from > >> DefaultActionInvocation.java, line 174: > >> > >> if (result != null) { > >> return result; > >> } > >> > >> I've tested this and I get the desired b

Re: struts/xwork patch submission. Please Review.

build reports no additional >> automated test failures. I got four test failures trying to build the >> standard xwork 2.0.4 distribution before making any changes, however my >> code change didn't affect these results. >> >> >> Version Info >> Java 1.6.0_02 >> Struts 2.0.9 >> xwork 2.0.4 >> > > -- View this message in context: http://www.nabble.com/struts-xwork-patch-submission.-Please-Review.-tf4558415.html#a13020278 Sent from the Struts - Dev mailing list archive at Nabble.com. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: struts/xwork patch submission. Please Review.

standard xwork 2.0.4 distribution before making any changes, however my > code change didn't affect these results. > > > Version Info > Java 1.6.0_02 > Struts 2.0.9 > xwork 2.0.4 > -- View this message in context: http://www.nabble.com/struts-xwork-patch-submission.-Pl

Re: struts/xwork patch submission. Please Review.

or the original exception. The xwork build reports no additional > automated test failures. I got four test failures trying to build the > standard xwork 2.0.4 distribution before making any changes, however my code > change didn't affect these results. > > > Version Info > J

struts/xwork patch submission. Please Review.

essage in context: http://www.nabble.com/struts-xwork-patch-submission.-Please-Review.-tf4558415.html#a13008842 Sent from the Struts - Dev mailing list archive at Nabble.com. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

[jira] Created: (STR-2852) Move the non-working integration tests to the sandbox for review.

Move the non-working integration tests to the sandbox for review. - Key: STR-2852 URL: http://issues.apache.org/struts/browse/STR-2852 Project: Struts Action 1 Type: Improvement Versions: Nightly

DO NOT REPLY [Bug 33202] - DispatchChainAction needs review

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 33202] - DispatchChainAction needs review

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: Validator 1.2.0 RC3 now available for review

I just posted a vote on Validator 1.2.0 on the Commons Dev list: http://www.mail-archive.com/commons-dev%40jakarta.apache.org/msg69561.html Hopefully, it will pass and become an official release. Niall - Original Message - From: "Laurie Harper" <[EMAIL PROTECTED]> Sent: Sunday, Novembe

Re: Validator 1.2.0 RC3 now available for review

Wendy Smoak wrote: [moved from user list] On 11/2/05, Niall Pemberton <[EMAIL PROTECTED]> wrote: Release Candidate 3 of Validator 1.2.0 is now available for download at: http://people.apache.org/~niallp/commons-validator/1.2.0-rc3/ ... All feedback on this release candidate build is wel

Re: Validator 1.2.0 RC3 now available for review

[moved from user list] On 11/2/05, Niall Pemberton <[EMAIL PROTECTED]> wrote: > Release Candidate 3 of Validator 1.2.0 is now available for download at: > http://people.apache.org/~niallp/commons-validator/1.2.0-rc3/ ... > All feedback on this release candidate build is welcome. I put that ja

DO NOT REPLY [Bug 33202] - DispatchChainAction needs review

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 33202] New: - DispatchChainAction needs review

gzilla/show_bug.cgi?id=33202 Summary: DispatchChainAction needs review Product: Struts Version: Unknown Platform: Macintosh OS/Version: Mac OS X 10.0 Status: NEW Severity: enhancement Priority: P3 Component: Cont