how this could be implemented with Maven and if
it's possible to tweak the template in the parent pom. If anyone knows
how it works, please speak up! If it works well we could even share it
at the ASF level.
Emmanuel Bourg
[1] http://docs.oracle.com/javase/7/docs/api
[2] http://userscripts.org
is the doclet change between Java 7 and the
previous versions (Java 7 uses more CSS and the HTML markup is
significantly different). So the Javadoc plugin will have to pick the
right stylesheet for the JDK used. I don't know if this is possible with
Maven.
Emmanuel Bourg
-configuration.html
Is it possible to select different settings for a Maven plugin depending
on the JDK used? We could leave the Javadoc as is when the JDK = 6 is
used, and for JDK = 7 fix the alignment and indentation issues.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
the added cell borders are
probably debatable.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
Well, the class is effectively immutable, even if the fields are not
final. I think that's an important feature to document.
Emmanuel Bourg
Le 09/03/2012 19:15, s...@apache.org a écrit :
Author: sebb
Date: Fri Mar 9 18:15:02 2012
New Revision: 1298953
URL: http://svn.apache.org/viewvc?rev
The vote to promote Commons CSV to Commons proper has passed with 13 +1:
Christian Grobmeier +1
Damjan Jovanovic+1
Dennis Lundberg +1
Emmanuel Bourg +1
Gary Gregory+1
James Carman+1
Jörg Schaible +1
Luc Maisonobe +1
Niall Pemberton +1
Sebastian Bazley
Le 09/03/2012 23:06, Emmanuel Bourg a écrit :
The project has been created in JIRA, I'll try to move the issues
without spamming the list this time.
Issues have been moved. I'm now officially mastering the bulk edit
function of JIRA :) There is some work left to assign the issues
Gary, Sebastian, thank you for the help!
Do you know how we get the old site location to redirect to the new one?
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
to use
them.
I haven't analyzed why Commons CSV is slower yet, but it seems there is
room for improvements. The memory usage will have to be compared too,
I'm looking for a way to measure it.
Emmanuel Bourg
[1] http://www.maxmind.com/download/worldcities/worldcitiespop.txt.gz
smime.p7s
a profiler to try
and identify the performance critical parts that could be improved.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
;
}
}
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
, thank you. I'll review that.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
the serialization works fine. I think the
no-arg constructor is only required if the class is expected to be
subclassed, which isn't the case for CSVFormat. The UID is generated
automatically by the compiler.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
improved by 30%.
Now the parsing is down to 3406 ms, and that's almost without touching
the parser yet.
Emmanuel Bourg
Le 11/03/2012 15:05, Emmanuel Bourg a écrit :
Hi,
I compared the performance of Commons CSV with the other CSV parsers
available. I took the world cities file from Maxmind
Le 12/03/2012 16:44, sebb a écrit :
Java has a PushbackReader class - could that not be used?
I considered it, but it doesn't mix well with line reading. The
mark/reset solution is really simple and efficient.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
to the parser will have to be carefully tested. Innocent
changes can have a significant impact.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
Le 12/03/2012 17:28, James Carman a écrit :
Would one of the parser libraries not work here?
You think at something like JavaCC or AntLR? Not sure it'll be more
efficient than a handcrafted parser. The CSV format is simple enough to
do it manually.
Emmanuel Bourg
smime.p7s
Description
a positive impact on the
performance of parsing files with an encoding whose line separator is
only one char long.
CSVFormat defines a line separator, but it's only used by CSVPrinter.
I'm not sure if we should restrict to this separator when parsing.
Emmanuel Bourg
smime.p7s
Description: S/MIME
the parser should look for any line separator and not only the
one defined in the format. Otherwise the user will have to know in
advance the line separator of the input files, and that's not always
possible.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
Le 12/03/2012 18:52, sebb a écrit :
The only possible ambiguity is whether the file uses CR, LF, or CRLF.
Yes that's what I mean by knowing in advance.
The line separator is not obvious when you open the file in an editor.
That's not the case for the delimiter.
Emmanuel Bourg
smime.p7s
Le 12/03/2012 18:51, Benedikt Ritter a écrit :
you wrote about the printer ;)
Yes, because the line separator of CSVFormat is only used there.
Usually you have to be permissive in what your read, but strict on what
your write.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic
();
person.setName(record[parser.getColumnIndex(name)]);
person.setEmail(record[parser.getColumnIndex(email)]);
person.setPhone(record[parser.getColumnIndex(phone)]);
persons.add(person);
}
What do you think?
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
Harmony. On my test it
is about 4% faster than the JDK counterpart, and the parsing time is now
around 2553 ms.
Now Commons CSV can start claiming being the fastest CSV parser around :)
Emmanuel Bourg
Le 12/03/2012 11:31, Emmanuel Bourg a écrit :
I have identified the performance killer, it's
agree such a class should not live in [csv], but maybe in [io]?
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
).
If the file has a header, the fields are matched by attribute name, and
an annotation can override the name of the column associated to an
attribute.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
with the annotations.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
Le 13/03/2012 01:44, sebb a écrit :
I don't think we should be trying to recode JDK classes.
I'd rather not, but we have done that in the past. FastDateFormat and
StrBuilder come to mind.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
Le 13/03/2012 09:56, sebb a écrit :
It needs to be possible to access columns by index without having to
use annotations.
That's still possible with the low level API. I'm just exploring the
features I would expect of a bean mapping.
Emmanuel Bourg
smime.p7s
Description: S/MIME
!
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
- Changes (I prefer the changes plugin, it's much more explicit than a
list of issues in JIRA)
The reports only visible when voting on a release candidate:
- Cobertura
- Surefire
- RAT
- Findbugs
- Checkstyle
The useless ones:
- JDepend
Emmanuel Bourg
Le 13/03/2012 12:48, sebb a écrit :
Commons
, the site will expose information that is not
applicable to the latest release, but to the next one.
What I'd like to see is a more user oriented site, something clear and
simple, and a developer oriented site with all the reports you want,
automatically updated everyday.
Emmanuel Bourg
of the synchronized blocks in BufferedReader has no visible
effect (maybe less than 1%), and the Harmony implementation becomes slower.
Emmanuel Bourg
Le 13/03/2012 10:20, Emmanuel Bourg a écrit :
Le 13/03/2012 02:47, Niall Pemberton a écrit :
IMO performance should be taken out of the equation by using
Le 14/03/2012 13:45, sebb a écrit :
What if the sequence is not exactly 5 characters long?
Nothing because it never happens :)
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
Le 14/03/2012 18:11, sebb a écrit :
Sometimes single char names are clearer.
E.g. in for loops, using i and j is such a common idiom that renaming
won't necessarily improve readability.
Same thing for x and y as coordinates.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic
state. Something
like this would break (a bit far fetched, I agree):
CSVFormat.DEFAULT.withDelimiter('#').withCommentStart('/');
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
don't think this is an issue, the format will be validated one line
later when it's used for parsing or printing.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
can be sure that
everything will be validated.
That's too verbose, please let's keep this simple API.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
probably reject delimiter == DISABLED.
Ok
Also, the DISABLED constant needs to be public (or available via a
public getter) otherwise it's not possible to disable all but the
delimiter.
I'd better use a null value to disable a feature than exposing the
DISABLED constant.
Emmanuel Bourg
this constant. The idea was that we
start with disabled features by default in the predefined formats, and
then we enable what's necessary. Thus we never have to disable anything.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
it was, but MySQL actually produces files with quotes and escaped
characters (delimiter and line feeds). I'm reviewing other RDBMS to see
what formats we can expect in the wild.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
) will tell us if the character exists. U+FFFE
doesn't:
http://www.fileformat.info/info/unicode/char/fffe
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
(record.get(phone));
persons.add(person);
}
The record is not a Map to keep it simple, it only exposes 3 methods:
get(int), get(String) and size()
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
of values if you want to iterate over it.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
which is a 4% improvement.
I suspect this is partly because the fetches are currently in loops
rather than any getter overhead.
Did you run with the client or the server VM? My tests were all with the
server VM.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
Le 15/03/2012 14:13, sebb a écrit :
Eclipse, so probably client VM?
Probably. You can print the java.vm.name system property at the
beginning of the test, that will tell you the VM used.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
Aaargh not now, it conflicts with my pending changes :(
Le 15/03/2012 14:44, ggreg...@apache.org a écrit :
Author: ggregory
Date: Thu Mar 15 13:44:44 2012
New Revision: 1300977
URL: http://svn.apache.org/viewvc?rev=1300977view=rev
Log:
Update to JUnit 4.10 from 3.8.1.
Modified:
Le 15/03/2012 14:59, Gary Gregory a écrit :
Zut alors! How was I to know :(
By asking the list first I guess :)
Could you just add the static import please? This will reduce the conflicts.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
check JUnit in Action and see what's the preferred form ;)
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
pay the cost to convert it into a String. But this prevents the
reuse of the buffer, and that means more work for the GC.
Emmanuel Bourg
Le 15/03/2012 15:49, Ted Dunning a écrit :
I built a limited CSV package for parsing data in Mahout at one point. I
doubt that it was general enough
in simpleTokenLexer and the performance degrades by 14%
(HotSpot server VM, JDK 6u31, Core 2 Duo).
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
Le 15/03/2012 17:42, sebb a écrit :
I also used local vars in the other methods.
See http://people.apache.org/~sebb/CSV/
Thank you. You also reordered the if in simpleTokenLexer, that may
explain the difference. I'll give it a try.
Emmanuel Bourg
smime.p7s
Description: S/MIME
Le 15/03/2012 18:06, sebb a écrit :
If I revert it, I still get a better time with Lexer2, though not
quite as good an improvement.
I ran my perf test, Lexer2 is slower on my system :( The order of the if
doesn't change much here.
Emmanuel Bourg
smime.p7s
Description: S/MIME
time and want to do something fun you can try
reimplementing the parser with less array copies. Commons CSV is still
behind the other APIs on the performance side.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
to use CSVFormat there. Then we would have to
make validate public, exposing it to the outside world.
Well, why not if that's necessary at this time.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
in BufferedReader uses
them. But if you find a faster alternative, go for it!
Emmanuel Bourg
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
IntelliJ IDEA complains about explicit boxing. Why do you change it?
Emmanuel Bourg
Le 17/03/2012 05:12, s...@apache.org a écrit :
Author: sebb
Date: Sat Mar 17 04:12:16 2012
New Revision: 1301861
URL: http://svn.apache.org/viewvc?rev=1301861view=rev
Log:
@Override; explicit unboxing
magic syntax when it's ambiguous, but a trivial unboxing
to access an array element is really harmless. That's the perfect
example why this syntax was introduced in Java 5: to improve the
readability.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
algorithms that happen to use a graph.
Emmanuel Bourg
Le 28/03/2012 18:57, Simone Tripodi a écrit :
Hi all guys,
we have an ELO implementation now which I would really like some of us
could review and provide feedbacks/contributions/...
The concept is that *directed* Graphs represents
I would advise at least placing the domain specific algorithms in a
separate artifact and keep the base API in a main artifact. Also a
smaller API will be easier to release quickly.
Emmanuel Bourg
Le 28/03/2012 23:04, Simone Tripodi a écrit :
Salut Manu,
The ELO ranking algorithm - like
I'm not sure to understand why this test is changed. If we drop trailing
comments it seems important to test they aren't not handled. A dash in a
field should not be mistaken with a comment.
Emmanuel Bourg
Le 28/03/2012 15:34, s...@apache.org a écrit :
Author: sebb
Date: Wed Mar 28 13:34:21
.
Emmanuel Bourg
Le 04/04/2012 22:00, Stefan Bodewig a écrit :
Hi all,
as indicated last weekend Compress' trunk has accumulated so much new
goodness it requires a new release.
Tarballs of Compress 1.4 RC1 are available here
http://people.apache.org/~bodewig/commons-compress-1.4RC1
(;
}
That fixes the warning but not the real issue. Why not use UTF-8 to
get a platform independent result?
If this simply dump the data on the console I think the default encoding
is a sensible choice. Otherwise this will output corrupted characters
when run from the command line.
Emmanuel
As I understand Droid is a framework for building web crawlers, right?
Considering it's a specialized HTTP client, isn't the HttpComponents
project a more natural fit for the graduation?
Emmanuel Bourg
Le 07/11/2012 18:58, Phil Steitz a écrit :
On 11/7/12 8:50 AM, Richard Frovarp wrote
Le 08/11/2012 00:13, Gary Gregory a écrit :
Or Nutch?
Gary
You are right, Nutch already has a web crawler, that looks like the
perfect home for a crawler framework.
Emmanuel Bourg
smime.p7s
Description: Signature cryptographique S/MIME
...). But in this case there is a project, Nutch, whose core
functionality is exactly the goal of the component.
That why I think this solution should be preferred. Cocoon could then
have a dependency on a nutch-crawling component.
Emmanuel Bourg
smime.p7s
Description: Signature cryptographique
the past year. That's
probably what prevents the project from graduating to a TLP.
Emmanuel Bourg
smime.p7s
Description: Signature cryptographique S/MIME
It seems the permissions for Commons Imaging in JIRA are not properly
configured, I'm unable to operate on the issues.
Is there anyone with sufficient rights to fix that ? Luc ?
Emmanuel Bourg
smime.p7s
Description: Signature cryptographique S/MIME
, the
commons-developers isn't assigned to the administrators. I'm going to
fix that.
Emmanuel Bourg
smime.p7s
Description: Signature cryptographique S/MIME
people to believe that JIRA is appropriate
for questions.
I propose to ask Infra to ensure all the Commons components use the
same Issue type.
OK?
I don't think it's necessary to bug the Infra for this, we can configure
it ourself.
Emmanuel Bourg
smime.p7s
Description: Signature
Le 08/11/2012 12:53, Emmanuel Bourg a écrit :
I don't think it's necessary to bug the Infra for this, we can configure
it ourself.
I'm pretty sure I have been able to do that once, but I can't find how
to do it now. So let's ask to the Infra team :)
Emmanuel Bourg
smime.p7s
Description
and shortly later, you have CMS supported site.
Is it possible to publish generated content like Javadocs and Maven
sites with this CMS ?
Emmanuel Bourg
smime.p7s
Description: Signature cryptographique S/MIME
then get the Maven integration right to simplify the
publishing.
Emmanuel Bourg
Le 14/11/2012 08:40, Luc Maisonobe a écrit :
Hi all,
Once again, I ping everyone in our community to find a volunteer to move
our site to one of the new mechanisms provided by infra: svnpubsub or
the Apache CMS
are much less
important than the ease of use from user's point of view.
Emmanuel Bourg
smime.p7s
Description: Signature cryptographique S/MIME
? It would have to do some validation.
What about making CSVFormat.validate() public for validating after
building the format if that's really required ?
Emmanuel Bourg
smime.p7s
Description: Signature cryptographique S/MIME
Le 26/11/2012 01:01, sebb a écrit :
Hope this all makes sense!
Well, maybe I misunderstood, but committing the RC sites for review into
a SVN repository seems a bit convoluted to me. A good old upload on
people.apache.org was perfectly fine.
Emmanuel Bourg
smime.p7s
Description: Signature
? I don't know if it's worth competing with Lombok though.
Emmanuel Bourg
[1] http://projectlombok.org
[2] http://projectlombok.org/features
[3] https://github.com/peichhorn/lombok-pg/wiki
[4] http://peichhorn.github.com/lombok-pg/SwingInvoke.html
Le 28/11/2012 21:44, Matt Benson a écrit :
Hi
calling a not yet generated method. Bytecode
processing would not allow that.
For altering the body of existing methods like @DoPrivileged or
@SwingInvokeLater bytecode processing is perfectly fine.
Emmanuel Bourg
smime.p7s
Description: Signature cryptographique S/MIME
of BCEL.
If an annotation equivalent to @SwingInvokeLater can be added to the
project I would be highly interested in using it.
As for the name of the component, what about Commons Weaver ?
Emmanuel Bourg
smime.p7s
Description: Signature cryptographique S/MIME
to return T[] instead of Object[]?
- I don't understand what is generous in GenerousBeanProcessor :)
Emmanuel Bourg
smime.p7s
Description: Signature cryptographique S/MIME
Le 20/03/2013 14:04, Benedikt Ritter a écrit :
How about updating to 4.11 instead? Old tests will run on 4.11 and can be
migrated.
I don't use JUnit 4, but feel free to upgrade further. I just wanted to
check if openpgp was still compatible with the latest version of
BouncyCastle.
Emmanuel
://www.apache.org/dev/release-signing.html#web-of-trust
The winter is over, it's time to go out and have a drink together to get
the keys signed folks! Anyone gets near Paris in the next months ? :)
Emmanuel Bourg
smime.p7s
Description: Signature cryptographique S/MIME
I just noticed the news URLs on the web site. Is there a way to keep the
short ones we had before ?
Emmanuel Bourg
smime.p7s
Description: Signature cryptographique S/MIME
Is it possible to disable cobertura at the component level only?
Emmanuel Bourg
Le 25/03/2013 11:01, Luc Maisonobe a écrit :
Hi all,
We have already discussed about some problems with the cobertura maven
plugin (see http://markmail.org/thread/hqckkacin7zby35c and
http://markmail.org
package is built with Maven, but there was a similar issue
with the build.xml file shipped with Commons Pool 1.6 and it prevented
the Debian package from building.
Emmanuel Bourg
Le 24/03/2013 14:13, Simone Tripodi a écrit :
Hi all,
I've prepared the RC1 of Apache Commons-FileUpload 1.3 so I
Le 25/03/2013 21:11, sebb a écrit :
-1
If this is part of the public API, it will break compatibility.
The deprecated ctor does no harm, so please revert.
But it hasn't been released yet, right? It's still time to clean up the API.
Emmanuel Bourg
smime.p7s
Description: Signature
Le 23/03/2013 12:41, Benedikt Ritter a écrit :
WDYT?
Benedikt
-1, this is overly complicated for such a simple component.
I once wished we could design something simple and elegant, but it seems
the wind is blowing in another direction, so I'll just give up.
Emmanuel Bourg
smime.p7s
understand immediately that's what I should probably
use. With RFC4180_EMPTY_LINES I have no idea what this means (and
probably scared that I'll have to read a RFC to understand it).
Emmanuel Bourg
smime.p7s
Description: Signature cryptographique S/MIME
name that shouts
start with this at the first glance.
Emmanuel Bourg
smime.p7s
Description: Signature cryptographique S/MIME
is not explicitly mentioned.
Considering that it's better not to lose information when parsing I'm
inclined to think that empty lines shouldn't be thrown out by default.
Emmanuel Bourg
smime.p7s
Description: Signature cryptographique S/MIME
point of the fluent API was to avoid the
proliferation of constructors, or the use of a huge constructor with
many parameters that are often impossible to remember properly.
Emmanuel Bourg
smime.p7s
Description: Signature cryptographique S/MIME
several CSV APIs built around the traditional
constructors/accessors pattern. The idea here was to start afresh with
new ideas. If we just replicate what exists elsewhere we don't create
much value.
Emmanuel Bourg
smime.p7s
Description: Signature cryptographique S/MIME
implementation looked
like this:
IterableCSVRecord parse =
CSVFormat.DEFAULT.withCommentStart('#').withDelimiter('\t').withQuoteChar('').parse(in);
So yes, in this spirit the builder should implement parse(). But I would
prefer no builder at all.
Emmanuel Bourg
smime.p7s
Description: Signature
to newFormat() again it would become:
IterableCSVRecord parse =
CSVFormat.newFormat().withCommentStart('#').withDelimiter('\t').withQuoteChar(').parse(in);
That looks better than newBuilder() to me.
Emmanuel Bourg
smime.p7s
Description: Signature cryptographique S/MIME
is likely to help them greatly.
I would just note that we publish a src.zip and src.tar.gz artifact in
the Maven repository. We should probably publish only one to avoid
overloading the repository.
Emmanuel Bourg
smime.p7s
Description: Signature cryptographique S/MIME
Why do we publish the native-src.zip/.tar.gz artifacts in the Maven
repository? That seems to be just a subset of the src.zip/.tar.gz artifacts.
Emmanuel Bourg
Le 28/03/2013 14:12, Mladen Turk a écrit :
Apache Commons Daemon 1.0.15 based on RC1 is ready.
This is bug fix release fixing both
the downstream packaging. Any library (from
Apache or elsewhere) could be downloaded in a buildable form directly
from the central Maven repository.
Emmanuel Bourg
smime.p7s
Description: Signature cryptographique S/MIME
distribution pages with artifacts
downloaded from Maven. I'm just stating that publishing a buildable
source package to Maven would be a useful addition.
Emmanuel Bourg
smime.p7s
Description: Signature cryptographique S/MIME
to an ASF space first. However one could
say that official means signed by a verifiable member of the ASF, and
that's why it's important that our keys are cross signed to establish a
strong web of trust.
Emmanuel Bourg
smime.p7s
Description: Signature cryptographique S/MIME
.
Emmanuel Bourg
smime.p7s
Description: Signature cryptographique S/MIME
1 - 100 of 1071 matches
Mail list logo
