Re: JCS-244

2026-03-09 Thread Thomas Vandahl
Hi Florin,

> Am 06.03.2026 um 22:21 schrieb Florin Pop :
> 
> Hi there,
> 
> we have an issue with the LateralTCP cache listener and proposing a fix for
> it via https://github.com/apache/commons-jcs/pull/407
> 
> I need some guidance to finalize this, it is my first contribution to Open
> Source. Can I have a short chat with someone from the team?

Thanks for bringing the issue to our attention and thanks for your 
contribution. See my comments on the PullRequest and JCS-244.
I prefer to fix the problem a bit closer to its source. The code in 
IElementSerializer already contained the necessary asserts to handle data 
integrity issues. I converted the asserts to explicit shows of IOExceptions and 
added a test to 
org.apache.commons.jcs4.utils.serialization.StandardSerializerUnitTest. The 
problem can be reproduced on the stream/channel level. There is no need for a 
socket.

Bye, Thomas 
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: JCS-244

2026-03-06 Thread Florin Pop
Hi Gary,

I'm not sure how to write the testcase for this fix, since reproducing the
issue involves multiple computers and then another "hack" to cause the
listener to die.
Guidance here would be great. Also, I'd be interested in input from DEVs
with more experience in this area: Is logging the exception the right
approach? My tests show that the listener now survives and no longer
disappears in the case of java.nio.BufferUnderflowException.

Thanks,
Florin

On Sat, Mar 7, 2026 at 1:57 AM Gary Gregory  wrote:

> Hi Florin,
>
> Unless it is a private or security-related issue, we prefer to keep
> discussions on the mailing list so that everyone can benefit from the
> information in the future.
>
> Best,
> Gary
>
> On Fri, Mar 6, 2026 at 4:32 PM Florin Pop  wrote:
> >
> > Hi there,
> >
> > we have an issue with the LateralTCP cache listener and proposing a fix
> for
> > it via https://github.com/apache/commons-jcs/pull/407
> >
> > I need some guidance to finalize this, it is my first contribution to
> Open
> > Source. Can I have a short chat with someone from the team?
> >
> > Thanks,
> > Florin
>
> -
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>


Re: JCS-244

2026-03-06 Thread Gary Gregory
Hi Florin,

Unless it is a private or security-related issue, we prefer to keep
discussions on the mailing list so that everyone can benefit from the
information in the future.

Best,
Gary

On Fri, Mar 6, 2026 at 4:32 PM Florin Pop  wrote:
>
> Hi there,
>
> we have an issue with the LateralTCP cache listener and proposing a fix for
> it via https://github.com/apache/commons-jcs/pull/407
>
> I need some guidance to finalize this, it is my first contribution to Open
> Source. Can I have a short chat with someone from the team?
>
> Thanks,
> Florin

-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]