fix for this issue.
Regards,
Evgeny Kotkov
Index: modules/http2/h2_h2.c
===
--- modules/http2/h2_h2.c (revision 1747688)
+++ modules/http2/h2_h2.c (working copy)
@@ -629,8 +629,8 @@ int h2_h2_process_conn(conn_rec
_mbox/httpd-dev/201606.mbox/raw/%3CCAP_GPNgHADdp2YbNB2CtraR_9x%2Bdg4Wss6Kd1ZG0BsU_v%2Bw2rw%40mail.gmail.com%3E/2
Regards,
Evgeny Kotkov
. Both of the patches are against trunk.
[1] https://bz.apache.org/bugzilla/show_bug.cgi?id=50447
[2] https://svn.apache.org/r1044673
Regards,
Evgeny Kotkov
mod_rewrite: Fix double escaping of the query string for RewriteRules in
server context.
See PR 50447 and r1044673 that fixed
framework.
[1]
https://mail-archives.apache.org/mod_mbox/httpd-dev/201602.mbox/%30ea0e-00ce-430d-a01c-022e7a2ff...@greenbytes.de%3E
Regards,
Evgeny Kotkov
mod_rewrite: Add handling of 'h2' and 'h2c' schemes for mod_proxy_http2.
Index: modules/mappers/mod_rewrite.c
I noticed a few issues in CMakeLists.txt that currently prevent building
mod_http2 and mod_proxy_http2 — that is, missing includes and library
references.
The attached patch should fix them.
Regards,
Evgeny Kotkov
Fix CMake support for mod_http2 and mod_proxy_http2.
Index: CMakeLists.txt
te tests the result against the OK (hook return code). I updated
such places in the second patch.
Regards,
Evgeny Kotkov
mod_proxy_http2: Guard against theoretically possible segfault with
invalid URIs.
Index: modules/http2/h2_proxy_s
, here are some of the existing changes
that target similar problems (mod_rewrite not picking up a new scheme
for proxy URLs). I examined them prior to preparing the patch:
https://svn.apache.org/r1528556
https://svn.apache.org/r405625
https://svn.apache.org/r124584
Regards,
Evgeny Kotkov
ight now there is no
explicit test for the case of sending "Accept-Encoding: gzip, deflate"
to a location with both mod_brotli and mod_deflate.)
Regards,
Evgeny Kotkov
files in [https://github.com/google/brotli/commit/fe9f9a91], and it requires
an update in the filters/config.m4 file; I'll do that.)
Regards,
Evgeny Kotkov
issue, but perhaps there's a completely
different and a better way to solve the problem? What do you think?
[1] https://svn.apache.org/r1748047
Regards,
Evgeny Kotkov
> apr_brigade_cleanup() after calling ap_pass_brigade() at the end of each
> iteration to ensure it's empty.
Thanks for pointing this out. I'll fix the problem (and a similar issue in
repos.c:write_to_filter()).
Regards,
Evgeny Kotkov
mod_dav: Fix a potential cause of unbounded memory u
://mail-archives.apache.org/mod_mbox/subversion-dev/201512.mbox/%3ccap_gpnha4hbfdoc7z1d-k9h_nhm8d7wjyfsf4ouoteuepkj...@mail.gmail.com%3E
[2] https://svn.apache.org/r1756561
Regards,
Evgeny Kotkov
Evgeny Kotkov <evgeny.kot...@visualsvn.com> writes:
> However, the problem I described in this thread is different, and it just
> happens to have the same visible consequence.
>
> What is probably more important, the dav_send_one_response() function
> that has the flaw (s
Jacob Champion <champio...@gmail.com> writes:
>> Please welcome Evgeny Kotkov as a new committer!
>
> Excellent, welcome to the team!
Thanks everyone!
Regards,
Evgeny Kotkov
Evgeny Kotkov <evgeny.kot...@visualsvn.com> writes:
>>> Wow! This is great stuff. Brotli support has been in my TODO
>>> queue for awhile.
>>>
>>> Thanks!
>>
>> +1, cool stuff and thanks!
>
> Glad to hear that, thanks everyo
this module, for instance, by
adding the necessary documentation and the ability to log compression ratio.
Regards,
Evgeny Kotkov
d with mod_filter's FilterProvider directive using
an expression that doesn't install any compression filters for the scripts.
Regards,
Evgeny Kotkov
of this part in r1761824 [1], and it fixes this build
issue for me. Could you please check it in your environment as well?
[1] https://svn.apache.org/r1761824
Thanks,
Evgeny Kotkov
ld certainly be nice, but this version of the patch doesn't have it
yet. I could do this separately or provide the V2 patch that supports
ratio_info.
Regards,
Evgeny Kotkov
/firefox/44.0/releasenotes/
[2] https://www.chromestatus.com/feature/5420797577396224
[3] https://github.com/google/brotli
[4] https://github.com/bagder/libbrotli
[5] https://github.com/google/brotli/pull/332
Regards,
Evgeny Kotkov
Index: CMakeLists.txt
Evgeny Kotkov <evgeny.kot...@visualsvn.com> writes:
> It might be possible to rework mod_dav_svn, although it's going to take
> some time. Currently, every top-level handler receives an `ap_filter_t *`
> and passes it further, and all these places would have to be updated so
&g
ere. (How does the #define INFINITY
look like in your environment? Perhaps, it's specifically designed to
prohibit assignment?). One workaround to get past this would be to use
the #else part of this code.
Regards,
Evgeny Kotkov
hanks, I committed the patch in https://svn.apache.org/r1771791
Regards,
Evgeny Kotkov
e a few bytes and a few cycles.
r1790852: Update makefile to allow using Brotli library >= 0.6.0.
r1790853: Fix a minor typo in the description of BrotliAlterETag
that has been referring to httpd 2.2.x.
r1790860: Comment on the default choice (0) for BROTLI_PARAM_LGBLOCK.
Regards,
Evgeny Kotkov
Evgeny Kotkov <evgeny.kot...@visualsvn.com> writes:
> (1) As a part of the process of shutting down worker threads, the code
> around child.c:1170 currently posts an amount of I/O completion packets
> equal to the amount of the threads blocked on the I/O
Ivan Zhakov <i...@visualsvn.com> writes:
> Please find attached patch that removes unused values of io_state_e
> enum in mpm_winnt.
Thanks, patch committed in https://svn.apache.org/r1801657
Regards,
Evgeny Kotkov
complished changes to the mpm_winnt module, I would appreciate hearing
them as well.
Thanks!
Regards,
Evgeny Kotkov
Index: server/mpm/winnt/child.c
===
--- server/mpm/winnt/child.c(revision 1801135)
+++ server/mpm/winnt/child.c(wo
ntioned changes (r1761824,
r1771789, r1771827, r1779111). With them applied, this part of the
modules/filters/config.m4 file should be identical between trunk and
2.4.x.
I proposed the whole group for the backport in r1792805 and r1792806.
Regards,
Evgeny Kotkov
do you think?
Regards,
Evgeny Kotkov
4
response with the (unexpected) set of headers — which I don't think could
be happening.
Thanks,
Evgeny Kotkov
.). However, with this change both of them would do nothing
for 304, and potentially violate the spec for ETag and maybe some other header
values.
I am thinking about fixing this with the attached patch and proposing it for
backport to 2.4.x.
Would there be any objections to that?
Evgeny Kotkov writes:
>> +1 for the patch, I missed the separate 304 handling in
>> mod_brotli/deflate, thanks for catching this!
>
> Thanks, I will commit it at the earliest opportunity.
Committed and proposed for a backport to 2.4.x:
https://svn.apache.org/r1843242
http
r of the Subversion clients,
for example in cases where the (ignored) error occurred due to a non-successful
authorization check. Other DAV clients may be susceptible to some kinds of
unexpected behavior as well.
[1] https://svn.apache.org/r1892513
Thanks,
Evgeny Kotkov
ing the
method_precondition() hook.
With the patch, `err` is checked even if all hooks DECLINE the operation.
Not too sure if that's intended, because the variable could potentially
contain an arbitrary value or a leftover from some previous call.
Thanks,
Evgeny Kotkov
source->pool, and so it should fix the unbounded memory usage issue.
Thanks!
Regards,
Evgeny Kotkov
a long-living pool as the
resource->pool during the walk.
I think that with this change, the PROPFIND walks are going to make O(N)
allocations for O(N) walked items — which is an unbounded memory usage
and a regression, compared to 2.4.51.
[1] https://svn.apache.org/r1879889
[2] https://svn.apache.org/r189
36 matches
Mail list logo
