Re: 2.2.25 update for httpd.apache.org/ still stuck in staging?

2013-07-11 Thread Mike Rumph
Hello Eric, Does this explain why the security vulnerability information for Apache httpd 2.2.25 has not been added to the following link? - http://httpd.apache.org/security/vulnerabilities_22.html Thanks, Mike Rumph On 7/11/2013 10:57 AM, Eric Covener wrote: 2.2.25 update

[PATCH 55360] Potential buffer overflows in support/ab

2013-08-05 Thread Mike Rumph
understanding of the code. Please, consider the submitted patch for adoption. Thanks, Mike Rumph

Re: [PATCH 55315] mod_proxy interpolation code broken by regression to APR-util 1.5.2

2013-10-08 Thread Mike Rumph
, Mike Rumph mike.ru...@oracle.com wrote: Hello Jeff, Thanks for your reply. On 9/3/2013 6:58 AM, Jeff Trawick wrote: Since the URL validation in apr_uri_parse() has been tightened in the handling of the scheme portion of a URL, I submitted a patch to httpd bug 55315 against the mod_proxy code

Re: [PATCH 55315] mod_proxy interpolation code broken by regression to APR-util 1.5.2

2013-10-08 Thread Mike Rumph
Sorry. I got carried away with the generic translation. I was instead browsing to http://localhost:8080/my_app/ With the results indicated below. Thanks, Mike Rumph On 10/8/2013 1:09 PM, Mike Rumph wrote: I tried the configuration below with httpd trunk: RewriteEngine

False positive errno test after call to strtol()

2013-11-14 Thread Mike Rumph
environments. Thanks, Mike Rumph Index: server/mpm_common.c === --- server/mpm_common.c (revision 1542069) +++ server/mpm_common.c (working copy) @@ -389,6 +389,7 @@ return err; } +errno = 0; value = strtol(arg, NULL

Re: False positive errno test after call to strtol()

2013-11-15 Thread Mike Rumph
if further validation would be warranted. Take care, Mike On 11/15/2013 9:38 AM, Jeff Trawick wrote: On Thu, Nov 14, 2013 at 4:11 PM, Mike Rumph mike.ru...@oracle.com mailto:mike.ru...@oracle.com wrote: The man page for strtol() indicate that the function can set errno to ERANGE (EINVAL

Some redundant code and comment typos in mod_remoteip

2013-12-04 Thread Mike Rumph
While researching mod_remoteip to work on httpd bugs 55635 and 55637, I noticed a few unrelated blemishes in mod_remoteip.c. These include some redundant code and comment typos. The attached patch against httpd trunk should address these. Thanks, Mike Rumph Index: modules/metadata

Re: mod_remoteip

2013-12-09 Thread Mike Rumph
is behaving as documented. But the documentation is a little difficult to understand. Thanks, Mike Rumph On 12/9/2013 10:52 AM, Reindl Harald wrote: Am 09.12.2013 19:28, schrieb Jim Jagielski: This seems kinda serious https://issues.apache.org/bugzilla/show_bug.cgi?id=55635 any

Re: [PATCH]Some redundant code and comment typos in mod_remoteip

2013-12-10 Thread Mike Rumph
I forgot to add a [PATCH] tag on the front of the subject. The changes here are minor, but they do make the code a little cleaner. On 12/4/2013 11:25 AM, Mike Rumph wrote: While researching mod_remoteip to work on httpd bugs 55635 and 55637, I noticed a few unrelated blemishes

Re: Some redundant code and comment typos in mod_remoteip

2013-12-12 Thread Mike Rumph
and thought were worth mentioning. Mike Rumph On 12/12/2013 9:34 AM, William A. Rowe Jr. wrote: On Wed, 04 Dec 2013 11:25:32 -0800 Mike Rumph mike.ru...@oracle.com wrote: While researching mod_remoteip to work on httpd bugs 55635 and 55637, I noticed a few unrelated blemishes

Re: Some redundant code and comment typos in mod_remoteip

2013-12-12 Thread Mike Rumph
Just to make things easier here are the separate patches with your ideas included. Thanks, Mike Rumph On 12/12/2013 1:37 PM, Mike Rumph wrote: Hello Bill, Thanks for the advice. Leaving filename as is is okay for me, I just thought I saw it split at other places in the code comments. So

Re: Some redundant code and comment typos in mod_remoteip

2013-12-13 Thread Mike Rumph
equivalant versus equivalent Perhaps this is a difference in British versus American spelling, correct? Anyway, thanks for the commits. Mike Rumph On 12/12/2013 10:12 PM, Christophe JAILLET wrote: Trunk = r1550650 for comments upodate r1550651 for redundant check 2.4.x = r1550652

Re: mod_remoteip

2013-12-13 Thread Mike Rumph
On 12/11/2013 2:18 PM, William A. Rowe Jr. wrote: On Mon, 09 Dec 2013 11:10:46 -0800 Mike Rumph mike.ru...@oracle.com wrote: As you can see from the bug report, I have been looking into this. It might also be important to consider the related bug 55637: - https://issues.apache.org/bugzilla

Re: mod_remoteip

2013-12-16 Thread Mike Rumph
bring it some attention. Thanks again, Mike Rumph On 12/15/2013 1:00 AM, Lam, Eugene wrote: Secondly, with each cycle of the while loop the apparent client IP is compared against the proxymatch_ip list. Are you referring to the while loop here: http://svn.apache.org/viewvc/httpd/httpd/trunk

Re: [PATCH] mod_remoteip

2013-12-19 Thread Mike Rumph
On 12/13/2013 5:03 PM, William A. Rowe Jr. wrote: There is nothing I see in the code that prevents a cycle with internal proxy from following a cycle with external proxy. It's been several years so I was going from memory, but you are right... So if your explanation is the way the code is

Re: [PATCH] mod_remoteip

2013-12-19 Thread Mike Rumph
Viewing the patch as sent to the mailing list, points out unwanted tab characters. So I reattached a patch with these characters removed. Thanks, Mike Rumph On 12/19/2013 10:46 AM, Mike Rumph wrote: On 12/13/2013 5:03 PM, William A. Rowe Jr. wrote: There is nothing I see in the code

Re: Looking to TR 2.4.8 in Feb...

2014-01-09 Thread Mike Rumph
to help with any further work that might be needed here. Thanks, Mike Rumph On 1/9/2014 5:33 AM, Jim Jagielski wrote: defect? We support UDS in ProxyPass. We don't in mod_rewrite. Nor do we claim to. I don't think that's a defect. If later on UDS support is *also* added to mod_rewrite, then good

ApacheCon 2014 question

2014-01-16 Thread Mike Rumph
Hello all, I am trying to plan a trip to the ApacheCon 2014, April 7-9. And I was wondering if there are any plans for Apache httpd project specific events (such as hackathons or developer days) before or after these dates? Thanks, Mike Rumph

Re: svn commit: r1563894 - in /httpd/httpd/trunk/modules/ssl: ssl_engine_kernel.c ssl_private.h

2014-02-03 Thread Mike Rumph
Hello Jeff, s/limitiations/limitations/ Thanks, Mike Rumph On 2/3/2014 5:50 AM, traw...@apache.org wrote: Author: trawick Date: Mon Feb 3 13:50:14 2014 New Revision: 1563894 URL: http://svn.apache.org/r1563894 Log: fix a few spelling errors Modified: httpd/httpd/trunk/modules/ssl

Re: svn commit: r1563894 - in /httpd/httpd/trunk/modules/ssl: ssl_engine_kernel.c ssl_private.h

2014-02-03 Thread Mike Rumph
I think the following change is also valid: s/setup/set up/when used as a verb. On 2/3/2014 7:55 AM, Mike Rumph wrote: Hello Jeff, s/limitiations/limitations/ Thanks, Mike Rumph On 2/3/2014 5:50 AM, traw...@apache.org wrote: Author: trawick Date: Mon Feb 3 13:50:14 2014 New Revision

Re: svn commit: r1565717 - /httpd/httpd/trunk/server/core.c

2014-02-07 Thread Mike Rumph
Hello Jim, What is the purpose of the extra / on line 1? Thanks, Mike Rumph On 2/7/2014 8:44 AM, j...@apache.org wrote: Author: jim Date: Fri Feb 7 16:44:57 2014 New Revision: 1565717 URL: http://svn.apache.org/r1565717 Log: Oops... missed this when I switched slaves to their own struct

Re: Welcome to Mike Rumph and Yann Ylavic!

2014-02-17 Thread Mike Rumph
Hello all, Thanks for the welcome! I look forward to working with all of you towards an even better Apache HTTP Server. See you in Denver, Mike Rumph On 2/17/2014 9:28 AM, Daniel Gruno wrote: On 02/17/2014 06:26 PM, Eric Covener wrote: Mike Rumph and Yann Ylavic have recently joined us

Re: svn commit: r1569108 - /httpd/httpd/branches/2.4.x/STATUS

2014-02-17 Thread Mike Rumph
names. Could this be pulled to apr-util/include/apr_util.h in future releases of apr-util? 2) Could mod_proxy_wstunnel.c benefit from a similar change as this fix does for mod_proxy_http.c? Thanks, Mike Rumph On 2/17/2014 12:42 PM, mru...@apache.org wrote: Author: mrumph Date: Mon Feb

Re: svn commit: r1569108 - /httpd/httpd/branches/2.4.x/STATUS

2014-02-17 Thread Mike Rumph
On 2/17/2014 1:11 PM, Mike Rumph wrote: Hello Jim, I voted for this change for backport to 2.4.8. The fix looks solid to me at this time. But I do have a couple of questions/ideas for the future. 1) proxy_schemes_t in modules/proxy/proxy_util.c and schemes_t in apr-util/uri/apr_uri.c

Review of mod_proxy_http proposal for httpd 2.4.8

2014-02-26 Thread Mike Rumph
- http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/http/chunk_filter.c?view=markup Do these two patches need to stay together (atomic)? Thanks, Mike Rumph

Re: Review of mod_proxy_http proposal for httpd 2.4.8

2014-02-27 Thread Mike Rumph
Hello Yann, Thanks for your explanation. Okay, that clears it up for me. On 2/27/2014 1:36 AM, Yann Ylavic wrote: Hello Mike , thanks for looking at this. On Wed, Feb 26, 2014 at 8:11 PM, Mike Rumph mike.ru...@oracle.com mailto:mike.ru...@oracle.com wrote: I am trying to review

Re: svn commit: r1574518 - /httpd/httpd/trunk/modules/loggers/mod_log_config.c

2014-03-05 Thread Mike Rumph
Hello Jim, I see a style difference in the change below compare to the lines just above it. How to test a value after an assignment. In the while statement the value is tested implicitly. In the if statement the value is explicitly compared against NULL. Usually the second way is chosen to

Configuration error handling after httpd restart

2014-03-27 Thread Mike Rumph
, Mike Rumph

Re: stop copying footers to r-headers_in?

2014-04-01 Thread Mike Rumph
Hello Yann, Comment included below. Thanks, Mike Rumph On 4/1/2014 11:00 AM, Yann Ylavic wrote: Index: modules/examples/mod_example_hooks.c === --- modules/examples/mod_example_hooks.c(revision 1583714) +++ modules/examples

Re: svn commit: r1585157 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_rewrite.xml docs/manual/rewrite/flags.xml modules/mappers/mod_rewrite.c

2014-04-07 Thread Mike Rumph
Small typo fix below: On 4/5/2014 11:40 AM, cove...@apache.org wrote: Author: covener Date: Sat Apr 5 18:40:36 2014 New Revision: 1585157 URL: http://svn.apache.org/r1585157 Log: add BNP flag to give control to the user on whether a space ' ' in an escaped backrefernece is decoded to a +

Re: Configuration error handling after httpd restart

2014-04-14 Thread Mike Rumph
on this? There are also underlying issues that are bypassed by your fix. Other more complicated test cases may uncover these again. I hope to have some time to investigate these issues and do further negative testing. Thanks, Mike On 4/11/2014 10:43 AM, Jim Riggs wrote: On 27 Mar 2014, at 14:16, Mike

Re: svn commit: r1588135 - in /httpd/httpd/branches/2.4.x/docs/manual/mod: mod_logio.html.en mod_logio.xml

2014-04-17 Thread Mike Rumph
Grammar corrections below. On 4/16/2014 10:38 PM, jaillet...@apache.org wrote: Author: jailletc36 Date: Thu Apr 17 05:38:49 2014 New Revision: 1588135 URL: http://svn.apache.org/r1588135 Log: s/two/three/ Modified: httpd/httpd/branches/2.4.x/docs/manual/mod/mod_logio.html.en

Re: svn commit: r1594301 - in /httpd/httpd/trunk/server/mpm: event/event.c eventopt/eventopt.c worker/worker.c

2014-05-13 Thread Mike Rumph
s/appropiate/appropriate/ This could also be fixed in APR, if someone with APR commit access has a few idle minutes. Thanks, Mike Rumph On 5/13/2014 10:50 AM, mru...@apache.org wrote: Author: mrumph Date: Tue May 13 17:50:39 2014 New Revision: 1594301 URL: http://svn.apache.org/r1594301

Re: svn commit: r1599641 - in /httpd/httpd/trunk: include/ap_mmn.h include/util_time.h server/mpm/event/event.c server/mpm/eventopt/eventopt.c server/mpm/prefork/prefork.c server/mpm/worker/worker.c s

2014-06-03 Thread Mike Rumph
Hello Jim, There is a small typo here. s/many operationg systems/many operating systems/ Thanks, Mike Rumph On 6/3/2014 9:02 AM, j...@apache.org wrote: Author: jim Date: Tue Jun 3 16:02:44 2014 New Revision: 1599641 URL: http://svn.apache.org/r1599641 Log: Break out common code

Re: svn commit: r1601943 - in /httpd/httpd/trunk: include/ap_mmn.h include/ap_mpm.h include/mpm_common.h modules/proxy/mod_proxy_wstunnel.c server/mpm/event/event.c server/mpm_common.c

2014-06-11 Thread Mike Rumph
On 6/11/2014 9:39 AM, taka...@apache.org wrote: --- httpd/httpd/trunk/include/ap_mpm.h (original) +++ httpd/httpd/trunk/include/ap_mpm.h Wed Jun 11 16:39:34 2014 @@ -198,6 +198,7 @@ AP_DECLARE(apr_status_t) ap_mpm_query(in /** @} */ typedef void (ap_mpm_callback_fn_t)(void *baton);

Re: Change of web site layout

2014-06-16 Thread Mike Rumph
criticisms are important for the process. Each of them should be considered. Thanks to all, Mike Rumph On 6/16/2014 1:38 AM, Greg Stein wrote: On Mon, Jun 16, 2014 at 3:00 AM, André Malo n...@perlig.de mailto:n...@perlig.de wrote: * Daniel Gruno wrote: ... I'm finding the back/forth

Re: svn commit: r1611252 - /httpd/httpd/trunk/include/util_varbuf.h

2014-07-17 Thread Mike Rumph
A few comments on typos below: On 7/16/2014 10:34 PM, jaillet...@apache.org wrote: Improve layout, add trailing '.' in function description, capitalize first letter of description, fix typo, turn \0 into \\0. Move the detailled description after @defgroup so that it is taken into account.

Re: svn commit: r1630406 - /httpd/httpd/branches/2.2.x/STATUS

2014-10-09 Thread Mike Rumph
This is so picky :). s/accross/across/ On 10/9/2014 5:36 AM, yla...@apache.org wrote: Author: ylavic Date: Thu Oct 9 12:36:19 2014 New Revision: 1630406 URL: http://svn.apache.org/r1630406 Log: Fix misspelling in changelog (including CHANGES for proposed patch). Modified:

Re: svn commit: r1627749 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS modules/cache/cache_util.c

2014-10-14 Thread Mike Rumph
, the problem is in the store_headers function in modules/cache/mod_disk_cache.c. Are either of you interested in working a patch for this? Otherwise, I will look at it myself in a few days. Thanks, Mike Rumph On 9/26/2014 4:00 AM, j...@apache.org wrote: Author: jim Date: Fri Sep 26 11:00:14

Re: svn commit: r1627749 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS modules/cache/cache_util.c

2014-10-14 Thread Mike Rumph
In 2.2 code, this problem is actually in two places. It is also in the store_headers function in modules/cache/mod_mem_cache.c. On 10/14/2014 8:40 AM, Mike Rumph wrote: Hello Jim and Jan, I am considering a proposal of backporting this fix to the 2.2 branch. At first look, this fix doesn't

Re: svn commit: r1627749 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS modules/cache/cache_util.c

2014-10-14 Thread Mike Rumph
. Take care, Mike On 10/14/2014 10:03 AM, Eric Covener wrote: I thought at the time, the discussion was that ap_make_content_type in those releases never returned NULL. On Tue, Oct 14, 2014 at 1:01 PM, Mike Rumph mike.ru...@oracle.com mailto:mike.ru...@oracle.com wrote: In 2.2 code

Re: svn commit: r1640823 - /httpd/httpd/trunk/modules/filters/mod_reqtimeout.c

2014-11-20 Thread Mike Rumph
Hello Yann, I would have thought that a MIN macro would already be defined somewhere. If not, perhaps a more central location (some header file) could be chosen for it. Thanks, Mike On 11/20/2014 1:38 PM, yla...@apache.org wrote: Author: ylavic Date: Thu Nov 20 21:38:53 2014 New Revision:

Re: svn commit: r1611169 - in /httpd/httpd/trunk: CHANGES server/mpm/winnt/service.c

2015-01-14 Thread Mike Rumph
Hello Bill, Sorry to respond to this so late, but I see that this is up for a vote against httpd 2.4. I noticed a possible problem in the code. I have a question inserted below. Thanks, Mike Rumph On 7/16/2014 1:15 PM, wr...@apache.org wrote: Author: wrowe Date: Wed Jul 16 20:15:49 2014

Re: svn commit: r1653941 - in /httpd/httpd/trunk: CHANGES docs/manual/expr.xml docs/manual/mod/mod_alias.xml modules/mappers/mod_alias.c

2015-01-22 Thread Mike Rumph
On 1/22/2015 9:02 AM, minf...@apache.org wrote: == --- httpd/httpd/trunk/modules/mappers/mod_alias.c (original) +++ httpd/httpd/trunk/modules/mappers/mod_alias.c Thu Jan 22 17:02:22 2015 @@ -34,6 +34,7 @@ #include

Re: fast sequential requests under event

2015-03-27 Thread Mike Rumph
had your skill, time and enthusiasm for the project. Please, keep up the good work! Take care, Mike Rumph On 3/27/2015 3:44 PM, Yann Ylavic wrote: On Fri, Mar 27, 2015 at 1:27 PM, Jim Jagielski j...@jagunet.com wrote: On Mar 26, 2015, at 9:28 AM, Eric Covener cove...@gmail.com wrote

Re: svn commit: r1675436 - /httpd/httpd/trunk/docs/manual/mod/mod_authnz_ldap.xml

2015-04-22 Thread Mike Rumph
/httpd-trunk/docs/manual/mod/mod_authnz_ldap.xml:118:28: Attribute name must be declared for element type module. BUILD FAILED /home/mrumph/httpd-trunk/docs/manual/style/lang-targets.xml:294: /home/mrumph/httpd-trunk/docs/manual/mod/mod_authnz_ldap.xml is not a valid XML document. Thanks, Mike

Re: svn commit: r1675471 - in /httpd/httpd/trunk/docs/manual/mod: core.xml mod_mime.xml

2015-04-22 Thread Mike Rumph
Hello Eric, This changed gives the following error when ./build.sh validate-xml is run: Buildfile: build.xml validate-xml: [xmlvalidate] /home/mrumph/httpd-trunk/docs/manual/mod/core.xml:1916:7: The element type p must be terminated by the matching end-tag /p. BUILD FAILED

Re: svn commit: r1687021 - /httpd/httpd/trunk/modules/session/mod_session_dbd.c

2015-06-23 Thread Mike Rumph
Hello Yann, This is just a matter of style, but isn't it more typical to have pool as the first parameter of a function? Even in mod_session_dbd.c, this is seen in dbd_clean(), session_dbd_monitor(), create_session_dbd_dir_config() and merge_session_dbd_dir_config(). Thanks, Mike On

Re: 2.2 and 2.4 and 2.6/3.0

2015-05-27 Thread Mike Rumph
The 2.2.x branch is still of interest to the product I work on. So I am willing to devote effort towards its maintenance. Thanks, Mike On 5/27/2015 7:46 AM, Jeff Trawick wrote: What we need to know for the 2.2.x branch is basically this: Developers (committers or not): [Y] I am

Re: Is Apache getting too patchy?

2015-10-26 Thread Mike Rumph
But from my limited perspective the discussions seem to be going in a good direction. Thanks, Mike Rumph On 10/24/2015 8:49 AM, Jim Jagielski wrote: Just some food for thought; let me know if I'm off the rails. Over the last several months, it's appeared to me that we have been addi

Re: svn commit: r1689694 - /httpd/httpd/trunk/modules/ldap/util_ldap.c

2015-07-07 Thread Mike Rumph
Comment inline below: On 7/7/2015 7:43 AM, cove...@apache.org wrote: Author: covener Date: Tue Jul 7 14:43:31 2015 New Revision: 1689694 URL: http://svn.apache.org/r1689694 Log: stuff unexpected LDAP errors into ldc-reason, not just in trace messages. fix some enormously long lines introduced

Re: svn commit: r1705695 - /httpd/httpd/trunk/docs/manual/mod/mod_h2.xml

2015-09-28 Thread Mike Rumph
See below: On 9/28/2015 7:03 AM, Eric Covener wrote: Modified: httpd/httpd/trunk/docs/manual/mod/mod_h2.xml URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/manual/mod/mod_h2.xml?rev=1705695=1705694=1705695=diff

Re: svn commit: r1717123 - /httpd/httpd/trunk/docs/manual/mod/mod_allowmethods.xml

2015-12-02 Thread Mike Rumph
Comment below. On 11/29/2015 1:00 PM, jaillet...@apache.org wrote: Author: jailletc36 Date: Sun Nov 29 21:00:32 2015 New Revision: 1717123 URL: http://svn.apache.org/viewvc?rev=1717123=rev Log: Fix doc as spotted by mat in online doc Modified:

Re: svn commit: r1717123 - /httpd/httpd/trunk/docs/manual/mod/mod_allowmethods.xml

2015-12-03 Thread Mike Rumph
No problem. I took care of this along with other typos and grammar corrections in r1717786 and r1717800. Thanks, Mike On 12/2/2015 10:37 AM, Marion & Christophe JAILLET wrote: Will fix. Sorry for not seeing it myself. CJ Le 02/12/2015 15:28, Mike Rumph a écrit : Comment below. On 1

Re: OpenSSL 0.9.8/1.0.0 on Trunk

2015-12-15 Thread Mike Rumph
FYI. Bug 58737 was just opened today for this error. Thanks, Mike On 12/14/2015 10:15 AM, William A Rowe Jr wrote: W.r.t. http://svn.apache.org/r1719967 - I'm +1 for the backport. I'd like to propose we remove all support from *trunk* for OpenSSL < 1.0.1 effective now...

Re: Upgrade Summary

2015-12-10 Thread Mike Rumph
Question below: On 12/10/2015 2:46 AM, Stefan Eissing wrote: int xxx_switch(conn_rec *c, request_rec *r, server_rec *s, const char *protocol, int phase) { apr_status_t stats; if (strcmp(my_protocol, protocol)) { Do you mean "if

Re: svn commit: r1723737 - in /httpd/test/mod_h2/trunk: mh2fuzz/h2c_conn.c mh2fuzz/h2c_session.c test/test_frames.sh

2016-01-08 Thread Mike Rumph
Comment below. On 1/8/2016 7:26 AM, ic...@apache.org wrote: Author: icing Date: Fri Jan 8 15:26:16 2016 New Revision: 1723737 URL: http://svn.apache.org/viewvc?rev=1723737=rev Log: normalized frame output for testing Modified: httpd/test/mod_h2/trunk/mh2fuzz/h2c_conn.c

Re: mod_fcgid and broken doc links

2016-01-13 Thread Mike Rumph
A background for this request can be seen in bug report 56121. - https://bz.apache.org/bugzilla/show_bug.cgi?id=56121#c4 This bug also describes a manual method for working around this problem. On 1/12/2016 10:13 AM, Rich Bowen wrote: mod_fcgid is in a separate repo from the main httpd tree,

Re: Apache 2.4 adoption revisited -- now 16.4% of Apache sites

2016-02-22 Thread Mike Rumph
On 2/22/2016 3:40 PM, Luca Toscano wrote: 2016-02-21 15:55 GMT+01:00 Luca Toscano >: Would it be worth to add a small banner on each documentation page for 2.2 stating something like: Patch attached with a very high level

Re: svn commit: r1725339 - /httpd/httpd/trunk/docs/manual/index.xml.es

2016-01-20 Thread Mike Rumph
On 1/18/2016 12:20 PM, jaillet...@apache.org wrote: Author: jailletc36 Date: Mon Jan 18 20:20:24 2016 New Revision: 1725339 URL: http://svn.apache.org/viewvc?rev=1725339=rev Log: Spanish XML update Modified: httpd/httpd/trunk/docs/manual/index.xml.es Modified:

Re: svn commit: r1725339 - /httpd/httpd/trunk/docs/manual/index.xml.es

2016-01-20 Thread Mike Rumph
Okay. Thanks. I thought it would be something like that. On 1/20/2016 8:09 AM, André Malo wrote: * Mike Rumph wrote: Is there some reason why the license information is not translated into Spanish? Yes. It would not have any legal power. There is no official translation of the apache

Re: Detecting client aborts and stream resets

2016-05-03 Thread Mike Rumph
Hello Michael. On 5/3/2016 7:31 AM, Michael Kaufmann wrote: Hi all, a content generator module can detect client aborts and stream resets while it reads the request body. But how can it detect this afterwards, while the response is being generated? This is important for HTTP/2, because the

Re: svn commit: r1741621 - /httpd/httpd/trunk/docs/manual/mod/event.xml

2016-05-02 Thread Mike Rumph
Added a couple of suggestions below. On 4/29/2016 5:40 AM, elu...@apache.org wrote: Author: elukey Date: Fri Apr 29 12:40:49 2016 New Revision: 1741621 URL: http://svn.apache.org/viewvc?rev=1741621=rev Log: Added a specific reference to mpm-event's doc about the fact that mpm-accept is not

Re: svn commit: r1766129 - in /httpd/httpd/trunk/modules/http2: h2_session.c h2_stream.c

2016-10-24 Thread Mike Rumph
pio...@gmail.com> wrote: On 10/24/2016 08:54 AM, Mike Rumph wrote: +return status ? status : rv; This line seems to depend on the assumption that APR_SUCCESS is coded as zero. Wouldn't it be better to not hard code that assumption? This assumption is pretty deep in APR itself I think (on u

Re: Help with task: Websocket documentation

2017-03-21 Thread Mike Rumph
Hello Mohit, Help with the project is always welcome. The Apache HTTP Server Documentation Project webpage is a good place to start. - http://httpd.apache.org/docs-project/ For help on how to contribute documentation, you will want to discuss on the docs mailing list: -

Re: Help with task: Websocket documentation

2017-03-21 Thread Mike Rumph
Sorry my link editor went crazy. Here are the same links a bit simpler: - http://httpd.apache.org/docs-project/ - http://httpd.apache.org/docs-project/#ml On 3/21/2017 7:16 AM, Mike Rumph wrote: Hello Mohit, Help with the project is always welcome. The Apache HTTP Server Documentation

Re: svn commit: r1786384 - /httpd/httpd/trunk/server/protocol.c

2017-03-10 Thread Mike Rumph
On 3/10/2017 8:42 AM, mru...@apache.org wrote: Author: mrumph Date: Fri Mar 10 16:42:26 2017 New Revision: 1786384 URL: http://svn.apache.org/viewvc?rev=1786384=rev Log: Fix some spelling errors in comments Modified: httpd/httpd/trunk/server/protocol.c Modified:

Re: Read scattered to gather send (was [too long]: httpd 2.4.25, mpm_event, ssl: segfaults)

2017-03-06 Thread Mike Rumph
Hello Yann, Just one question at this time: It appears that your changes to httpd will depend on new functions in APR-util which would require a new release of APR-util (and APR as well?). What is your plan for handling this dependency? Thanks, Mike Rumph On 3/3/2017 11:38 AM, Yann Ylavic

Tool to analyze and minimize loaded modules.

2017-05-15 Thread Mike Rumph
Hello all, I was wondering is there is any tool available that can analyze the directives in an httpd instance's configuration files and determine which loaded module are not being used. If not, maybe such a tool could be quite useful for reducing the memory footprint. Thanks, Mike Rumph

Re: Tool to analyze and minimize loaded modules.

2017-05-15 Thread Mike Rumph
: SetHandler server-info is listed in core.c and for me there is no configuration listed under mod_info. I cut this down from the full config to show relevant parts. Inline image 2 Inline image 1 - Y On Mon, May 15, 2017 at 12:12 PM, Mike Rumph <mike.ru...@oracle.com <mailto:mike.ru...@orac

Re: Tool to analyze and minimize loaded modules.

2017-05-18 Thread Mike Rumph
://www.netnea.com/cms/apache-tutorial-2_minimal-apache-configuration/ -> Step 9 Cheers, Christian On Mon, May 15, 2017 at 09:12:52AM -0700, Mike Rumph wrote: Hello all, I was wondering is there is any tool available that can analyze the directives in an httpd instance's configuration fi

Re: svn commit: r1805322 - /httpd/httpd/trunk/CHANGES

2017-08-17 Thread Mike Rumph
On 8/17/2017 11:06 AM, j...@apache.org wrote: +++ httpd/httpd/trunk/CHANGES [utf-8] Thu Aug 17 18:06:15 2017 @@ -16,6 +16,10 @@ Changes with Apache 2.5.0 *) mod_proxy: loadfactor parameter can now be a decimal number (eg: 1.25). [Jim Jagielski] + *) mod_watchdog/mod_proxy_hcheck:

Re: Trying to compile httpd trunk

2019-12-19 Thread Mike Rumph
I don't have a way to try this out at the moment, but if I remember correctly you may want to try ./buildconf inside the srclib/apr and srclib/apr-util directories to generate the make files. On Thu, Dec 19, 2019 at 10:08 AM Stéphane Blondon < stephane.blon...@gmail.com> wrote: > Le mar. 17 déc.

Add an entry in CHANGES file for Travis CI testing

2020-02-11 Thread Mike Rumph
With the talk of releasing 2.4.42, I was thinking that it might be a good idea to add some mention of the Travis CI testing that was added in this release. Perhaps something in the CHANGES file that gives a summary of the results achieved by this. This could include a list of the various platforms

Re: Use of [skip ci] in commit messages to avoid Travis builds

2020-02-10 Thread Mike Rumph
This thread mentions [skip ci] but the Travis issue mentions [ci skip] and [ci-skip]. Are all of these forms recognized? On Mon, Feb 10, 2020 at 4:23 AM Eric Covener wrote: > On Mon, Feb 10, 2020 at 1:44 AM Ruediger Pluem wrote: > > > > > > > > On 02/08/2020 12:01 PM, Luca Toscano wrote: > > >

Re: arm64 support for Travis CI testing

2020-01-10 Thread Mike Rumph
Okay Job #214 has the arm64 run back close to 11 minutes. On Fri, Jan 10, 2020 at 9:55 AM Mike Rumph wrote: > I'm interested in taking a look at this t/apache/expr_string.t testcase > failure. > For example, is it the testcase that is in error or is it the code that > it's test

Re: arm64 support for Travis CI testing

2020-01-08 Thread Mike Rumph
:27:33PM -0800, Mike Rumph wrote: > > I would like to add support for arm64 to httpd/trunk/.travis.yml. > > I would then devote some time to getting this support to work. > > Are there some steps I should take before adding this commit? > > That'd be great! If you are familia

Re: arm64 support for Travis CI testing

2020-01-10 Thread Mike Rumph
I'm interested in taking a look at this t/apache/expr_string.t testcase failure. For example, is it the testcase that is in error or is it the code that it's testing? Maybe this can be discussed in a separate thread since it is not exclusive to arm64. Has a thread been started on this already?

Re: arm64 support for Travis CI testing

2020-01-08 Thread Mike Rumph
Mike Rumph wrote: > Thanks Joe, > > Since I'm not adding a new feature other than enabling arm64 support, > I'll just add the commit directly so that others can contribute as well > and then revert it if arm64 causes too much noise. > > Mike > > On Wed, Jan 8, 2020

arm64 support for Travis CI testing

2020-01-07 Thread Mike Rumph
I would like to add support for arm64 to httpd/trunk/.travis.yml. I would then devote some time to getting this support to work. Are there some steps I should take before adding this commit? Thanks Mike Rumph

Re: svn commit: r1875881 - /httpd/httpd/trunk/modules/ssl/ssl_engine_io.c

2020-04-01 Thread Mike Rumph
I'm not very familiar with this code, so my questions might not make sense. But take a look at the following two code segments in ssl_io_filter_coalesce(): for (e = APR_BRIGADE_FIRST(bb); e != APR_BRIGADE_SENTINEL(bb) && !APR_BUCKET_IS_METADATA(e) &&

Re: Failed: apache/httpd#484 (2.4.42 - 5ad7f90)

2020-03-19 Thread Mike Rumph
Build #484 fails on test #484.13, Linux Ubuntu, Regenerate ap_expr +./buildconf --with-apr=/usr/bin/apr-1-config --with-regen-expr unknown option --with-regen-expr The command "./test/travis run_${TRAVIS_OS_NAME}.sh" exited with 1. On Thu, Mar 19, 2020 at 8:12 AM Travis CI wrote: > apache > >

Re: svn commit: r1880368 - /httpd/httpd/trunk/docs/manual/style/lang-targets.xml

2020-08-19 Thread Mike Rumph
Would it be possible to skip the SVN commit diff email? Like it is possible with [skip ci] to bypass the CI runs. On Wed, Aug 19, 2020 at 7:35 AM Joe Orton wrote: > On Wed, Aug 19, 2020 at 10:08:12AM +0200, Christophe JAILLET wrote: > > Le 19/08/2020 à 09:47, Joe Orton a écrit : > > > Stupid