Re: [fossil-users] fossil timeline -W num -n num

2013-11-13 Thread j. van den hoff 

On Mon, 11 Nov 2013 20:35:06 +0100, Jan Nijtmans 
wrote:


2013/11/11 j. van den hoff :

well, if you ask me, I then would prefer the latter solution since
it minimizes the number of cases where the line actually is visible.


Agreed. Done in:



that would have been nice but your change has been "silently" (or so it  
seems) undone in rev.

ab4d4dacf7. could someone please explain
why the ` === line/entry limit reached ===' lines are that important? I
personally just find them distracting.

and the solution in 8e01c2257d still would have sufficed to differentiate
the relevant cases -- at least that
was my understanding of your explanations.



Thanks for your suggestion!

Regards,
 Jan Nijtmans



--
Using Opera's revolutionary email client: http://www.opera.com/mail/
___
fossil-users mailing list
[email protected]
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] fossil timeline -W num -n num

2013-11-11 Thread j. van den hoff 
On Mon, 11 Nov 2013 16:55:31 +0100, Jan Nijtmans   
wrote:



2013/11/11 j. van den hoff :
it has variable content (either "=== line limit (20) reached ===" (if  
`n 20'
is specified) or "=== entry limit (20) reached ===" (if `n` is not  
specified
at all) or missing altogether if the full timeline is displayed). the  
`line'

vs. `entry' difference presumably is unintentional (is it?)


For me it was fully intentional! For the "trunk" timeline it's not
that useful to know that the timeline is not finished, but for other
timelines it could be useful to know whether the complete
timeline is printed or not.


but I probably
would either always display that line or actually remove it altogether.  
I
would prefer the latter since the line anyway does not tell me anything  
I do

not know in the first place: I am either using the default (and I should
know from the help page that this is 20)

Many people don't read the help pages, unfortunately.

or I just have specified -n
explicitely and don't need that reminder.

It's not meant as a reminder. If you specify "-n 20" and there are
less than 20 entries, there will be no such last line.

An alternative could be to do the reverse: Output a last line like:
=== timeline complete ===
when there are no more entries. Would you prefer that?
However, I would like to be able to tell the difference, whether
the loop stopped because the limit was reached or there
are no more entries any more.


well, if you ask me, I then would prefer the latter solution since
it minimizes the number of cases where the line actually is visible.

and maybe phrase it as something like

+++ end of timeline reached +++

(I would avoid the `===' delimiters since ` === .* ===' might be used as  
(admittedly not really specific) regexp

to identify dates by some postprocessing scripts.)



Anyway, I'm glad you like the feature! Thanks!


sure do.

joerg



Regards,
 Jan Nijtmans
___
fossil-users mailing list
[email protected]
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users



--
Using Opera's revolutionary email client: http://www.opera.com/mail/
___
fossil-users mailing list
[email protected]
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] fossil timeline -W num -n num

2013-11-11 Thread Jan Nijtmans 
2013/11/11 j. van den hoff :
> it has variable content (either "=== line limit (20) reached ===" (if `n 20'
> is specified) or "=== entry limit (20) reached ===" (if `n` is not specified
> at all) or missing altogether if the full timeline is displayed). the `line'
> vs. `entry' difference presumably is unintentional (is it?)

For me it was fully intentional! For the "trunk" timeline it's not
that useful to know that the timeline is not finished, but for other
timelines it could be useful to know whether the complete
timeline is printed or not.

> but I probably
> would either always display that line or actually remove it altogether. I
> would prefer the latter since the line anyway does not tell me anything I do
> not know in the first place: I am either using the default (and I should
> know from the help page that this is 20)
Many people don't read the help pages, unfortunately.
> or I just have specified -n
> explicitely and don't need that reminder.
It's not meant as a reminder. If you specify "-n 20" and there are
less than 20 entries, there will be no such last line.

An alternative could be to do the reverse: Output a last line like:
=== timeline complete ===
when there are no more entries. Would you prefer that?
However, I would like to be able to tell the difference, whether
the loop stopped because the limit was reached or there
are no more entries any more.

Anyway, I'm glad you like the feature! Thanks!

Regards,
 Jan Nijtmans
___
fossil-users mailing list
[email protected]
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

[fossil-users] fossil timeline -W num -n num

2013-11-11 Thread j. van den hoff 
a bit late I'd like to thank jan nijtmans for recently improving the  
`timeline' command w.r.t. to `-n' behavior and introduction of `-W' (both  
of which fixes/changes were long overdue in my view, really...).


I see only the following very minor issues:

1.
the newly introduced trailing comment line can confuse scripts processing  
the `timeline' output since
it has variable content (either "=== line limit (20) reached ===" (if `n  
20' is specified) or "=== entry limit (20) reached ===" (if `n` is not  
specified at all) or missing altogether if the full timeline is  
displayed). the `line' vs. `entry' difference presumably is unintentional  
(is it?) but I probably would either always display that line or actually  
remove it altogether. I would prefer the latter since the line anyway does  
not tell me anything I do not know in the first place: I am either using  
the default (and I should know from the help page that this is 20) or I  
just have specified -n explicitely and don't need that reminder.


2.
`fossil help timeline' is a bit to terse regarding `-W', specifically it  
should be mentioned that `-W 0' puts the ci comment on a single line (no  
width limit).


--
Using Opera's revolutionary email client: http://www.opera.com/mail/
___
fossil-users mailing list
[email protected]
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users