[RFC master] Implement rbd disk template

2012-01-06 Thread Constantinos Venetsanopoulos
limitations. Use of this template requires the rbd kernel driver and rbd tool on all VM-capable nodes, as well as an operational RADOS cluster, accessible by them. Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- Hello, please find attached our patch for Ganeti's master. We have tested

[RFC master] Implement rbd disk template

2012-01-06 Thread Constantinos Venetsanopoulos
limitations. Use of this template requires the rbd kernel driver and rbd tool on all VM-capable nodes, as well as an operational RADOS cluster, accessible by them. Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- Hello, please find attached our patch for Ganeti's master. We have tested

[PATCH master] Fix acquisition of node lock in LUInstanceGrowDisk

2012-01-11 Thread Constantinos Venetsanopoulos
Ensure node level locks are recalculated properly in LUInstanceGrowDisk. Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- Hello, LUInstanceGrowDisk seems to not recalculate locks properly, leading to this (testing with -t plain): # gnt-instance grow-disk testgrow 0 1g Failure

Re: [RFC master] Implement rbd disk template

2012-01-11 Thread Constantinos Venetsanopoulos
On 01/10/2012 06:17 PM, Andrea Spadaccini wrote: Hello, Introduce the rbd disk template, which handles provisioning and management of instance disks as block devices mapped to rbd volumes on a RADOS cluster. Thanks for sending the patch. After fighting with a couple of ceph/rbd bugs, today I

[PATCH master] Implement rbd disk template

2012-01-12 Thread Constantinos Venetsanopoulos
limitations. Use of this template requires the rbd kernel driver and rbd tool on all VM-capable nodes, as well as an operational RADOS cluster, accessible by them. Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- Hello Andrea, I'm resending the rbd patch, after fixing all `make lint' errors

Re: [RFC master] Implement rbd disk template

2012-01-12 Thread Constantinos Venetsanopoulos
is: 4b97458c42ee27c12def1b162437b583389711ae Hope this helps, Thanks, Constantinos On Wed, Jan 11, 2012 at 05:35:45PM +0200, Constantinos Venetsanopoulos wrote: On 01/10/2012 06:17 PM, Andrea Spadaccini wrote: Hello, Introduce the rbd disk template, which handles provisioning and management of instance disks as block

Re: [PATCH master] Implement rbd disk template

2012-01-17 Thread Constantinos Venetsanopoulos
Hello Andrea, On Fri, Jan 13, 2012 at 01:25:54PM +, Andrea Spadaccini wrote: Hello Constantinos, Thanks for resending and fixing the make lint errors. I tried your patch and it works fine on my test cluster. The functionality implemented in the patch looks good. I think that for

[PATCH master] Implement rbd disk template

2012-01-17 Thread Constantinos Venetsanopoulos
limitations. Use of this template requires the rbd kernel driver and rbd tool on all VM-capable nodes, as well as an operational RADOS cluster, accessible by them. Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- Hello team, I'm resending the patch, hopefully addressing all issues Andrea

[PATCH master] Implement rbd disk template

2012-01-19 Thread Constantinos Venetsanopoulos
limitations. Use of this template requires the rbd kernel driver and rbd tool on all VM-capable nodes, as well as an operational RADOS cluster, accessible by them. Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- Hello team, Thanks for the many review rounds. I refactored the mapping/unmapping

Re: [PATCH master] Implement rbd disk template

2012-01-20 Thread Constantinos Venetsanopoulos
On Fri, Jan 20, 2012 at 02:07:14PM -0200, Michael Hanselmann wrote: Hi Constantinos Thanks for the removal of grep. Some style comments: Am 19. Januar 2012 14:01 schrieb Constantinos Venetsanopoulos c...@grnet.gr: --- a/lib/bdev.py +++ b/lib/bdev.py +  def _MapVolumeToBlockdev(self

[PATCH master] Implement rbd disk template

2012-01-23 Thread Constantinos Venetsanopoulos
limitations. Use of this template requires the rbd kernel driver and rbd tool on all VM-capable nodes, as well as an operational RADOS cluster, accessible by them. Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- Hello, I'm resending the patch. I applied all

Re: [PATCH master] Implement rbd disk template

2012-01-23 Thread Constantinos Venetsanopoulos
On Mon, Jan 23, 2012 at 03:51:26PM -0200, Michael Hanselmann wrote: Am 23. Januar 2012 15:20 schrieb Michael Hanselmann han...@google.com: Am 23. Januar 2012 10:27 schrieb Constantinos Venetsanopoulos c...@grnet.gr: +    matched_lines = \ +      filter(lambda l: len(l) == allfields and l

Re: [PATCH master] rbd disk template documentation and manpages

2012-02-10 Thread Constantinos Venetsanopoulos
On 02/10/2012 05:13 PM, Iustin Pop wrote: On Fri, Feb 10, 2012 at 12:29:13PM +0200, Stratos Psomadakis wrote: Add documentation and modify manpages for the RBD disk template. Signed-off-by: Constantinos Venetsanopoulosc...@grnet.gr Signed-off-by: Stratos Psomadakispso...@grnet.gr --- Hi,

hslogger for squeeze doesn't include System.Log.Formatter, so master's compilation fails

2012-03-21 Thread Constantinos Venetsanopoulos
Hello team, I was trying to compile the current master branch today and got: htools/Ganeti/Logging.hs:49:7: Could not find module `System.Log.Formatter': Use -v to see a list of the files searched for. make[2]: *** [htools/hconfd] Error 1 After a bit of searching, I found that the

Re: hslogger for squeeze doesn't include System.Log.Formatter, so master's compilation fails

2012-03-21 Thread Constantinos Venetsanopoulos
On 03/21/2012 01:31 PM, Iustin Pop wrote: On Wed, Mar 21, 2012 at 01:21:46PM +0200, Constantinos Venetsanopoulos wrote: Hello team, I was trying to compile the current master branch today and got: htools/Ganeti/Logging.hs:49:7: Could not find module `System.Log.Formatter': Use -v

Re: hslogger for squeeze doesn't include System.Log.Formatter, so master's compilation fails

2012-03-29 Thread Constantinos Venetsanopoulos
On 03/29/2012 05:07 PM, Iustin Pop wrote: On Wed, Mar 21, 2012 at 01:21:46PM +0200, Constantinos Venetsanopoulos wrote: Hello team, I was trying to compile the current master branch today and got: htools/Ganeti/Logging.hs:49:7: Could not find module `System.Log.Formatter': Use -v

[PATCH master 5/5] Update the shared storage design document

2012-04-04 Thread Constantinos Venetsanopoulos
Update the shared storage design document to reflect the current changes, after the implementation of the ExtStorage interface. Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- doc/design-shared-storage.rst | 204 ++-- 1 files changed, 112

[PATCH master 0/5] Introduce the External Storage Interface

2012-04-04 Thread Constantinos Venetsanopoulos
pool management and also diagnose other types of templates too. I'm looking forward to your comments, Constantinos Constantinos Venetsanopoulos (5): Implement the External Storage Interface Multiple ExtStorage Providers and ext-params Add the gnt-storage client Add

[PATCH master 4/5] Add external storage interface related man pages

2012-04-04 Thread Constantinos Venetsanopoulos
* ganeti-extstorage-interface man page * gnt-storage man page Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- .gitignore |1 + Makefile.am |2 + man/footer.rst | 11 +- man/ganeti-extstorage

[PATCH master 1/5] Implement the External Storage Interface

2012-04-04 Thread Constantinos Venetsanopoulos
logical id is the tuple ('ext', UUID.ext.diskX), where UUID is generated as in disk template `plain' and X is the disk's index. Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- Makefile.am |1 + configure.ac | 12 ++ lib/bdev.py | 304

[PATCH master 2/5] Multiple ExtStorage Providers and ext-params

2012-04-04 Thread Constantinos Venetsanopoulos
Providers for each disk and passing different ext-params to them: -t ext --disk=0:size=2G,provider=sample_provider1,param1=value1 --disk=1:size=3G,provider=sample_provider2,param2=value2 Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- lib/bdev.py | 68

[PATCH master 3/5] Add the gnt-storage client

2012-04-04 Thread Constantinos Venetsanopoulos
be extended to diagnose other storage types supported by Ganeti, such as lvm, drbd (INT_MIRROR) or rbd (EXT_MIRROR). Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- Makefile.am |6 +- autotools/build-bash-completion |4 + lib/backend.py | 45

Re: [PATCH master 0/5] Introduce the External Storage Interface

2012-04-04 Thread Constantinos Venetsanopoulos
On 04/04/2012 07:39 PM, Iustin Pop wrote: On Wed, Apr 04, 2012 at 07:28:25PM +0300, Constantinos Venetsanopoulos wrote: Hello team, Until now, Ganeti can handle shared storage in two ways: - with the `drbd' disk template (internally) - with the `blockdev' and `sharedfile' template

Release date of 2.6.0beta1: 23 Mar 2011 ?

2012-05-24 Thread Constantinos Venetsanopoulos
Hello team, Should the release date of 2.6.0beta1 be: Wed, 23 Mar 2011 ? Shouldn't it be Wed, 23 May 2012 in the NEWS file? Am I missing something here? :) Constantinos

Re: drbd metavg parameter not inherited by vg-name

2012-06-12 Thread Constantinos Venetsanopoulos
On 06/12/2012 01:21 PM, Iustin Pop wrote: On Tue, Jun 12, 2012 at 01:13:11PM +0300, Constantinos Venetsanopoulos wrote: Hello team, I've bumped into something which I'm not sure is a bug or expected behaviour. However, it seems a bit strange and was first introduced after the implementation

Disks are not getting annotated before passed to bdev

2012-06-25 Thread Constantinos Venetsanopoulos
Hello team, I'm testing Ganeti 2.6.0beta2 and seem to have hit a problem: Disk parameters are not getting annotated before several rpc calls inside cmdlib, which causes Ganeti to break in templates that need to find disk parameters during their Attach or Remove methods. This does not cause

Re: Disks are not getting annotated before passed to bdev

2012-06-26 Thread Constantinos Venetsanopoulos
Hello René, comments inline: On 06/26/2012 12:22 PM, René Nussbaumer wrote: Hello Constantinos, On Mon, Jun 25, 2012 at 4:25 PM, Constantinos Venetsanopoulos c...@grnet.gr wrote: Hello team, I'm testing Ganeti 2.6.0beta2 and seem to have hit a problem: Disk parameters are not getting

Re: Disks are not getting annotated before passed to bdev

2012-06-26 Thread Constantinos Venetsanopoulos
On 06/26/2012 03:21 PM, René Nussbaumer wrote: Hi Constantinos, On Tue, Jun 26, 2012 at 12:17 PM, Constantinos Venetsanopoulos c...@grnet.gr wrote: On 06/26/2012 12:22 PM, René Nussbaumer wrote: Hello Constantinos, On Mon, Jun 25, 2012 at 4:25 PM, Constantinos Venetsanopoulos c...@grnet.gr

Re: Disks are not getting annotated before passed to bdev

2012-06-26 Thread Constantinos Venetsanopoulos
On 06/26/2012 04:27 PM, René Nussbaumer wrote: On Tue, Jun 26, 2012 at 3:23 PM, Constantinos Venetsanopoulos c...@grnet.gr wrote: On 06/26/2012 03:21 PM, René Nussbaumer wrote: Hi Constantinos, On Tue, Jun 26, 2012 at 12:17 PM, Constantinos Venetsanopoulos c...@grnet.gr wrote: On 06/26/2012

[PATCH stable-2.6] Allow param `modify' during gnt-instance modify

2012-06-27 Thread Constantinos Venetsanopoulos
instance2 This patch fixes the bug, by allowing `modify' to be passed as a parameter (as happens with `add' and `remove'), as long as it is not done alongside `add' or `remove'. If so, it is treated in the same way as if none of modify/add/remove is passed -- modify. Signed-off-by: Constantinos

Re: [PATCH stable-2.6] Allow param `modify' during gnt-instance modify

2012-06-28 Thread Constantinos Venetsanopoulos
LGTM Thanks, Constantinos On 6/28/2012 2:09 PM, René Nussbaumer wrote: Hi Constantinos, On Wed, Jun 27, 2012 at 5:27 PM, Constantinos Venetsanopoulos c...@grnet.gr wrote: With the new gnt-instance modify syntax for addition and removal of disks/NICs on arbitrary indexes, we hit an assertion

Re: Faild to start instance with RBD disk

2012-08-14 Thread Constantinos Venetsanopoulos
On 8/14/2012 4:53 PM, Damien Churchill wrote: On 13 August 2012 13:39, Ansgar Jazdzewski a.jazdzew...@googlemail.com wrote: Hi, I like to build an instance on a RBD Storage with Kernel inside the VM So i did, root@node01# gnt-instance add -t rbd -s 30G --net 0:link=br-untagged -B

[PATCH stable-2.6] Fix computation of disk sizes in _ComputeDiskSize

2012-08-22 Thread Constantinos Venetsanopoulos
when using adoption with 'plain' and 'blockdev' template and will be addressed in another commit. Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- lib/cmdlib.py |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/cmdlib.py b/lib/cmdlib.py index 1f80c6c

Re: hail returns FailDisk, due to instance's disk_space_total = 0

2012-08-22 Thread Constantinos Venetsanopoulos
hail to fail with FailDisk. Thoughts on this one? How do you think we could fix that? Regards, cven On 08/21/2012 06:06 PM, Iustin Pop wrote: On Mon, Aug 20, 2012 at 02:15:53PM +0300, Constantinos Venetsanopoulos wrote: Hello team, just stumbled upon the following bug, due to the new IPolicy

Re: [PATCH stable-2.6] Fix computation of disk sizes in _ComputeDiskSize

2012-08-22 Thread Constantinos Venetsanopoulos
On 08/22/2012 02:24 PM, Iustin Pop wrote: On Wed, Aug 22, 2012 at 02:16:48PM +0300, Constantinos Venetsanopoulos wrote: Currently, hail fails with FailDisk when trying to add an instance of type: 'file', 'sharedfile' and 'rbd'. This is due to a 0 or None value in the corresponding dict inside

Re: [PATCH stable-2.6] Fix computation of disk sizes in _ComputeDiskSize

2012-08-22 Thread Constantinos Venetsanopoulos
On 08/22/2012 02:46 PM, Iustin Pop wrote: On Wed, Aug 22, 2012 at 02:30:00PM +0300, Constantinos Venetsanopoulos wrote: On 08/22/2012 02:24 PM, Iustin Pop wrote: On Wed, Aug 22, 2012 at 02:16:48PM +0300, Constantinos Venetsanopoulos wrote: Currently, hail fails with FailDisk when trying

Re: hail returns FailDisk, due to instance's disk_space_total = 0

2012-08-22 Thread Constantinos Venetsanopoulos
On 08/22/2012 03:03 PM, Iustin Pop wrote: On Wed, Aug 22, 2012 at 02:25:42PM +0300, Constantinos Venetsanopoulos wrote: Hello iustin, I just sent a patch that fixes the problem with FailDisk for 'sharedfile' and 'rbd'. Plus, I discovered that also 'file' made hail fail differently, because

Re: Faild to start instance with RBD disk

2012-08-23 Thread Constantinos Venetsanopoulos
On 08/16/2012 01:22 PM, Iustin Pop wrote: On Thu, Aug 16, 2012 at 11:07:53AM +0100, Damien Churchill wrote: On 16 August 2012 10:56, Iustin Pop iu...@k1024.org wrote: Thanks! This will help fixing, for sure. From what I've gathered, there's an instance of the RADOSBlockDevice class being

Re: Faild to start instance with RBD disk

2012-08-23 Thread Constantinos Venetsanopoulos
On 08/23/2012 01:07 PM, Iustin Pop wrote: On Thu, Aug 23, 2012 at 12:34:12PM +0300, Constantinos Venetsanopoulos wrote: On 08/16/2012 01:22 PM, Iustin Pop wrote: On Thu, Aug 16, 2012 at 11:07:53AM +0100, Damien Churchill wrote: On 16 August 2012 10:56, Iustin Pop iu...@k1024.org wrote

hail algorithm clarification

2012-08-24 Thread Constantinos Venetsanopoulos
Hello team, I seem to not have actually understood how hail's algorithm works, and I would like some insight if possible. I have a Ganeti cluster with 13 VM-capable nodes running the latest Ganeti 2.6.0 stable. I see that when adding instances of type 'plain' or 'rbd' all instances go to the

Re: hail algorithm clarification

2012-08-24 Thread Constantinos Venetsanopoulos
On 08/24/2012 05:39 PM, Iustin Pop wrote: On Fri, Aug 24, 2012 at 04:33:21PM +0300, Constantinos Venetsanopoulos wrote: Hello team, I seem to not have actually understood how hail's algorithm works, and I would like some insight if possible. I have a Ganeti cluster with 13 VM-capable nodes

Re: hail algorithm clarification

2012-08-24 Thread Constantinos Venetsanopoulos
On 08/24/2012 06:18 PM, Iustin Pop wrote: On Fri, Aug 24, 2012 at 06:06:42PM +0300, Constantinos Venetsanopoulos wrote: On 08/24/2012 05:39 PM, Iustin Pop wrote: On Fri, Aug 24, 2012 at 04:33:21PM +0300, Constantinos Venetsanopoulos wrote: Hello team, I seem to not have actually understood

Re: hail algorithm clarification

2012-09-05 Thread Constantinos Venetsanopoulos
Hello iustin, any news on that? I assume you are quite busy these days.. thanks, Constantinos On 08/24/2012 06:26 PM, Constantinos Venetsanopoulos wrote: On 08/24/2012 06:18 PM, Iustin Pop wrote: On Fri, Aug 24, 2012 at 06:06:42PM +0300, Constantinos Venetsanopoulos wrote: On 08/24/2012 05

Re: hail algorithm clarification

2012-09-06 Thread Constantinos Venetsanopoulos
On 09/05/2012 06:09 PM, Iustin Pop wrote: On Wed, Sep 05, 2012 at 12:54:30PM +0300, Constantinos Venetsanopoulos wrote: Hello iustin, any news on that? I assume you are quite busy these days.. Not so much busy as overloaded with many small things, so I forgot about this. Looking now

Re: hail algorithm clarification

2012-09-07 Thread Constantinos Venetsanopoulos
On 09/07/2012 04:02 AM, Iustin Pop wrote: On Thu, Sep 06, 2012 at 02:07:50PM +0300, Constantinos Venetsanopoulos wrote: On 09/05/2012 06:09 PM, Iustin Pop wrote: On Wed, Sep 05, 2012 at 12:54:30PM +0300, Constantinos Venetsanopoulos wrote: Hello iustin, any news on that? I assume you

[RFC master] Initial Storage Pools design doc

2012-09-10 Thread Constantinos Venetsanopoulos
Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- Hello team, This is a design doc I wrote a few months ago and was hoping to submit after the merge of the ExtStorage patch set. However, given the recent discussions on: * Reporting of free storage disk space * Node slicing

Re: Faild to start instance with RBD disk

2012-09-11 Thread Constantinos Venetsanopoulos
On 08/23/2012 02:07 PM, Constantinos Venetsanopoulos wrote: On 08/23/2012 01:07 PM, Iustin Pop wrote: On Thu, Aug 23, 2012 at 12:34:12PM +0300, Constantinos Venetsanopoulos wrote: On 08/16/2012 01:22 PM, Iustin Pop wrote: On Thu, Aug 16, 2012 at 11:07:53AM +0100, Damien Churchill wrote

[PATCH stable-2.6] Annotate disk params on instance_start

2012-09-11 Thread Constantinos Venetsanopoulos
We call _GatherAndLinkBlockDevs during the process, which in turn calls _RecursiveFindBD. This needs disk parameters to work. Probably, this is not the cleanest way to solve the problem. See also commit b8291e0. This was reported by Ansgar and Damien. Signed-off-by: Constantinos Venetsanopoulos

locking error during instance failover

2012-09-11 Thread Constantinos Venetsanopoulos
Hello team, running the latest stable-2.6 branch, I get the following error when trying to failover an RBD instance: # gnt-instance failover 3 Failover will happen to image 3. This requires a shutdown of the instance. Continue? y/[n]/?: y Failure: command execution error: 'NoneType' object is

[PATCH stable-2.6] Annotate disk params on instance_start

2012-09-12 Thread Constantinos Venetsanopoulos
We call _GatherAndLinkBlockDevs during the process, which in turn calls _RecursiveFindBD. This needs disk parameters to work. See also commit b8291e0. This was reported by Ansgar and Damien. Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- Hi Michael, Is this what you meant

[PATCH stable-2.6] _InstDictOspDp: dict is already built in _InstDict

2012-09-12 Thread Constantinos Venetsanopoulos
Rollback _InstDictOspDp, since the inst dict is built in one place; inside _InstDict. There, the disks are getting correctly annotated. Relative commits: 5fce6a8, b8291e0 Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- lib/rpc.py |4 +--- 1 files changed, 1 insertions(+), 3

Re: [PATCH stable-2.6] _InstDictOspDp: dict is already built in _InstDict

2012-09-12 Thread Constantinos Venetsanopoulos
On 09/12/2012 03:25 PM, Michael Hanselmann wrote: 2012/9/12 Constantinos Venetsanopoulos c...@grnet.gr: Rollback _InstDictOspDp, since the inst dict is built in one place; inside _InstDict. There, the disks are getting correctly annotated. Relative commits: 5fce6a8, b8291e0 Not only

Re: [PATCH stable-2.6] rpc: Remove duplicated logic, fix unittests

2012-09-12 Thread Constantinos Venetsanopoulos
On 09/12/2012 03:42 PM, Michael Hanselmann wrote: Commit 5fce6a89 changed RpcRunner._InstDict to add the disk parameters on all encoded instances. It didn't remove a special case in “_InstDictOspDp”. Update and fix unittests as well. --- lib/rpc.py |4 +---

Re: Faild to start instance with RBD disk

2012-09-13 Thread Constantinos Venetsanopoulos
at least for stable is just annotating correctly. Is that the patch you just sent, right? Yes Thanks, Constantinos Thanks, Guido On Tue, Sep 11, 2012 at 11:39 AM, Constantinos Venetsanopoulos c...@grnet.gr wrote: On 08/23/2012 02:07 PM, Constantinos Venetsanopoulos wrote: On 08/23/2012 01:07

Re: [RFC master] Initial Storage Pools design doc

2012-09-13 Thread Constantinos Venetsanopoulos
On 09/11/2012 07:05 PM, Guido Trotter wrote: On Mon, Sep 10, 2012 at 06:47:41PM +0300, Constantinos Venetsanopoulos wrote: Hi Costantinos, Thanks for sharing this design. Hello team, This is a design doc I wrote a few months ago and was hoping to submit after the merge of the ExtStorage

Re: [RFC master] Initial Storage Pools design doc

2012-09-17 Thread Constantinos Venetsanopoulos
you can test migrations too). Would one of these options suffice? Thanks, Constantinos P.S: I hadn't had the chance to read all your comments on the design doc yet; I'll reply there, as soon as possible. Thanks, Guido On Thu, Sep 13, 2012 at 4:24 PM, Constantinos Venetsanopoulos c

[PATCH master 1/7] Update the shared storage design document

2012-09-26 Thread Constantinos Venetsanopoulos
Update the shared storage design document to reflect the current changes, after the implementation of the ExtStorage interface. Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- doc/design-shared-storage.rst | 204 ++-- 1 files changed, 112

[PATCH master] Implementation of the ExtStorage Interface

2012-09-26 Thread Constantinos Venetsanopoulos
Hello team, This is the ExtStorage Interface patch series rebased on top of master branch's commit 0e1e0b6. It passes all current lint/unit tests. The first commit (design doc) has been already reviewed by Iustin and the only question was about separate providers between disks, which I think has

[PATCH master 5/7] Add the gnt-storage client

2012-09-26 Thread Constantinos Venetsanopoulos
be extended to diagnose other storage types supported by Ganeti, such as lvm, drbd (INT_MIRROR) or rbd (EXT_MIRROR). Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- Makefile.am |6 +- autotools/build-bash-completion |4 + lib/backend.py | 45

[PATCH master 4/7] Add --allow-arbit-params to 'gnt-instance modify'

2012-09-26 Thread Constantinos Venetsanopoulos
in this commit. It serves as a general introduction of the 'ext' template in gnt-instance modify. Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr Conflicts: lib/cmdlib.py Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- lib/cli.py |8 + lib

[PATCH master 2/7] Implement the External Storage Interface

2012-09-26 Thread Constantinos Venetsanopoulos
logical id is the tuple ('ext', UUID.ext.diskX), where UUID is generated as in disk template `plain' and X is the disk's index. Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- Makefile.am |1 + configure.ac | 12 ++ lib/bdev.py | 318

The 'shared-filer' ExtStorage provider

2012-09-26 Thread Constantinos Venetsanopoulos
Hello team, I'm attaching an ExtStorage provider called shared-filer which can be used with the ExtStorage interface. It's purpose is to provide a way to test the ExtStorage interface, without having to write custom scripts for a specific NAS. It can also act as a template for those wanting to

Re: [RFC master] Initial Storage Pools design doc

2012-09-26 Thread Constantinos Venetsanopoulos
, and if so can you document it? It would be great if we could run a buildbot or test it with just a normal linux machine even in emulation mode. :) Thanks, Guido On Thu, Sep 13, 2012 at 4:24 PM, Constantinos Venetsanopoulos c...@grnet.gr wrote: Hello Guido, Great to know it actually helped. I just

Re: [RFC master] Initial Storage Pools design doc

2012-09-26 Thread Constantinos Venetsanopoulos
On 09/18/2012 03:14 PM, Iustin Pop wrote: On Mon, Sep 17, 2012 at 02:01:50PM +0300, Constantinos Venetsanopoulos wrote: Hi Guido, Make sure please that it passes all unit tests, qa (adding unit tests and qa for changed code), and check how it works with the haskell query system in master

Re: [PATCH master 1/7] Update the shared storage design document

2012-09-27 Thread Constantinos Venetsanopoulos
On 09/26/2012 07:21 PM, Iustin Pop wrote: On Wed, Sep 26, 2012 at 05:38:17PM +0300, Constantinos Venetsanopoulos wrote: Update the shared storage design document to reflect the current changes, after the implementation of the ExtStorage interface. Signed-off-by: Constantinos Venetsanopoulos c

Re: [PATCH master 1/7] Update the shared storage design document

2012-09-27 Thread Constantinos Venetsanopoulos
On 09/27/2012 02:02 PM, Iustin Pop wrote: On Thu, Sep 27, 2012 at 12:37:41PM +0300, Constantinos Venetsanopoulos wrote: On 09/26/2012 07:21 PM, Iustin Pop wrote: On Wed, Sep 26, 2012 at 05:38:17PM +0300, Constantinos Venetsanopoulos wrote: Update the shared storage design document to reflect

Re: [PATCH master 2/7] Implement the External Storage Interface

2012-09-27 Thread Constantinos Venetsanopoulos
On 09/27/2012 04:17 PM, Iustin Pop wrote: On Wed, Sep 26, 2012 at 05:38:18PM +0300, Constantinos Venetsanopoulos wrote: With this commit we introduce the External Storage Interface to Ganeti, abbreviated: ExtStorage Interface. The ExtStorage Interface provides Ganeti with the ability

Re: [PATCH master 4/7] Add --allow-arbit-params to 'gnt-instance modify'

2012-09-27 Thread Constantinos Venetsanopoulos
On 09/27/2012 04:26 PM, Iustin Pop wrote: On Wed, Sep 26, 2012 at 05:38:20PM +0300, Constantinos Venetsanopoulos wrote: The option is added to allow us the passing of arbitrary ext-params during disk addition (gnt-instance modify --disk add: ...), same as we do during instance add. The option

Re: [PATCH master 2/7] Implement the External Storage Interface

2012-10-09 Thread Constantinos Venetsanopoulos
On 10/08/2012 04:55 PM, Iustin Pop wrote: On Thu, Sep 27, 2012 at 05:43:56PM +0300, Constantinos Venetsanopoulos wrote: On 09/27/2012 04:17 PM, Iustin Pop wrote: On Wed, Sep 26, 2012 at 05:38:18PM +0300, Constantinos Venetsanopoulos wrote: With this commit we introduce the External Storage

Re: [PATCH master 2/7] Implement the External Storage Interface

2012-10-10 Thread Constantinos Venetsanopoulos
On 10/09/2012 07:10 PM, Iustin Pop wrote: On Tue, Oct 09, 2012 at 06:59:55PM +0300, Constantinos Venetsanopoulos wrote: On 10/08/2012 04:55 PM, Iustin Pop wrote: On Thu, Sep 27, 2012 at 05:43:56PM +0300, Constantinos Venetsanopoulos wrote: On 09/27/2012 04:17 PM, Iustin Pop wrote: On Wed

Re: [PATCH master 2/7] Implement the External Storage Interface

2012-10-15 Thread Constantinos Venetsanopoulos
diff --git a/lib/bdev.py b/lib/bdev.py index b0ed7c0..7a27b7b 100644 --- a/lib/bdev.py +++ b/lib/bdev.py @@ -2797,8 +2797,24 @@ class ExtStorageDevice(BlockDev): _ExtStorageAction(constants.ES_ACTION_GROW, self.unique_id, str(self.size), grow=str(new_size)) + def

Re: [PATCH master 2/7] Implement the External Storage Interface

2012-10-15 Thread Constantinos Venetsanopoulos
/2012 12:15 PM, Iustin Pop wrote: On Wed, Oct 10, 2012 at 12:07:31PM +0300, Constantinos Venetsanopoulos wrote: On 10/09/2012 07:10 PM, Iustin Pop wrote: On Tue, Oct 09, 2012 at 06:59:55PM +0300, Constantinos Venetsanopoulos wrote: On 10/08/2012 04:55 PM, Iustin Pop wrote: On Thu, Sep 27, 2012

Re: [PATCH master 2/7] Implement the External Storage Interface

2012-10-15 Thread Constantinos Venetsanopoulos
On 10/15/2012 6:58 PM, Constantinos Venetsanopoulos wrote: Hi iustin, I just sent you the interdiff. After rebasing, there is a trivial conflict when applying the next commit (2/7). I can resend it too, if you want. I meant '3/7' here: Multiple ExtStorage providers cven Finally, I'll

Re: [PATCH master 2/7] Implement the External Storage Interface

2012-10-16 Thread Constantinos Venetsanopoulos
On 10/16/2012 03:45 PM, Iustin Pop wrote: On Mon, Oct 15, 2012 at 08:18:33PM +0300, Constantinos Venetsanopoulos wrote: On 10/15/2012 6:58 PM, Constantinos Venetsanopoulos wrote: Hi iustin, I just sent you the interdiff. After rebasing, there is a trivial conflict when applying the next

Re: DRBD migration error

2012-11-15 Thread Constantinos Venetsanopoulos
On 11/15/2012 06:52 PM, Iustin Pop wrote: On Thu, Nov 15, 2012 at 06:49:34PM +0200, Christos Stavrakakis wrote: Hi, I tried to migrate an instance and I got the following error: # gnt-job info 504936 ... Opcodes: OP_INSTANCE_MIGRATE Status: error Processing start:

Fwd: [synnefo-devel] Re: rbd tool changed format? (breaks compatibility)

2012-11-21 Thread Constantinos Venetsanopoulos
, 19 Nov 2012 12:20:01 +0200 From: Constantinos Venetsanopoulos c...@grnet.gr Organization: Greek Research and Technology Network To: Josh Durgin josh.dur...@inktank.com CC: ceph-de...@vger.kernel.org, synnefo-de...@googlegroups.com On 11/16/2012 07:14 PM, Josh Durgin wrote: On 11/16

[PATCH master] Remove checks wrt IDISK_PARAMS from OpCode level

2012-12-04 Thread Constantinos Venetsanopoulos
CheckArguments). Currently, the check wrt to IDISK_PARAMS already happens in all related LUs (InstanceSetParams, InstanceCreate, InstanceRecreateDisks), with the use of ForceDictType(), so there is no need for additional checking code. Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- Hello team

Re: [PATCH master] Remove checks wrt IDISK_PARAMS from OpCode level

2012-12-12 Thread Constantinos Venetsanopoulos
Hello team, any comments on this one? Thanks, Constantinos On 12/04/2012 01:50 PM, Constantinos Venetsanopoulos wrote: Change the --disks option validation, to just check the format of the dict and do not check whether the keys are included in the IDISK_PARAMS constant at OpCode level

Re: [PATCH master] Remove checks wrt IDISK_PARAMS from OpCode level

2012-12-12 Thread Constantinos Venetsanopoulos
On 12/12/2012 01:00 PM, Iustin Pop wrote: On Tue, Dec 04, 2012 at 01:50:16PM +0200, Constantinos Venetsanopoulos wrote: Change the --disks option validation, to just check the format of the dict and do not check whether the keys are included in the IDISK_PARAMS constant at OpCode level

Re: [PATCH master] Remove checks wrt IDISK_PARAMS from OpCode level

2012-12-12 Thread Constantinos Venetsanopoulos
On 12/12/2012 01:01 PM, Iustin Pop wrote: On Wed, Dec 12, 2012 at 12:50:35PM +0200, Constantinos Venetsanopoulos wrote: Hello team, any comments on this one? Hah, just replied *now* to it. Talk about coincidences… :) iustin :) great! Constantinos

Re: [PATCH master] Remove checks wrt IDISK_PARAMS from OpCode level

2012-12-12 Thread Constantinos Venetsanopoulos
On 12/12/2012 01:37 PM, Iustin Pop wrote: On Wed, Dec 12, 2012 at 01:26:00PM +0200, Constantinos Venetsanopoulos wrote: On 12/12/2012 01:00 PM, Iustin Pop wrote: On Tue, Dec 04, 2012 at 01:50:16PM +0200, Constantinos Venetsanopoulos wrote: Change the --disks option validation, to just check

Re: [PATCH master] Remove checks wrt IDISK_PARAMS from OpCode level

2012-12-12 Thread Constantinos Venetsanopoulos
On 12/12/2012 01:58 PM, Iustin Pop wrote: On Wed, Dec 12, 2012 at 01:54:13PM +0200, Constantinos Venetsanopoulos wrote: On 12/12/2012 01:37 PM, Iustin Pop wrote: On Wed, Dec 12, 2012 at 01:26:00PM +0200, Constantinos Venetsanopoulos wrote: On 12/12/2012 01:00 PM, Iustin Pop wrote: On Tue

Re: [synnefo-devel] Re: [PATCH master] Remove checks wrt IDISK_PARAMS from OpCode level

2012-12-12 Thread Constantinos Venetsanopoulos
On 12/12/2012 03:24 PM, Iustin Pop wrote: On Wed, Dec 12, 2012 at 02:06:42PM +0200, Constantinos Venetsanopoulos wrote: On 12/12/2012 01:58 PM, Iustin Pop wrote: On Wed, Dec 12, 2012 at 01:54:13PM +0200, Constantinos Venetsanopoulos wrote: On 12/12/2012 01:37 PM, Iustin Pop wrote: On Wed

Re: [synnefo-devel] Re: [PATCH master] Remove checks wrt IDISK_PARAMS from OpCode level

2012-12-12 Thread Constantinos Venetsanopoulos
On 12/12/2012 05:21 PM, Iustin Pop wrote: On Wed, Dec 12, 2012 at 05:01:36PM +0200, Constantinos Venetsanopoulos wrote: On 12/12/2012 03:24 PM, Iustin Pop wrote: On Wed, Dec 12, 2012 at 02:06:42PM +0200, Constantinos Venetsanopoulos wrote: On 12/12/2012 01:58 PM, Iustin Pop wrote: On Wed

object has no attribute 'hostname1' (when run with --no-name-check --no-ip-check)

2012-12-13 Thread Constantinos Venetsanopoulos
Hello team, while testing the current master branch I stumbled upon this, which seems like a bug: when creating a new instance with --no-name-check --no-ip-check I get the following error: Failure: command execution error: 'LUInstanceCreate' object has no attribute 'hostname1' I see that in

Re: object has no attribute 'hostname1' (when run with --no-name-check --no-ip-check)

2012-12-13 Thread Constantinos Venetsanopoulos
On 12/13/2012 05:25 PM, Iustin Pop wrote: On Thu, Dec 13, 2012 at 05:04:11PM +0200, Constantinos Venetsanopoulos wrote: Hello team, while testing the current master branch I stumbled upon this, which seems like a bug: when creating a new instance with --no-name-check --no-ip-check I get

[PATCH master] Pass check_ip and not hostname.ip to _ComputeNics

2012-12-13 Thread Constantinos Venetsanopoulos
This should be done because in the case of --no-name-check there is no 'hostname.ip' attribute, causing an execution error. 'check_ip' is always set (in CheckArguments) even if --no-name-check is passed in the command line. Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- lib

assertion error during migration

2012-12-13 Thread Constantinos Venetsanopoulos
Hello team, I'm testing the rebased ExtStorage patchset before re-sending and when I tried to migrate an instance I get the following error: # gnt-instance migrate ext1 Instance ext1 will be migrated. Note that migration might impact the instance if anything goes wrong (e.g. due to bugs in the

[PATCH master 1/7] Update the shared storage design document

2012-12-14 Thread Constantinos Venetsanopoulos
Update the shared storage design document to reflect the current changes, after the implementation of the ExtStorage interface. Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- doc/design-shared-storage.rst | 204 ++--- 1 file changed, 112

[PATCH master 2/7] Implement the External Storage Interface

2012-12-14 Thread Constantinos Venetsanopoulos
logical id is the tuple ('ext', UUID.ext.diskX), where UUID is generated as in disk template `plain' and X is the disk's index. Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- Makefile.am |1 + configure.ac | 12 ++ lib/bdev.py | 351

[PATCH master 4/7] Adjust LUInstanceSetParams wrt the `ext' template

2012-12-14 Thread Constantinos Venetsanopoulos
an existing disk's ExtStorage Provider, neither can change an existing disk's ext-params. Only an existing disk's `mode' can be modified. Removal is transparent of the disk template and is also supported. Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- lib/cmdlib.py | 60

[PATCH master 0/7] Implement the ExtStorage Interface (updated)

2012-12-14 Thread Constantinos Venetsanopoulos
the previous time. Kind Regards, Constantinos Constantinos Venetsanopoulos (7): Update the shared storage design document Implement the External Storage Interface Multiple ExtStorage Providers and ext-params Adjust LUInstanceSetParams wrt the `ext' template Add the gnt

[PATCH master 3/7] Multiple ExtStorage Providers and ext-params

2012-12-14 Thread Constantinos Venetsanopoulos
Providers for each disk and passing different ext-params to them: -t ext --disk=0:size=2G,provider=sample_provider1,param1=value1 --disk=1:size=3G,provider=sample_provider2,param2=value2 Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- lib/bdev.py | 52

Re: [PATCH master 3/7] Multiple ExtStorage Providers and ext-params

2012-12-20 Thread Constantinos Venetsanopoulos
On 12/20/2012 03:58 PM, Iustin Pop wrote: On Fri, Dec 14, 2012 at 03:50:07PM +0200, Constantinos Venetsanopoulos wrote: Add support for passing parameters to the ext template (ext-params). Take advantage of disk-params, that don't seem to make much sense in this template (ExtStorage Providers

Re: [PATCH master 3/7] Multiple ExtStorage Providers and ext-params

2012-12-20 Thread Constantinos Venetsanopoulos
On 12/20/2012 05:52 PM, Iustin Pop wrote: On Thu, Dec 20, 2012 at 05:48:40PM +0200, Constantinos Venetsanopoulos wrote: On 12/20/2012 03:58 PM, Iustin Pop wrote: On Fri, Dec 14, 2012 at 03:50:07PM +0200, Constantinos Venetsanopoulos wrote: Add support for passing parameters to the ext

Re: [PATCH master 4/7] Adjust LUInstanceSetParams wrt the `ext' template

2012-12-20 Thread Constantinos Venetsanopoulos
On 12/20/2012 06:03 PM, Iustin Pop wrote: On Thu, Dec 20, 2012 at 06:00:55PM +0200, Constantinos Venetsanopoulos wrote: On 12/20/2012 04:02 PM, Iustin Pop wrote: On Fri, Dec 14, 2012 at 03:50:08PM +0200, Constantinos Venetsanopoulos wrote: Initial support for the `ext' template in gnt

Re: [PATCH master 5/7] Add the gnt-storage client

2012-12-20 Thread Constantinos Venetsanopoulos
On 12/20/2012 7:28 PM, Iustin Pop wrote: On Thu, Dec 20, 2012 at 07:18:39PM +0200, Constantinos Venetsanopoulos wrote: On 12/20/2012 04:13 PM, Iustin Pop wrote: On Fri, Dec 14, 2012 at 03:50:09PM +0200, Constantinos Venetsanopoulos wrote: Add a new client called 'gnt-storage'. The client

Re: [PATCH master 5/7] Add the gnt-storage client

2012-12-22 Thread Constantinos Venetsanopoulos
On 12/22/2012 12:24 PM, Iustin Pop wrote: On Fri, Dec 21, 2012 at 04:34:57PM +0200, Constantinos Venetsanopoulos wrote: On 12/20/2012 11:52 PM, Iustin Pop wrote: On Thu, Dec 20, 2012 at 09:55:10PM +0200, Constantinos Venetsanopoulos wrote: On 12/20/2012 7:28 PM, Iustin Pop wrote: On Thu, Dec

Re: [PATCH master 7/7] Add ExtStorage related man pages

2012-12-22 Thread Constantinos Venetsanopoulos
On 12/22/2012 12:24 PM, Iustin Pop wrote: On Thu, Dec 20, 2012 at 03:26:57PM +0100, Iustin Pop wrote: On Fri, Dec 14, 2012 at 03:50:11PM +0200, Constantinos Venetsanopoulos wrote: * ganeti-extstorage-interface man page * gnt-storage man page +gnt-storage(8) Ganeti | Version @GANETI_VERSION

[PATCH master] gnt-storage man page: make commands sub-sections

2012-12-28 Thread Constantinos Venetsanopoulos
Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- Hello team, During the review of the ExtStorage patch series Iustin commented that the model for gnt-* man pages proposes commands to appear as sub-sections rather than just bold-ed. However, I see that the gnt-os man page doesn't

  1   2   >