Re: [Geeqie-devel] [PATCH 0/1] Fix crash on drag and drop from Xfe

[Jonathan Boeing]

On Sun, 17 Apr 2016 17:09:49 +0100
Colin Clark  wrote:


> Sorry, but I cannot test here this because I cannot replicate that
> fault on my system.

I'm using Fluxbox rather than a full Desktop Environment; maybe that
has something to do with it?

--
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] [PATCH 0/1] Fix crash on drag and drop from Xfe

[Colin Clark]

On 16/04/16 20:01, Jonathan Boeing wrote:
> Here's a patch to fix a crash that I've been hitting for a while. The
> issue is that when dragging and dropping from Xfe (a light-weight file
> explorer, http://roland65.free.fr/xfe/), paths aren't escaped like they
> are when dnd'ing from a GTK app. If the filename has characters that are
> reserved per URI rules (e.g. 'test # one'), g_filename_from_uri()
> returns null and geeqie crashes with a SIGSEGV.
>
> To fix it, the patch checks if the conversion failed due to a bad URI.
> If so, it manually escapes the URI and tries to convert again.
>
> This probably isn't specific to Xfe, but that's the only non-GTK/QT
> program I use that can drag and drop.
>
> Jonathan Boeing (1):
>Fix crash on drag and drop from xfe
>
>   src/uri_utils.c | 28 +++-
>   1 file changed, 27 insertions(+), 1 deletion(-)
>
Hi Jonathan

It looks to me that the user doesn't get notified that part of the DnD 
has failed.

Would it be better to perhaps include something like:

warning_dialog(_("Drag and Drop failed"), "some text", 
GTK_STOCK_DIALOG_WARNING, NULL);

some where in there? (Although the code doesn't know what its parent is, 
so that may also be a problem).

Sorry, but I cannot test here this because I cannot replicate that fault 
on my system.


My apologies if I have misunderstood your solution.


Colin Clark


--
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel