Re: [Geeqie-devel] [PATCH v2 1/1] Fix crash on drag and drop from xfe

On 19/04/16 01:50, Jonathan Boeing wrote: > On Mon, 18 Apr 2016 17:39:23 -0700 > Jonathan Boeing wrote: > >> diff --git a/src/ui_bookmark.c b/src/ui_bookmark.c >> index 842b947..18f7311 100644 >> --- a/src/ui_bookmark.c >> +++ b/src/ui_bookmark.c >> @@ -707,13 +707,19

Re: [Geeqie-devel] [PATCH v2 1/1] Fix crash on drag and drop from xfe

On Mon, 18 Apr 2016 17:39:23 -0700 Jonathan Boeing wrote: > diff --git a/src/ui_bookmark.c b/src/ui_bookmark.c > index 842b947..18f7311 100644 > --- a/src/ui_bookmark.c > +++ b/src/ui_bookmark.c > @@ -707,13 +707,19 @@ static void bookmark_dnd_get_data(GtkWidget >

[Geeqie-devel] [PATCH v2 1/1] Fix crash on drag and drop from xfe

Dragged and dropped paths from xfe aren't escaped like paths from a gtk app. A folder named 'test # one' for example causes g_filename_from_uri to fail and return NULL, which then causes a SIGSEGV in path_to_utf8. This patch fixes the crash by checking for failed conversions. If conversion failed