Re: [PATCH v8 0/6] NVMeoFC support on Grub

2026-02-25 Thread Venkat
Tested this patch, and install and boot on NVMF, work fine.

Without this patch:

error: ../../grub-core/kern/powerpc/ieee1275/platform_keystore.c:247:PKS support
 is there but it has zero objects
.
error: ../../grub-core/kern/ieee1275/openfw.c:445:unsupported type nvm-e for dev
ice /pci@8002152/fibre-channel@0,1/nvme-of/controller@5005076810193675,f
fff.
error: ../../grub-core/kern/disk.c:240:disk `ieee1275//pci@8002152/fibre
-channel@0\,1/nvme-of/controller@5005076810193675\,,msdos2' not found.
Entering rescue mode...
grub rescue>

With this Patch:

nvme1n1259:10   30G  0 disk 
├─nvme1n1p1259:204M  0 part 
├─nvme1n1p2259:401G  0 part /boot
└─nvme1n1p3259:50   29G  0 part 
  ├─rhel_ltc--den11--lp13-root 253:00   26G  0 lvm  /
  └─rhel_ltc--den11--lp13-swap 253:103G  0 lvm  [SWAP]

 df -h
Filesystem  Size  Used Avail Use% Mounted on
devtmpfs 25G 0   25G   0% /dev
tmpfs25G 0   25G   0% /dev/shm
tmpfs   9.8G   17M  9.8G   1% /run
/dev/mapper/rhel_ltc--den11--lp13-root   26G  1.9G   25G   8% /
/dev/nvme1n1p2  960M  450M  511M  47% /boot
tmpfs   4.9G 0  4.9G   0% /run/user/0


Tested-by: Venkat Rao Bagalkote 

Regards,
Venkat.

> On 23 Feb 2026, at 7:14 PM, Avnish Chouhan  wrote:
> 
> This patch series adds support of NVMeoFC and NVMe Multipath splitter on 
> grub. It consists of six
> patches.
> 
> Patch 1/6 (0001-ieee1275-powerpc-implements-fibre-channel-discovery-.patch):
> grub-ofpathname doesn't work with fibre channel because there is no
> function currently implemented for it.
> This patch enables it by prividing a function that looks for the port
> name, building the entire path for OF devices.
> 
> Patch 2/6(0002-ieee1275-implement-FCP-methods-for-WWPN-and-LUNs.patch):
> This patch enables the fcp-targets and fcp-luns methods which are
> responsible to get WWPNs and LUNs for fibre channel devices.
> Those methods are specially necessary if the boot directory and grub
> installation are in different FCP disks, allowing the dev_iterate()
> to find the WWPNs and LUNs when called by searchfs.uuid tool.
> 
> Patch 3/6(0003-change-partition-parser.patch):
> Usually grub will parse the PFW arguments by searching for the first 
> occurence of the character ':'.
> However, we can have this char more than once on NQN.
> This patch changes the logic to find the last occurence of this char so we 
> can get the proper values
> for NVMeoFC
> 
> Patch 4/6(0004-ieee1275-add-support-for-NVMeoFC.patch):
> This patch implements the functions to scan and discovery of NVMeoFC.
> 
> Patch 5/6(0005-ieee1275-ofpath-enable-NVMeoF-logical-device-transla.patch):
> This patch add code to enable the translation of logical devices to the of 
> NVMeoFC paths.
> 
> Patch 6/6(0006-ieee1275-support-added-for-multiple-nvme-bootpaths.patch)
> This patch sets mupltiple NVMe boot-devices for more robust boot.
> Scenario where NVMe multipaths are available, all the available bootpaths 
> (Max 5)
> will be added as the boot-device.
> 
> Avnish Chouhan (5):
>  ieee1275: implement FCP methods for WWPN and LUNs
>  ieee1275: change the logic of ieee1275_get_devargs()
>  ieee1275: add support for NVMeoFC
>  ieee1275: ofpath enable NVMeoF logical device translate
>  ieee1275: support added for multiple nvme bootpaths
> 
> Diego Domingos (1):
>  ieee1275/powerpc: implements fibre channel discovery for ofpathname
> 
> grub-core/disk/ieee1275/ofdisk.c 
> grub-core/kern/ieee1275/openfw.c 
> grub-core/osdep/linux/ofpath.c
> grub-core/osdep/unix/platform.c   
> include/grub/util/ofpath.h
> include/grub/util/install.h   
> 6 files changed
> 
> -- 
> 2.50.1 (Apple Git-155)
> 
> 
> ___
> Grub-devel mailing list
> [email protected]
> https://lists.gnu.org/mailman/listinfo/grub-devel


___
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [PATCH v8 0/6] NVMeoFC support on Grub

2026-02-25 Thread Sudhakar Kuppusamy
Testing: NVMe install+boot OK on powerpc-ieee1275

Tested-by: Sudhakar Kuppusamy 

Thanks,
Sudhakar

> On 23 Feb 2026, at 7:14 PM, Avnish Chouhan  wrote:
> 
> This patch series adds support of NVMeoFC and NVMe Multipath splitter on 
> grub. It consists of six
> patches.
> 
> Patch 1/6 (0001-ieee1275-powerpc-implements-fibre-channel-discovery-.patch):
> grub-ofpathname doesn't work with fibre channel because there is no
> function currently implemented for it.
> This patch enables it by prividing a function that looks for the port
> name, building the entire path for OF devices.
> 
> Patch 2/6(0002-ieee1275-implement-FCP-methods-for-WWPN-and-LUNs.patch):
> This patch enables the fcp-targets and fcp-luns methods which are
> responsible to get WWPNs and LUNs for fibre channel devices.
> Those methods are specially necessary if the boot directory and grub
> installation are in different FCP disks, allowing the dev_iterate()
> to find the WWPNs and LUNs when called by searchfs.uuid tool.
> 
> Patch 3/6(0003-change-partition-parser.patch):
> Usually grub will parse the PFW arguments by searching for the first 
> occurence of the character ':'.
> However, we can have this char more than once on NQN.
> This patch changes the logic to find the last occurence of this char so we 
> can get the proper values
> for NVMeoFC
> 
> Patch 4/6(0004-ieee1275-add-support-for-NVMeoFC.patch):
> This patch implements the functions to scan and discovery of NVMeoFC.
> 
> Patch 5/6(0005-ieee1275-ofpath-enable-NVMeoF-logical-device-transla.patch):
> This patch add code to enable the translation of logical devices to the of 
> NVMeoFC paths.
> 
> Patch 6/6(0006-ieee1275-support-added-for-multiple-nvme-bootpaths.patch)
> This patch sets mupltiple NVMe boot-devices for more robust boot.
> Scenario where NVMe multipaths are available, all the available bootpaths 
> (Max 5)
> will be added as the boot-device.
> 
> Avnish Chouhan (5):
>  ieee1275: implement FCP methods for WWPN and LUNs
>  ieee1275: change the logic of ieee1275_get_devargs()
>  ieee1275: add support for NVMeoFC
>  ieee1275: ofpath enable NVMeoF logical device translate
>  ieee1275: support added for multiple nvme bootpaths
> 
> Diego Domingos (1):
>  ieee1275/powerpc: implements fibre channel discovery for ofpathname
> 
> grub-core/disk/ieee1275/ofdisk.c 
> grub-core/kern/ieee1275/openfw.c 
> grub-core/osdep/linux/ofpath.c
> grub-core/osdep/unix/platform.c   
> include/grub/util/ofpath.h
> include/grub/util/install.h   
> 6 files changed
> 
> -- 
> 2.50.1 (Apple Git-155)
> 
> 
> ___
> Grub-devel mailing list
> [email protected]
> https://lists.gnu.org/mailman/listinfo/grub-devel

___
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [PATCH v8 0/6] NVMeoFC support on Grub

2026-02-24 Thread krishang

On 2026-02-23 19:14, Avnish Chouhan wrote:

Tested-by: Krishan Gopal Saraswat 

Regards,
Krishan


This patch series adds support of NVMeoFC and NVMe Multipath splitter
on grub. It consists of six
patches.

Patch 1/6 
(0001-ieee1275-powerpc-implements-fibre-channel-discovery-.patch):

grub-ofpathname doesn't work with fibre channel because there is no
function currently implemented for it.
This patch enables it by prividing a function that looks for the port
name, building the entire path for OF devices.

Patch 2/6(0002-ieee1275-implement-FCP-methods-for-WWPN-and-LUNs.patch):
This patch enables the fcp-targets and fcp-luns methods which are
responsible to get WWPNs and LUNs for fibre channel devices.
Those methods are specially necessary if the boot directory and grub
installation are in different FCP disks, allowing the dev_iterate()
to find the WWPNs and LUNs when called by searchfs.uuid tool.

Patch 3/6(0003-change-partition-parser.patch):
Usually grub will parse the PFW arguments by searching for the first
occurence of the character ':'.
However, we can have this char more than once on NQN.
This patch changes the logic to find the last occurence of this char
so we can get the proper values
for NVMeoFC

Patch 4/6(0004-ieee1275-add-support-for-NVMeoFC.patch):
This patch implements the functions to scan and discovery of NVMeoFC.

Patch 
5/6(0005-ieee1275-ofpath-enable-NVMeoF-logical-device-transla.patch):

This patch add code to enable the translation of logical devices to
the of NVMeoFC paths.

Patch 
6/6(0006-ieee1275-support-added-for-multiple-nvme-bootpaths.patch)

This patch sets mupltiple NVMe boot-devices for more robust boot.
Scenario where NVMe multipaths are available, all the available
bootpaths (Max 5)
will be added as the boot-device.

Avnish Chouhan (5):
  ieee1275: implement FCP methods for WWPN and LUNs
  ieee1275: change the logic of ieee1275_get_devargs()
  ieee1275: add support for NVMeoFC
  ieee1275: ofpath enable NVMeoF logical device translate
  ieee1275: support added for multiple nvme bootpaths

Diego Domingos (1):
  ieee1275/powerpc: implements fibre channel discovery for ofpathname

 grub-core/disk/ieee1275/ofdisk.c
 grub-core/kern/ieee1275/openfw.c
 grub-core/osdep/linux/ofpath.c
 grub-core/osdep/unix/platform.c
 include/grub/util/ofpath.h
 include/grub/util/install.h
 6 files changed


___
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel


[PATCH v8 0/6] NVMeoFC support on Grub

2026-02-23 Thread Avnish Chouhan
This patch series adds support of NVMeoFC and NVMe Multipath splitter on grub. 
It consists of six
patches.

Patch 1/6 (0001-ieee1275-powerpc-implements-fibre-channel-discovery-.patch):
grub-ofpathname doesn't work with fibre channel because there is no
function currently implemented for it.
This patch enables it by prividing a function that looks for the port
name, building the entire path for OF devices.

Patch 2/6(0002-ieee1275-implement-FCP-methods-for-WWPN-and-LUNs.patch):
This patch enables the fcp-targets and fcp-luns methods which are
responsible to get WWPNs and LUNs for fibre channel devices.
Those methods are specially necessary if the boot directory and grub
installation are in different FCP disks, allowing the dev_iterate()
to find the WWPNs and LUNs when called by searchfs.uuid tool.

Patch 3/6(0003-change-partition-parser.patch):
Usually grub will parse the PFW arguments by searching for the first occurence 
of the character ':'.
However, we can have this char more than once on NQN.
This patch changes the logic to find the last occurence of this char so we can 
get the proper values
for NVMeoFC

Patch 4/6(0004-ieee1275-add-support-for-NVMeoFC.patch):
This patch implements the functions to scan and discovery of NVMeoFC.

Patch 5/6(0005-ieee1275-ofpath-enable-NVMeoF-logical-device-transla.patch):
This patch add code to enable the translation of logical devices to the of 
NVMeoFC paths.

Patch 6/6(0006-ieee1275-support-added-for-multiple-nvme-bootpaths.patch)
This patch sets mupltiple NVMe boot-devices for more robust boot.
Scenario where NVMe multipaths are available, all the available bootpaths (Max 
5)
will be added as the boot-device.

Avnish Chouhan (5):
  ieee1275: implement FCP methods for WWPN and LUNs
  ieee1275: change the logic of ieee1275_get_devargs()
  ieee1275: add support for NVMeoFC
  ieee1275: ofpath enable NVMeoF logical device translate
  ieee1275: support added for multiple nvme bootpaths

Diego Domingos (1):
  ieee1275/powerpc: implements fibre channel discovery for ofpathname

 grub-core/disk/ieee1275/ofdisk.c 
 grub-core/kern/ieee1275/openfw.c 
 grub-core/osdep/linux/ofpath.c
 grub-core/osdep/unix/platform.c   
 include/grub/util/ofpath.h
 include/grub/util/install.h   
 6 files changed

-- 
2.50.1 (Apple Git-155)


___
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel