Re: [PR] COMPRESS-721 -- avoid reflection when possible in unpack200 [commons-compress]
tballison commented on PR #764: URL: https://github.com/apache/commons-compress/pull/764#issuecomment-4046802093 fix incoming, again apologies for the noise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] COMPRESS-721 -- avoid reflection when possible in unpack200 [commons-compress]
garydgregory commented on PR #764: URL: https://github.com/apache/commons-compress/pull/764#issuecomment-4046651439 Hello @tballison There might be a way to do this without reflection, if so please provide it 😁 Otherwise, these untested changes are Just asking for a regression in the future... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] COMPRESS-721 -- avoid reflection when possible in unpack200 [commons-compress]
tballison commented on PR #764:
URL: https://github.com/apache/commons-compress/pull/764#issuecomment-4046610109
Sorry for the noise, `LegacyConstructorsTest` obv still needs the java 17
profile. I confirmed we do not need new unit tests for pack200. The
{{--add-opens}} which is necessary for existing unit tests masks the problems
for unpack200.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] COMPRESS-721 -- avoid reflection when possible in unpack200 [commons-compress]
tballison commented on PR #764: URL: https://github.com/apache/commons-compress/pull/764#issuecomment-4046561248 As a side note, the more aggressive fix is to get rid of reflection entirely. I chose to modify the existing code as little as possible on this PR, but happy to go bigger if desired. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] COMPRESS-721 -- avoid reflection when possible in unpack200 [commons-compress]
tballison commented on PR #764: URL: https://github.com/apache/commons-compress/pull/764#issuecomment-4046538432 @garydgregory LOL...y, I added those when I was manually testing by removing the java >=17 profile in the pom.xml. However, as you point out, the build already fails spectacularly with existing tests when that is removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] COMPRESS-721 -- avoid reflection when possible in unpack200 [commons-compress]
tballison commented on PR #764:
URL: https://github.com/apache/commons-compress/pull/764#issuecomment-4041694892
I added unit tests that fail when building without the `${argLine}
--add-opens java.base/java.io=ALL-UNNAMED` in the pom.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
