Re: [PR] feat: add overview of Apache Commons workflows [commons-parent]

2026-04-19 Thread via GitHub


ppkarwasz commented on PR #701:
URL: https://github.com/apache/commons-parent/pull/701#issuecomment-4276141618

   Oops, I didn't pay attention to the button I was pressing: I am used to 
Log4j, where the “Squash” button is the only choice. We could disable “Merge” 
and “Rebase” in this repo too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] feat: add overview of Apache Commons workflows [commons-parent]

2026-04-19 Thread via GitHub


garydgregory commented on PR #701:
URL: https://github.com/apache/commons-parent/pull/701#issuecomment-4276034334

   In the future, please _squash_ PR commits.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] feat: add overview of Apache Commons workflows [commons-parent]

2026-04-19 Thread via GitHub


ppkarwasz commented on PR #701:
URL: https://github.com/apache/commons-parent/pull/701#issuecomment-4276030763

   I modified the template for the `README.md` files in 
apache/commons-build-plugin#421
   The change doesn't seem very important, so it can wait until the next Build 
Plugin release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] feat: add overview of Apache Commons workflows [commons-parent]

2026-04-19 Thread via GitHub


ppkarwasz merged PR #701:
URL: https://github.com/apache/commons-parent/pull/701


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] feat: add overview of Apache Commons workflows [commons-parent]

2026-04-19 Thread via GitHub


aherbert commented on PR #701:
URL: https://github.com/apache/commons-parent/pull/701#issuecomment-4275995922

   Very nice. Sad to see Math failing; I cannot take ownership of the others 
though. The Math project may require some fixed seeds in the 'random' tests to 
increase its build stability as it fails a lot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] feat: add overview of Apache Commons workflows [commons-parent]

2026-04-19 Thread via GitHub


garydgregory commented on PR #701:
URL: https://github.com/apache/commons-parent/pull/701#issuecomment-4275993077

   > You regenerate README.md at every release, so manual changes would be 
lost. I could, however, add a link to this file to every README.md you generate.
   
   Sounds good.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] feat: add overview of Apache Commons workflows [commons-parent]

2026-04-19 Thread via GitHub


ppkarwasz commented on PR #701:
URL: https://github.com/apache/commons-parent/pull/701#issuecomment-4275968834

   > WDYT about making the columns in this table and 
https://commons.apache.org/ match? For example, seeing the latest version on 
https://commons.apache.org/ is pretty nice.
   
   I added the current version badge and slightly refactored the table.
   
   > Why not just put this table in the README.md?
   
   You regenerate `README.md` at every release, so manual changes would be 
lost. I could, however, add a link to this file to every `README.md` you 
generate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] feat: add overview of Apache Commons workflows [commons-parent]

2026-04-19 Thread via GitHub


aherbert commented on PR #701:
URL: https://github.com/apache/commons-parent/pull/701#issuecomment-4275863147

   LGTM. Adding the latest version in a column would be nice.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] feat: add overview of Apache Commons workflows [commons-parent]

2026-04-19 Thread via GitHub


garydgregory commented on PR #701:
URL: https://github.com/apache/commons-parent/pull/701#issuecomment-4275717341

   Hi @ppkarwasz 
   
   WDYT about making the columns in this table and https://commons.apache.org/ 
match? For example, seeing the latest version on https://commons.apache.org/ is 
pretty nice.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]