Re: [PR] Implement GzipByteBuffDecompressor with on-heap and off-heap decompression paths [hbase]
charlesconnell commented on PR #8541: URL: https://github.com/apache/hbase/pull/8541#issuecomment-5240504905 I looked into how ZlibDecompressor supports decompression of on-heap byte arrays. It's not very efficient because it copies the bytes into a ByteBuffer. I think for this PR let's focus on where we can achieve zero-copy, so please skip support for on-heap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Implement GzipByteBuffDecompressor with on-heap and off-heap decompression paths [hbase]
SaadASTheDev commented on code in PR #8541:
URL: https://github.com/apache/hbase/pull/8541#discussion_r3738643584
##
hbase-common/src/test/java/org/apache/hadoop/hbase/io/compress/TestGzipByteBuffDecompressor.java:
##
@@ -0,0 +1,511 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.io.compress;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.fail;
+import static org.junit.jupiter.api.Assumptions.assumeTrue;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.Arrays;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.nio.ByteBuff;
+import org.apache.hadoop.hbase.nio.MultiByteBuff;
+import org.apache.hadoop.hbase.nio.SingleByteBuff;
+import org.apache.hadoop.hbase.testclassification.SmallTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.util.NativeCodeLoader;
+import org.junit.jupiter.api.Tag;
+import org.junit.jupiter.api.Test;
+
+@Tag(SmallTests.TAG)
+public class TestGzipByteBuffDecompressor {
+
+ /*
+ * "HBase is fun to use and very fast" compressed as a single gzip member
via GZIPOutputStream,
+ * matching the framing that ReusableStreamGzipCodec produces on the
compression side.
+ */
Review Comment:
There are situations, the payload will contain multiple members but we
enclose over ours via: InputStart + InputLen, but we should test to make sure
we did it correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Implement GzipByteBuffDecompressor with on-heap and off-heap decompression paths [hbase]
SaadASTheDev commented on code in PR #8541:
URL: https://github.com/apache/hbase/pull/8541#discussion_r3738643584
##
hbase-common/src/test/java/org/apache/hadoop/hbase/io/compress/TestGzipByteBuffDecompressor.java:
##
@@ -0,0 +1,511 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.io.compress;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.fail;
+import static org.junit.jupiter.api.Assumptions.assumeTrue;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.Arrays;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.nio.ByteBuff;
+import org.apache.hadoop.hbase.nio.MultiByteBuff;
+import org.apache.hadoop.hbase.nio.SingleByteBuff;
+import org.apache.hadoop.hbase.testclassification.SmallTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.util.NativeCodeLoader;
+import org.junit.jupiter.api.Tag;
+import org.junit.jupiter.api.Test;
+
+@Tag(SmallTests.TAG)
+public class TestGzipByteBuffDecompressor {
+
+ /*
+ * "HBase is fun to use and very fast" compressed as a single gzip member
via GZIPOutputStream,
+ * matching the framing that ReusableStreamGzipCodec produces on the
compression side.
+ */
Review Comment:
There are situations, the payload will contain multiple buffers but we
enclose over ours via: InputStart + InputLen, but we should test to make sure
we did it correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Implement GzipByteBuffDecompressor with on-heap and off-heap decompression paths [hbase]
SaadASTheDev commented on code in PR #8541:
URL: https://github.com/apache/hbase/pull/8541#discussion_r3738524269
##
hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/GzipByteBuffDecompressor.java:
##
@@ -0,0 +1,220 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.io.compress;
+
+import edu.umd.cs.findbugs.annotations.Nullable;
+import java.io.IOException;
+import java.util.zip.CRC32;
+import java.nio.ByteBuffer;
+import java.util.zip.DataFormatException;
+import java.util.zip.Inflater;
+import org.apache.hadoop.hbase.nio.ByteBuff;
+import org.apache.hadoop.hbase.nio.SingleByteBuff;
+import org.apache.hadoop.io.compress.zlib.ZlibDecompressor;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Glue for ByteBuffDecompressor on top of Hadoop's native
+ * {@link ZlibDecompressor.ZlibDirectDecompressor}.
+ */
[email protected]
+public class GzipByteBuffDecompressor implements ByteBuffDecompressor {
+
+ private static final int GZIP_HEADER_LENGTH = 10;
+ private static final int GZIP_TRAILER_LENGTH = 8;
+
+ @Nullable
+ private final ZlibDecompressor.ZlibDirectDecompressor decompressor;
+
+ private final Inflater inflater = new Inflater(true);
Review Comment:
Will do, wasn't familiar with the top level decompressor but that simplifies
things, Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Implement GzipByteBuffDecompressor with on-heap and off-heap decompression paths [hbase]
SaadASTheDev commented on code in PR #8541:
URL: https://github.com/apache/hbase/pull/8541#discussion_r3738512157
##
hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/GzipByteBuffDecompressor.java:
##
@@ -0,0 +1,220 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.io.compress;
+
+import edu.umd.cs.findbugs.annotations.Nullable;
+import java.io.IOException;
+import java.util.zip.CRC32;
+import java.nio.ByteBuffer;
+import java.util.zip.DataFormatException;
+import java.util.zip.Inflater;
+import org.apache.hadoop.hbase.nio.ByteBuff;
+import org.apache.hadoop.hbase.nio.SingleByteBuff;
+import org.apache.hadoop.io.compress.zlib.ZlibDecompressor;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Glue for ByteBuffDecompressor on top of Hadoop's native
+ * {@link ZlibDecompressor.ZlibDirectDecompressor}.
+ */
[email protected]
+public class GzipByteBuffDecompressor implements ByteBuffDecompressor {
+
+ private static final int GZIP_HEADER_LENGTH = 10;
+ private static final int GZIP_TRAILER_LENGTH = 8;
+
+ @Nullable
+ private final ZlibDecompressor.ZlibDirectDecompressor decompressor;
+
+ private final Inflater inflater = new Inflater(true);
+
+ private final CRC32 crc32 = new CRC32();
+
+ private boolean allowByteBuffDecompression;
+
+ GzipByteBuffDecompressor(boolean nativeZlibLoaded) {
+decompressor = nativeZlibLoaded
+ ? new
ZlibDecompressor.ZlibDirectDecompressor(ZlibDecompressor.CompressionHeader.GZIP_FORMAT,
+0)
+ : null;
+allowByteBuffDecompression = true;
+ }
+
+ @Override
+ public boolean canDecompress(ByteBuff output, ByteBuff input) {
+if (!allowByteBuffDecompression) {
+ return false;
+}
+if (!(output instanceof SingleByteBuff) || !(input instanceof
SingleByteBuff)) {
+ return false;
+}
+boolean inputDirect = input.nioByteBuffers()[0].isDirect();
+boolean outputDirect = output.nioByteBuffers()[0].isDirect();
+if (inputDirect && outputDirect) {
+ return decompressor != null;
+}
+return !inputDirect && !outputDirect;
+ }
+
+ @Override
+ public int decompress(ByteBuff output, ByteBuff input, int inputLen) throws
IOException {
+if (!(output instanceof SingleByteBuff) || !(input instanceof
SingleByteBuff)) {
+ throw new IllegalStateException(
+"At least one buffer is not a SingleByteBuff, this is not supported");
+}
+if (inputLen < GZIP_HEADER_LENGTH + GZIP_TRAILER_LENGTH) {
+ throw new IOException("Input of length " + inputLen + " is too short to
be a gzip member");
+}
+
+ByteBuffer nioInput = input.nioByteBuffers()[0];
+ByteBuffer nioOutput = output.nioByteBuffers()[0];
+boolean inputDirect = nioInput.isDirect();
+boolean outputDirect = nioOutput.isDirect();
+
+if (inputDirect && outputDirect) {
+ if (decompressor == null) {
+throw new IllegalStateException(
+ "GzipByteBuffDecompressor#decompress() was called with direct
buffers but Hadoop's "
++ "native zlib library is not loaded, this should never happen
since "
++ "canDecompress() would have returned false");
+ }
+ return decompressOffHeap(nioInput, nioOutput, inputLen);
+}
+return decompressOnHeap(nioInput, nioOutput, inputLen);
+ }
+
+ private int decompressOffHeap(ByteBuffer nioInput, ByteBuffer nioOutput, int
inputLen)
+throws IOException {
+int inputStart = nioInput.position();
+int outputStart = nioOutput.position();
+
+ByteBuffer gzipMember = nioInput.duplicate();
+gzipMember.limit(inputStart + inputLen);
+
+decompressor.reset();
+while (!decompressor.finished()) {
+ int outputRemainingBefore = nioOutput.remaining();
+ try {
+decompressor.decompress(gzipMember, nioOutput);
+ } catch (IOException e) {
+throw new IOException("Invalid gzip stream: " + e.getMessage(), e);
+ }
+ if (nioOutput.remaining() == outputRemainingBefore &&
!decompressor.finished()) {
+if (!nioOutput.hasRemaining()) {
+ throw new IOException("Output buffer is too small for the
decompressed gzip stream");
+}
+
Re: [PR] Implement GzipByteBuffDecompressor with on-heap and off-heap decompression paths [hbase]
SaadASTheDev commented on code in PR #8541:
URL: https://github.com/apache/hbase/pull/8541#discussion_r3738512157
##
hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/GzipByteBuffDecompressor.java:
##
@@ -0,0 +1,220 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.io.compress;
+
+import edu.umd.cs.findbugs.annotations.Nullable;
+import java.io.IOException;
+import java.util.zip.CRC32;
+import java.nio.ByteBuffer;
+import java.util.zip.DataFormatException;
+import java.util.zip.Inflater;
+import org.apache.hadoop.hbase.nio.ByteBuff;
+import org.apache.hadoop.hbase.nio.SingleByteBuff;
+import org.apache.hadoop.io.compress.zlib.ZlibDecompressor;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Glue for ByteBuffDecompressor on top of Hadoop's native
+ * {@link ZlibDecompressor.ZlibDirectDecompressor}.
+ */
[email protected]
+public class GzipByteBuffDecompressor implements ByteBuffDecompressor {
+
+ private static final int GZIP_HEADER_LENGTH = 10;
+ private static final int GZIP_TRAILER_LENGTH = 8;
+
+ @Nullable
+ private final ZlibDecompressor.ZlibDirectDecompressor decompressor;
+
+ private final Inflater inflater = new Inflater(true);
+
+ private final CRC32 crc32 = new CRC32();
+
+ private boolean allowByteBuffDecompression;
+
+ GzipByteBuffDecompressor(boolean nativeZlibLoaded) {
+decompressor = nativeZlibLoaded
+ ? new
ZlibDecompressor.ZlibDirectDecompressor(ZlibDecompressor.CompressionHeader.GZIP_FORMAT,
+0)
+ : null;
+allowByteBuffDecompression = true;
+ }
+
+ @Override
+ public boolean canDecompress(ByteBuff output, ByteBuff input) {
+if (!allowByteBuffDecompression) {
+ return false;
+}
+if (!(output instanceof SingleByteBuff) || !(input instanceof
SingleByteBuff)) {
+ return false;
+}
+boolean inputDirect = input.nioByteBuffers()[0].isDirect();
+boolean outputDirect = output.nioByteBuffers()[0].isDirect();
+if (inputDirect && outputDirect) {
+ return decompressor != null;
+}
+return !inputDirect && !outputDirect;
+ }
+
+ @Override
+ public int decompress(ByteBuff output, ByteBuff input, int inputLen) throws
IOException {
+if (!(output instanceof SingleByteBuff) || !(input instanceof
SingleByteBuff)) {
+ throw new IllegalStateException(
+"At least one buffer is not a SingleByteBuff, this is not supported");
+}
+if (inputLen < GZIP_HEADER_LENGTH + GZIP_TRAILER_LENGTH) {
+ throw new IOException("Input of length " + inputLen + " is too short to
be a gzip member");
+}
+
+ByteBuffer nioInput = input.nioByteBuffers()[0];
+ByteBuffer nioOutput = output.nioByteBuffers()[0];
+boolean inputDirect = nioInput.isDirect();
+boolean outputDirect = nioOutput.isDirect();
+
+if (inputDirect && outputDirect) {
+ if (decompressor == null) {
+throw new IllegalStateException(
+ "GzipByteBuffDecompressor#decompress() was called with direct
buffers but Hadoop's "
++ "native zlib library is not loaded, this should never happen
since "
++ "canDecompress() would have returned false");
+ }
+ return decompressOffHeap(nioInput, nioOutput, inputLen);
+}
+return decompressOnHeap(nioInput, nioOutput, inputLen);
+ }
+
+ private int decompressOffHeap(ByteBuffer nioInput, ByteBuffer nioOutput, int
inputLen)
+throws IOException {
+int inputStart = nioInput.position();
+int outputStart = nioOutput.position();
+
+ByteBuffer gzipMember = nioInput.duplicate();
+gzipMember.limit(inputStart + inputLen);
+
+decompressor.reset();
+while (!decompressor.finished()) {
+ int outputRemainingBefore = nioOutput.remaining();
+ try {
+decompressor.decompress(gzipMember, nioOutput);
+ } catch (IOException e) {
+throw new IOException("Invalid gzip stream: " + e.getMessage(), e);
+ }
+ if (nioOutput.remaining() == outputRemainingBefore &&
!decompressor.finished()) {
+if (!nioOutput.hasRemaining()) {
+ throw new IOException("Output buffer is too small for the
decompressed gzip stream");
+}
+
Re: [PR] Implement GzipByteBuffDecompressor with on-heap and off-heap decompression paths [hbase]
SaadASTheDev commented on code in PR #8541:
URL: https://github.com/apache/hbase/pull/8541#discussion_r3737586754
##
hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/GzipByteBuffDecompressor.java:
##
@@ -0,0 +1,220 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.io.compress;
+
+import edu.umd.cs.findbugs.annotations.Nullable;
+import java.io.IOException;
+import java.util.zip.CRC32;
+import java.nio.ByteBuffer;
+import java.util.zip.DataFormatException;
+import java.util.zip.Inflater;
+import org.apache.hadoop.hbase.nio.ByteBuff;
+import org.apache.hadoop.hbase.nio.SingleByteBuff;
+import org.apache.hadoop.io.compress.zlib.ZlibDecompressor;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Glue for ByteBuffDecompressor on top of Hadoop's native
+ * {@link ZlibDecompressor.ZlibDirectDecompressor}.
+ */
[email protected]
+public class GzipByteBuffDecompressor implements ByteBuffDecompressor {
+
+ private static final int GZIP_HEADER_LENGTH = 10;
+ private static final int GZIP_TRAILER_LENGTH = 8;
+
+ @Nullable
+ private final ZlibDecompressor.ZlibDirectDecompressor decompressor;
+
+ private final Inflater inflater = new Inflater(true);
+
+ private final CRC32 crc32 = new CRC32();
+
+ private boolean allowByteBuffDecompression;
+
+ GzipByteBuffDecompressor(boolean nativeZlibLoaded) {
+decompressor = nativeZlibLoaded
+ ? new
ZlibDecompressor.ZlibDirectDecompressor(ZlibDecompressor.CompressionHeader.GZIP_FORMAT,
+0)
+ : null;
+allowByteBuffDecompression = true;
+ }
+
+ @Override
Review Comment:
The flow for wether we can decompress is
1: verify config via context to ensure we havent disabled this feature
before we try to decompress via bytebuff
2. we only support singleByteBuff decompression for now
3. Since Zlib is a JNI we need to ensure that its properly instantiated if
and only if the buffers we are trying to decompress are direct, so if both are
direct we ensure the decompressor is loaded
4. then we return if both I/O are not direct, if true it uses the inflater
pathway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Implement GzipByteBuffDecompressor with on-heap and off-heap decompression paths [hbase]
charlesconnell commented on code in PR #8541:
URL: https://github.com/apache/hbase/pull/8541#discussion_r3737879858
##
hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/GzipByteBuffDecompressor.java:
##
@@ -0,0 +1,220 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.io.compress;
+
+import edu.umd.cs.findbugs.annotations.Nullable;
+import java.io.IOException;
+import java.util.zip.CRC32;
+import java.nio.ByteBuffer;
+import java.util.zip.DataFormatException;
+import java.util.zip.Inflater;
+import org.apache.hadoop.hbase.nio.ByteBuff;
+import org.apache.hadoop.hbase.nio.SingleByteBuff;
+import org.apache.hadoop.io.compress.zlib.ZlibDecompressor;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Glue for ByteBuffDecompressor on top of Hadoop's native
+ * {@link ZlibDecompressor.ZlibDirectDecompressor}.
+ */
[email protected]
+public class GzipByteBuffDecompressor implements ByteBuffDecompressor {
+
+ private static final int GZIP_HEADER_LENGTH = 10;
+ private static final int GZIP_TRAILER_LENGTH = 8;
+
+ @Nullable
+ private final ZlibDecompressor.ZlibDirectDecompressor decompressor;
+
+ private final Inflater inflater = new Inflater(true);
+
+ private final CRC32 crc32 = new CRC32();
+
+ private boolean allowByteBuffDecompression;
+
+ GzipByteBuffDecompressor(boolean nativeZlibLoaded) {
+decompressor = nativeZlibLoaded
+ ? new
ZlibDecompressor.ZlibDirectDecompressor(ZlibDecompressor.CompressionHeader.GZIP_FORMAT,
+0)
+ : null;
+allowByteBuffDecompression = true;
+ }
+
+ @Override
+ public boolean canDecompress(ByteBuff output, ByteBuff input) {
+if (!allowByteBuffDecompression) {
+ return false;
+}
+if (!(output instanceof SingleByteBuff) || !(input instanceof
SingleByteBuff)) {
+ return false;
+}
+boolean inputDirect = input.nioByteBuffers()[0].isDirect();
+boolean outputDirect = output.nioByteBuffers()[0].isDirect();
+if (inputDirect && outputDirect) {
+ return decompressor != null;
+}
+return !inputDirect && !outputDirect;
+ }
+
+ @Override
+ public int decompress(ByteBuff output, ByteBuff input, int inputLen) throws
IOException {
+if (!(output instanceof SingleByteBuff) || !(input instanceof
SingleByteBuff)) {
+ throw new IllegalStateException(
+"At least one buffer is not a SingleByteBuff, this is not supported");
+}
+if (inputLen < GZIP_HEADER_LENGTH + GZIP_TRAILER_LENGTH) {
+ throw new IOException("Input of length " + inputLen + " is too short to
be a gzip member");
+}
+
+ByteBuffer nioInput = input.nioByteBuffers()[0];
+ByteBuffer nioOutput = output.nioByteBuffers()[0];
+boolean inputDirect = nioInput.isDirect();
+boolean outputDirect = nioOutput.isDirect();
+
+if (inputDirect && outputDirect) {
+ if (decompressor == null) {
+throw new IllegalStateException(
+ "GzipByteBuffDecompressor#decompress() was called with direct
buffers but Hadoop's "
++ "native zlib library is not loaded, this should never happen
since "
++ "canDecompress() would have returned false");
+ }
+ return decompressOffHeap(nioInput, nioOutput, inputLen);
+}
+return decompressOnHeap(nioInput, nioOutput, inputLen);
+ }
+
+ private int decompressOffHeap(ByteBuffer nioInput, ByteBuffer nioOutput, int
inputLen)
+throws IOException {
+int inputStart = nioInput.position();
+int outputStart = nioOutput.position();
+
+ByteBuffer gzipMember = nioInput.duplicate();
+gzipMember.limit(inputStart + inputLen);
+
+decompressor.reset();
+while (!decompressor.finished()) {
+ int outputRemainingBefore = nioOutput.remaining();
+ try {
+decompressor.decompress(gzipMember, nioOutput);
+ } catch (IOException e) {
+throw new IOException("Invalid gzip stream: " + e.getMessage(), e);
+ }
+ if (nioOutput.remaining() == outputRemainingBefore &&
!decompressor.finished()) {
+if (!nioOutput.hasRemaining()) {
+ throw new IOException("Output buffer is too small for the
decompressed gzip stream");
+}
+
Re: [PR] Implement GzipByteBuffDecompressor with on-heap and off-heap decompression paths [hbase]
SaadASTheDev commented on code in PR #8541:
URL: https://github.com/apache/hbase/pull/8541#discussion_r3737544898
##
hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/GzipByteBuffDecompressor.java:
##
@@ -0,0 +1,220 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.io.compress;
+
+import edu.umd.cs.findbugs.annotations.Nullable;
+import java.io.IOException;
+import java.util.zip.CRC32;
+import java.nio.ByteBuffer;
+import java.util.zip.DataFormatException;
+import java.util.zip.Inflater;
+import org.apache.hadoop.hbase.nio.ByteBuff;
+import org.apache.hadoop.hbase.nio.SingleByteBuff;
+import org.apache.hadoop.io.compress.zlib.ZlibDecompressor;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Glue for ByteBuffDecompressor on top of Hadoop's native
+ * {@link ZlibDecompressor.ZlibDirectDecompressor}.
+ */
[email protected]
+public class GzipByteBuffDecompressor implements ByteBuffDecompressor {
+
+ private static final int GZIP_HEADER_LENGTH = 10;
+ private static final int GZIP_TRAILER_LENGTH = 8;
+
+ @Nullable
Review Comment:
These are the Singleton objects reused across decompress calls, Allocated
once per buffer, to avoid GC overhead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Implement GzipByteBuffDecompressor with on-heap and off-heap decompression paths [hbase]
SaadASTheDev commented on code in PR #8541:
URL: https://github.com/apache/hbase/pull/8541#discussion_r3737649702
##
hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/GzipByteBuffDecompressor.java:
##
@@ -0,0 +1,220 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.io.compress;
+
+import edu.umd.cs.findbugs.annotations.Nullable;
+import java.io.IOException;
+import java.util.zip.CRC32;
+import java.nio.ByteBuffer;
+import java.util.zip.DataFormatException;
+import java.util.zip.Inflater;
+import org.apache.hadoop.hbase.nio.ByteBuff;
+import org.apache.hadoop.hbase.nio.SingleByteBuff;
+import org.apache.hadoop.io.compress.zlib.ZlibDecompressor;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Glue for ByteBuffDecompressor on top of Hadoop's native
+ * {@link ZlibDecompressor.ZlibDirectDecompressor}.
+ */
[email protected]
+public class GzipByteBuffDecompressor implements ByteBuffDecompressor {
+
+ private static final int GZIP_HEADER_LENGTH = 10;
+ private static final int GZIP_TRAILER_LENGTH = 8;
+
+ @Nullable
+ private final ZlibDecompressor.ZlibDirectDecompressor decompressor;
+
+ private final Inflater inflater = new Inflater(true);
+
+ private final CRC32 crc32 = new CRC32();
+
+ private boolean allowByteBuffDecompression;
+
+ GzipByteBuffDecompressor(boolean nativeZlibLoaded) {
+decompressor = nativeZlibLoaded
+ ? new
ZlibDecompressor.ZlibDirectDecompressor(ZlibDecompressor.CompressionHeader.GZIP_FORMAT,
+0)
+ : null;
+allowByteBuffDecompression = true;
+ }
+
+ @Override
+ public boolean canDecompress(ByteBuff output, ByteBuff input) {
+if (!allowByteBuffDecompression) {
+ return false;
+}
+if (!(output instanceof SingleByteBuff) || !(input instanceof
SingleByteBuff)) {
+ return false;
+}
+boolean inputDirect = input.nioByteBuffers()[0].isDirect();
+boolean outputDirect = output.nioByteBuffers()[0].isDirect();
+if (inputDirect && outputDirect) {
+ return decompressor != null;
+}
+return !inputDirect && !outputDirect;
+ }
+
+ @Override
+ public int decompress(ByteBuff output, ByteBuff input, int inputLen) throws
IOException {
+if (!(output instanceof SingleByteBuff) || !(input instanceof
SingleByteBuff)) {
+ throw new IllegalStateException(
+"At least one buffer is not a SingleByteBuff, this is not supported");
+}
+if (inputLen < GZIP_HEADER_LENGTH + GZIP_TRAILER_LENGTH) {
+ throw new IOException("Input of length " + inputLen + " is too short to
be a gzip member");
+}
+
+ByteBuffer nioInput = input.nioByteBuffers()[0];
+ByteBuffer nioOutput = output.nioByteBuffers()[0];
+boolean inputDirect = nioInput.isDirect();
+boolean outputDirect = nioOutput.isDirect();
+
+if (inputDirect && outputDirect) {
+ if (decompressor == null) {
+throw new IllegalStateException(
+ "GzipByteBuffDecompressor#decompress() was called with direct
buffers but Hadoop's "
++ "native zlib library is not loaded, this should never happen
since "
++ "canDecompress() would have returned false");
+ }
+ return decompressOffHeap(nioInput, nioOutput, inputLen);
+}
+return decompressOnHeap(nioInput, nioOutput, inputLen);
+ }
+
+ private int decompressOffHeap(ByteBuffer nioInput, ByteBuffer nioOutput, int
inputLen)
+throws IOException {
+int inputStart = nioInput.position();
+int outputStart = nioOutput.position();
+
+ByteBuffer gzipMember = nioInput.duplicate();
+gzipMember.limit(inputStart + inputLen);
+
+decompressor.reset();
+while (!decompressor.finished()) {
+ int outputRemainingBefore = nioOutput.remaining();
+ try {
+decompressor.decompress(gzipMember, nioOutput);
+ } catch (IOException e) {
+throw new IOException("Invalid gzip stream: " + e.getMessage(), e);
+ }
+ if (nioOutput.remaining() == outputRemainingBefore &&
!decompressor.finished()) {
+if (!nioOutput.hasRemaining()) {
+ throw new IOException("Output buffer is too small for the
decompressed gzip stream");
+}
+
Re: [PR] Implement GzipByteBuffDecompressor with on-heap and off-heap decompression paths [hbase]
SaadASTheDev commented on code in PR #8541:
URL: https://github.com/apache/hbase/pull/8541#discussion_r3737649702
##
hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/GzipByteBuffDecompressor.java:
##
@@ -0,0 +1,220 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.io.compress;
+
+import edu.umd.cs.findbugs.annotations.Nullable;
+import java.io.IOException;
+import java.util.zip.CRC32;
+import java.nio.ByteBuffer;
+import java.util.zip.DataFormatException;
+import java.util.zip.Inflater;
+import org.apache.hadoop.hbase.nio.ByteBuff;
+import org.apache.hadoop.hbase.nio.SingleByteBuff;
+import org.apache.hadoop.io.compress.zlib.ZlibDecompressor;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Glue for ByteBuffDecompressor on top of Hadoop's native
+ * {@link ZlibDecompressor.ZlibDirectDecompressor}.
+ */
[email protected]
+public class GzipByteBuffDecompressor implements ByteBuffDecompressor {
+
+ private static final int GZIP_HEADER_LENGTH = 10;
+ private static final int GZIP_TRAILER_LENGTH = 8;
+
+ @Nullable
+ private final ZlibDecompressor.ZlibDirectDecompressor decompressor;
+
+ private final Inflater inflater = new Inflater(true);
+
+ private final CRC32 crc32 = new CRC32();
+
+ private boolean allowByteBuffDecompression;
+
+ GzipByteBuffDecompressor(boolean nativeZlibLoaded) {
+decompressor = nativeZlibLoaded
+ ? new
ZlibDecompressor.ZlibDirectDecompressor(ZlibDecompressor.CompressionHeader.GZIP_FORMAT,
+0)
+ : null;
+allowByteBuffDecompression = true;
+ }
+
+ @Override
+ public boolean canDecompress(ByteBuff output, ByteBuff input) {
+if (!allowByteBuffDecompression) {
+ return false;
+}
+if (!(output instanceof SingleByteBuff) || !(input instanceof
SingleByteBuff)) {
+ return false;
+}
+boolean inputDirect = input.nioByteBuffers()[0].isDirect();
+boolean outputDirect = output.nioByteBuffers()[0].isDirect();
+if (inputDirect && outputDirect) {
+ return decompressor != null;
+}
+return !inputDirect && !outputDirect;
+ }
+
+ @Override
+ public int decompress(ByteBuff output, ByteBuff input, int inputLen) throws
IOException {
+if (!(output instanceof SingleByteBuff) || !(input instanceof
SingleByteBuff)) {
+ throw new IllegalStateException(
+"At least one buffer is not a SingleByteBuff, this is not supported");
+}
+if (inputLen < GZIP_HEADER_LENGTH + GZIP_TRAILER_LENGTH) {
+ throw new IOException("Input of length " + inputLen + " is too short to
be a gzip member");
+}
+
+ByteBuffer nioInput = input.nioByteBuffers()[0];
+ByteBuffer nioOutput = output.nioByteBuffers()[0];
+boolean inputDirect = nioInput.isDirect();
+boolean outputDirect = nioOutput.isDirect();
+
+if (inputDirect && outputDirect) {
+ if (decompressor == null) {
+throw new IllegalStateException(
+ "GzipByteBuffDecompressor#decompress() was called with direct
buffers but Hadoop's "
++ "native zlib library is not loaded, this should never happen
since "
++ "canDecompress() would have returned false");
+ }
+ return decompressOffHeap(nioInput, nioOutput, inputLen);
+}
+return decompressOnHeap(nioInput, nioOutput, inputLen);
+ }
+
+ private int decompressOffHeap(ByteBuffer nioInput, ByteBuffer nioOutput, int
inputLen)
+throws IOException {
+int inputStart = nioInput.position();
+int outputStart = nioOutput.position();
+
+ByteBuffer gzipMember = nioInput.duplicate();
+gzipMember.limit(inputStart + inputLen);
+
+decompressor.reset();
+while (!decompressor.finished()) {
+ int outputRemainingBefore = nioOutput.remaining();
+ try {
+decompressor.decompress(gzipMember, nioOutput);
+ } catch (IOException e) {
+throw new IOException("Invalid gzip stream: " + e.getMessage(), e);
+ }
+ if (nioOutput.remaining() == outputRemainingBefore &&
!decompressor.finished()) {
+if (!nioOutput.hasRemaining()) {
+ throw new IOException("Output buffer is too small for the
decompressed gzip stream");
+}
+
Re: [PR] Implement GzipByteBuffDecompressor with on-heap and off-heap decompression paths [hbase]
SaadASTheDev commented on code in PR #8541:
URL: https://github.com/apache/hbase/pull/8541#discussion_r3737589844
##
hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/GzipByteBuffDecompressor.java:
##
@@ -0,0 +1,220 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.io.compress;
+
+import edu.umd.cs.findbugs.annotations.Nullable;
+import java.io.IOException;
+import java.util.zip.CRC32;
+import java.nio.ByteBuffer;
+import java.util.zip.DataFormatException;
+import java.util.zip.Inflater;
+import org.apache.hadoop.hbase.nio.ByteBuff;
+import org.apache.hadoop.hbase.nio.SingleByteBuff;
+import org.apache.hadoop.io.compress.zlib.ZlibDecompressor;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Glue for ByteBuffDecompressor on top of Hadoop's native
+ * {@link ZlibDecompressor.ZlibDirectDecompressor}.
+ */
[email protected]
+public class GzipByteBuffDecompressor implements ByteBuffDecompressor {
+
+ private static final int GZIP_HEADER_LENGTH = 10;
+ private static final int GZIP_TRAILER_LENGTH = 8;
+
+ @Nullable
+ private final ZlibDecompressor.ZlibDirectDecompressor decompressor;
+
+ private final Inflater inflater = new Inflater(true);
+
+ private final CRC32 crc32 = new CRC32();
+
+ private boolean allowByteBuffDecompression;
+
+ GzipByteBuffDecompressor(boolean nativeZlibLoaded) {
+decompressor = nativeZlibLoaded
+ ? new
ZlibDecompressor.ZlibDirectDecompressor(ZlibDecompressor.CompressionHeader.GZIP_FORMAT,
+0)
+ : null;
+allowByteBuffDecompression = true;
+ }
+
+ @Override
+ public boolean canDecompress(ByteBuff output, ByteBuff input) {
+if (!allowByteBuffDecompression) {
+ return false;
+}
+if (!(output instanceof SingleByteBuff) || !(input instanceof
SingleByteBuff)) {
+ return false;
+}
+boolean inputDirect = input.nioByteBuffers()[0].isDirect();
+boolean outputDirect = output.nioByteBuffers()[0].isDirect();
+if (inputDirect && outputDirect) {
+ return decompressor != null;
+}
+return !inputDirect && !outputDirect;
+ }
+
+ @Override
+ public int decompress(ByteBuff output, ByteBuff input, int inputLen) throws
IOException {
+if (!(output instanceof SingleByteBuff) || !(input instanceof
SingleByteBuff)) {
+ throw new IllegalStateException(
+"At least one buffer is not a SingleByteBuff, this is not supported");
+}
+if (inputLen < GZIP_HEADER_LENGTH + GZIP_TRAILER_LENGTH) {
+ throw new IOException("Input of length " + inputLen + " is too short to
be a gzip member");
+}
+
+ByteBuffer nioInput = input.nioByteBuffers()[0];
+ByteBuffer nioOutput = output.nioByteBuffers()[0];
+boolean inputDirect = nioInput.isDirect();
+boolean outputDirect = nioOutput.isDirect();
+
+if (inputDirect && outputDirect) {
+ if (decompressor == null) {
+throw new IllegalStateException(
+ "GzipByteBuffDecompressor#decompress() was called with direct
buffers but Hadoop's "
++ "native zlib library is not loaded, this should never happen
since "
++ "canDecompress() would have returned false");
+ }
+ return decompressOffHeap(nioInput, nioOutput, inputLen);
+}
+return decompressOnHeap(nioInput, nioOutput, inputLen);
+ }
+
Review Comment:
Respective off heap decompress which uses the zlib library and verifies the
trailer on its own
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Implement GzipByteBuffDecompressor with on-heap and off-heap decompression paths [hbase]
SaadASTheDev commented on code in PR #8541:
URL: https://github.com/apache/hbase/pull/8541#discussion_r3737586754
##
hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/GzipByteBuffDecompressor.java:
##
@@ -0,0 +1,220 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.io.compress;
+
+import edu.umd.cs.findbugs.annotations.Nullable;
+import java.io.IOException;
+import java.util.zip.CRC32;
+import java.nio.ByteBuffer;
+import java.util.zip.DataFormatException;
+import java.util.zip.Inflater;
+import org.apache.hadoop.hbase.nio.ByteBuff;
+import org.apache.hadoop.hbase.nio.SingleByteBuff;
+import org.apache.hadoop.io.compress.zlib.ZlibDecompressor;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Glue for ByteBuffDecompressor on top of Hadoop's native
+ * {@link ZlibDecompressor.ZlibDirectDecompressor}.
+ */
[email protected]
+public class GzipByteBuffDecompressor implements ByteBuffDecompressor {
+
+ private static final int GZIP_HEADER_LENGTH = 10;
+ private static final int GZIP_TRAILER_LENGTH = 8;
+
+ @Nullable
+ private final ZlibDecompressor.ZlibDirectDecompressor decompressor;
+
+ private final Inflater inflater = new Inflater(true);
+
+ private final CRC32 crc32 = new CRC32();
+
+ private boolean allowByteBuffDecompression;
+
+ GzipByteBuffDecompressor(boolean nativeZlibLoaded) {
+decompressor = nativeZlibLoaded
+ ? new
ZlibDecompressor.ZlibDirectDecompressor(ZlibDecompressor.CompressionHeader.GZIP_FORMAT,
+0)
+ : null;
+allowByteBuffDecompression = true;
+ }
+
+ @Override
Review Comment:
The flow for wether we can decompress is
1: verify config via context to ensure we havent disabled this feature
before we try to decompress via bytebuff
2. we only support singleByteBuff decompression for now
3. Since Zlib is a JNI we need to ensure that its properly instantiated if
and only if the buffers we are trying to decompress are direct, so if both are
direct we ensure the decompressor is loaded
4. then we return if both I/O are not direct if true it uses the inflater
pathway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Implement GzipByteBuffDecompressor with on-heap and off-heap decompression paths [hbase]
SaadASTheDev commented on code in PR #8541:
URL: https://github.com/apache/hbase/pull/8541#discussion_r3737544898
##
hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/GzipByteBuffDecompressor.java:
##
@@ -0,0 +1,220 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.io.compress;
+
+import edu.umd.cs.findbugs.annotations.Nullable;
+import java.io.IOException;
+import java.util.zip.CRC32;
+import java.nio.ByteBuffer;
+import java.util.zip.DataFormatException;
+import java.util.zip.Inflater;
+import org.apache.hadoop.hbase.nio.ByteBuff;
+import org.apache.hadoop.hbase.nio.SingleByteBuff;
+import org.apache.hadoop.io.compress.zlib.ZlibDecompressor;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Glue for ByteBuffDecompressor on top of Hadoop's native
+ * {@link ZlibDecompressor.ZlibDirectDecompressor}.
+ */
[email protected]
+public class GzipByteBuffDecompressor implements ByteBuffDecompressor {
+
+ private static final int GZIP_HEADER_LENGTH = 10;
+ private static final int GZIP_TRAILER_LENGTH = 8;
+
+ @Nullable
Review Comment:
These are the Singleton objects reused across decompress calls — one per
decompression path, Allocated once per buffer, to avoid GC overhead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
