Re: [PR] SOLR-18487: Fix NPE For specific Jersey endpoints [solr]
HoustonPutman merged PR #4973: URL: https://github.com/apache/solr/pull/4973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18487: Fix NPE For specific Jersey endpoints [solr]
HoustonPutman commented on PR #4973: URL: https://github.com/apache/solr/pull/4973#issuecomment-6001080273 @sigram I'm going to skip a changelog entry because the regression was not released. 10.0 was fine in this regard. But otherwise, I'll get tests added and this committed and back ported. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18487: Fix NPE For specific Jersey endpoints [solr]
sigram commented on PR #4973: URL: https://github.com/apache/solr/pull/4973#issuecomment-5998774407 This also needs a changelog entry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18487: Fix NPE For specific Jersey endpoints [solr]
CloudMarc commented on PR #4973: URL: https://github.com/apache/solr/pull/4973#issuecomment-5997294167 One thing for the 10.1 backport: on branch_10_1 this PR alone isn't enough. SOLR-18324 (c060bee) is on main and branch_10x but not branch_10_1, and without it the same requests still 500, now from PostRequestDecorationFilter and CatchAllExceptionMapper. With c060bee cherry-picked (applies cleanly) plus this PR, the regression test passes on branch_10_1. So RC2 needs both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18487: Fix NPE For specific Jersey endpoints [solr]
CloudMarc commented on PR #4973: URL: https://github.com/apache/solr/pull/4973#issuecomment-5997034573 Tested the new approach. It fixes it: V2 reload and add-replica sent to a node without a local replica now return 200, and fail with the original NPE with these changes reverted. Regression test for your branch: https://github.com/HoustonPutman/solr/pull/5 (replaces HoustonPutman/solr#4, which I've closed). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18487: Fix NPE For specific Jersey endpoints [solr]
CloudMarc commented on PR #4973: URL: https://github.com/apache/solr/pull/4973#issuecomment-5921091274 > Heads up, found an issue after more testing on this branch. Will open a PR with a test that passes on main but fails on this branch. https://github.com/HoustonPutman/solr/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18487: Fix NPE For specific Jersey endpoints [solr]
CloudMarc commented on PR #4973: URL: https://github.com/apache/solr/pull/4973#issuecomment-5921041596 Heads up, found an issue after more testing on this branch. Will open a PR with a test that passes on main but fails on this branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18487: Fix NPE For specific Jersey endpoints [solr]
HoustonPutman commented on PR #4973: URL: https://github.com/apache/solr/pull/4973#issuecomment-5920698293 So a null check is going to give us more silent failures that are very hard to debug vs a NPE. I'd much rather see the NPE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18487: Fix NPE For specific Jersey endpoints [solr]
CloudMarc commented on PR #4973: URL: https://github.com/apache/solr/pull/4973#issuecomment-5920598470 > > Still a potential NPE if not guarded: https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/cloud/api/collections/AdminCmdContext.java#L46 > > The idea is that this should never be null. Do you have a path where this can be null? No, it's more about defense in depth. The origin of this bug was an NPE cuz something "should never be null" but was. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18487: Fix NPE For specific Jersey endpoints [solr]
HoustonPutman commented on PR #4973: URL: https://github.com/apache/solr/pull/4973#issuecomment-5920479650 > Still a potential NPE if not guarded: https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/cloud/api/collections/AdminCmdContext.java#L46 The idea is that this should never be null. Do you have a path where this can be null? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18487: Fix NPE For specific Jersey endpoints [solr]
CloudMarc commented on PR #4973: URL: https://github.com/apache/solr/pull/4973#issuecomment-5920420134 Still a potential NPE if not guarded: https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/cloud/api/collections/AdminCmdContext.java#L46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18487: Fix NPE For specific Jersey endpoints [solr]
HoustonPutman commented on PR #4973: URL: https://github.com/apache/solr/pull/4973#issuecomment-5920138333 This doesn't need a changelog entry since the bug hasn't been released. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
