Dnia 2014-08-14, czw o godzinie 04:27 +, Shawn Debnath pisze:
- Build a hash table of relevant data and store it in the authreg_t
private data member.
Agreed, that needed internal bookkeeping makes it not feasible.
- Retrofit existing interfaces with the necessary data.
a. Introduce
Great! Yes I was a bit iffy on the ³custom² approach myself given it
really didn¹t align with any authentication method. But if API
breakage is okay, this is definitely the cleanest way.
- Retrofit existing interfaces with the necessary data.
a. Introduce void *sess_private in sess_t.
It's
Dnia 2014-08-14, czw o godzinie 16:20 +, Shawn Debnath pisze:
I would change all the APIs and to pass in a pointer to the sess_t as
I also need it in check_passsword.
I would advise to include sess_t* in authreg_private then.
It's OK for authreg to dig around session data, but the API
Dnia 2014-08-14, czw o godzinie 23:45 +, Shawn Debnath pisze:
I have modified the
APIs to pass sess_t and then the implementation can choose to pack it
in their private authreg_private data if they so choose.
WFM :-)
--
Tomasz Sterna :(){ :|:};:
Instant
I have modified the
APIs to pass sess_t and then the implementation can choose to pack it
in their private authreg_private data if they so choose.
WFM :-)
Changes almost ready to go, will submit a pull request within the hour.
Changes almost ready to go, will submit a pull request within the hour.
Pull request submitted: https://github.com/jabberd2/jabberd2/pull/72
Issue create to track (perhaps excessive):
https://github.com/jabberd2/jabberd2/issues/71
Looking forward to comments and feedback!
Thanks,
Shawn
