Re: [PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe()

2017-04-19 Thread Shannon Nelson
On 4/19/2017 2:11 AM, SF Markus Elfring wrote: From: Markus Elfring Date: Wed, 19 Apr 2017 10:50:04 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: quoted string split across lines Thus fix the affected source code places.

Re: [PATCH 1/2] n2rng: Use devm_kcalloc() in n2rng_probe()

2017-04-19 Thread Shannon Nelson
On 4/19/2017 2:10 AM, SF Markus Elfring wrote: From: Markus Elfring Date: Wed, 19 Apr 2017 10:30:47 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the

Re: [PATCH 0/4] staging: add ccree crypto driver

2017-04-19 Thread Gilad Ben-Yossef
On Tue, Apr 18, 2017 at 6:39 PM, Greg Kroah-Hartman wrote: > On Tue, Apr 18, 2017 at 05:07:50PM +0300, Gilad Ben-Yossef wrote: >> Arm TrustZone CryptoCell 700 is a family of cryptographic hardware >> accelerators. It is supported by a long lived series of out of tree

RE: [PATCH 4/8] crypto: KPP - add API crypto_kpp_set_params

2017-04-19 Thread Benedetto, Salvatore
Hi Stephan, > -Original Message- > From: keyrings-ow...@vger.kernel.org [mailto:keyrings- > ow...@vger.kernel.org] On Behalf Of Stephan Müller > Sent: Wednesday, April 19, 2017 12:06 AM > To: linux-crypto@vger.kernel.org > Cc: keyri...@vger.kernel.org > Subject: [PATCH 4/8] crypto: KPP -

Re: [PATCH 0/4] staging: add ccree crypto driver

2017-04-19 Thread Gilad Ben-Yossef
On Tue, Apr 18, 2017 at 6:43 PM, Mark Rutland wrote: ... >> >> >> >> The code still needs some cleanup before maturing to a proper >> >> upstream driver, which I am in the process of doing. However, >> >> as discussion of some of the capabilities of the hardware and >> >>

[PATCH 1/2] crypto: scomp - allow registration of multiple scomps

2017-04-19 Thread Giovanni Cabiddu
Add crypto_register_scomps and crypto_unregister_scomps to allow the registration of multiple implementations with one call. Signed-off-by: Giovanni Cabiddu --- crypto/scompress.c | 29 +

[PATCH 2/2] crypto: acomp - add support for deflate rfc1950 (zlib)

2017-04-19 Thread Giovanni Cabiddu
Add scomp backend for zlib-deflate compression algorithm. This backend outputs data using the format defined in rfc1950 (raw deflate surrounded by zlib header and footer). Signed-off-by: Giovanni Cabiddu --- crypto/deflate.c | 61

Re: export pcie_flr and remove copies of it in drivers V2

2017-04-19 Thread Leon Romanovsky
On Wed, Apr 19, 2017 at 08:37:37AM +0300, Leon Romanovsky wrote: > On Tue, Apr 18, 2017 at 01:36:12PM -0500, Bjorn Helgaas wrote: > > On Fri, Apr 14, 2017 at 09:11:24PM +0200, Christoph Hellwig wrote: > > > Hi all, > > > > > > this exports the PCI layer pcie_flr helper, and removes various

Re: [PATCH 1/2] dt-bindings: hwrng: Add Mediatek hardware random generator bindings

2017-04-19 Thread Rob Herring
On Thu, Apr 13, 2017 at 03:05:07PM +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > Document the devicetree bindings for Mediatek random number > generator which could be found on MT7623 SoC or other similar > Mediatek SoCs. > > Signed-off-by: Sean Wang

[PATCH] crypto: acomp - allow registration of multiple acomps

2017-04-19 Thread Giovanni Cabiddu
Add crypto_register_acomps and crypto_unregister_acomps to allow the registration of multiple implementations with one call. Signed-off-by: Giovanni Cabiddu --- crypto/acompress.c | 29 +

[PATCH] crypto: acomp - report scomp implementations

2017-04-19 Thread Giovanni Cabiddu
Fix crypto_has_acomp to report scomp implementations. Signed-off-by: Giovanni Cabiddu --- include/crypto/acompress.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/crypto/acompress.h b/include/crypto/acompress.h index e328b52..39871f9 100644 ---

[PATCH] crypto: acomp - replace compression known answer test

2017-04-19 Thread Giovanni Cabiddu
Compression implementations might return valid outputs that do not match what specified in the test vectors. For this reason, the testmgr might report that a compression implementation failed the test even if the data produced by the compressor is correct. This implements a decompress-and-verify

Re: [RFC PATCH 0/8] crypto: AF_ALG support for KPP

2017-04-19 Thread Tudor Ambarus
Hi, Stephan, Herbert, On 19.04.2017 02:03, Stephan Müller wrote: The patch 8 describes the different operations that are supported by AF_ALG KPP. This support includes generation and retaining of the private key inside the kernel. This private key would never be sent to user space. There are

Re: [RFC PATCH 0/8] crypto: AF_ALG support for KPP

2017-04-19 Thread Stephan Müller
Am Mittwoch, 19. April 2017, 14:03:35 CEST schrieb Tudor Ambarus: Hi Tudor, > Hi, Stephan, Herbert, > > On 19.04.2017 02:03, Stephan Müller wrote: > > The patch 8 describes the different operations that are supported by > > AF_ALG > > KPP. This support includes generation and retaining of the

[PATCH 1/5] KEYS: DH: forbid using digest_null as the KDF hash

2017-04-19 Thread Eric Biggers
From: Eric Biggers Requesting "digest_null" in the keyctl_kdf_params caused an infinite loop in kdf_ctr() because the "null" hash has a digest size of 0. Fix it by rejecting hash algorithms with a digest size of 0. Signed-off-by: Eric Biggers ---

[PATCH 2/5] KEYS: DH: don't feed uninitialized "otherinfo" into KDF

2017-04-19 Thread Eric Biggers
From: Eric Biggers If userspace called KEYCTL_DH_COMPUTE with kdf_params containing NULL otherinfo but nonzero otherinfolen, the kernel would allocate a buffer for the otherinfo, then feed it into the KDF without initializing it. Fix this by always doing the copy from

[PATCH 5/5] KEYS: DH: add __user annotations to keyctl_kdf_params

2017-04-19 Thread Eric Biggers
From: Eric Biggers Signed-off-by: Eric Biggers --- include/uapi/linux/keyctl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/uapi/linux/keyctl.h b/include/uapi/linux/keyctl.h index 201c6644b237..ef16df06642a 100644 ---

[PATCH 4/5] KEYS: DH: ensure the KDF counter is properly aligned

2017-04-19 Thread Eric Biggers
From: Eric Biggers Accessing a 'u8[4]' through a '__be32 *' violates alignment rules. Just make the counter a __be32 instead. Signed-off-by: Eric Biggers --- security/keys/dh.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-)

[PATCH 0/5] KEYS: fixes for new keyctl_dh_compute() KDF extension

2017-04-19 Thread Eric Biggers
This patch series fixes several bugs in the KDF extension to keyctl_dh_compute() currently sitting in keys-next: a way userspace could cause an infinite loop, two ways userspace could cause the use of uninitialized memory, a misalignment, and missing __user annotations. Eric Biggers (5): KEYS:

[PATCH 3/5] KEYS: DH: don't feed uninitialized result memory into KDF

2017-04-19 Thread Eric Biggers
From: Eric Biggers The result of the Diffie-Hellman computation may be shorter than the input prime number. Only calculate the KDF over the actual result; don't include additional uninitialized memory. Signed-off-by: Eric Biggers ---

[PATCH v2] powerpc/crypto/crct10dif-vpmsum: Fix missing preempt_disable()

2017-04-19 Thread Michael Ellerman
In crct10dif_vpmsum() we call enable_kernel_altivec() without first disabling preemption, which is not allowed. It used to be sufficient just to call pagefault_disable(), because that also disabled preemption. But the two were decoupled in commit 8222dbe21e79 ("sched/preempt, mm/fault: Decouple

Re: [PATCH 6/6] ima: Support appended signatures for appraisal

2017-04-19 Thread kbuild test robot
Hi Thiago, [auto build test ERROR on security/next] [also build test ERROR on v4.11-rc7 next-20170419] [cannot apply to integrity/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Thiago

[PATCH v2 3/3] MAINTAINERS: add a maintainer for the Inside Secure crypto driver

2017-04-19 Thread Antoine Tenart
A new cryptographic engine driver was added in drivers/crypto/inside-secure. Add myself as a maintainer for this driver. Signed-off-by: Antoine Tenart --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH v2 0/3] arm64: marvell: add cryptographic engine support for 7k/8k

2017-04-19 Thread Antoine Tenart
Hi all, This series adds support for the Inside Secure SafeXcel EIP197 cryptographic engine which can be found on Marvell Armada 7k and 8k boards. A new cryptographic engine driver is added, as well as the relevant device tree definition for the Armada 7040 DB and 8040 DB boards. This driver

[PATCH v2 1/3] Documentation/bindings: Document the SafeXel cryptographic engine driver

2017-04-19 Thread Antoine Tenart
The Inside Secure Safexcel cryptographic engine is found on some Marvell SoCs (7k/8k). Document the bindings used by its driver. Signed-off-by: Antoine Tenart --- .../bindings/crypto/inside-secure-safexcel.txt | 27 ++ 1 file changed,

[PATCH v2 2/3] crypto: inside-secure: add SafeXcel EIP197 crypto engine driver

2017-04-19 Thread Antoine Tenart
Add support for Inside Secure SafeXcel EIP197 cryptographic engine, which can be found on Marvell Armada 7k and 8k boards. This driver currently implements: ecb(aes), cbc(aes), sha1, sha224, sha256 and hmac(sah1) algorithms. Two firmwares are needed for this engine to work. Their are mostly used

[PATCH 1/2] n2rng: Use devm_kcalloc() in n2rng_probe()

2017-04-19 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 19 Apr 2017 10:30:47 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "devm_kcalloc". * Replace the

[PATCH 0/2] n2rng: Fine-tuning for n2rng_probe()

2017-04-19 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 19 Apr 2017 11:00:11 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Use devm_kcalloc() Combine substrings for two messages drivers/char/hw_random/n2-drv.c | 12

[PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe()

2017-04-19 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 19 Apr 2017 10:50:04 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: quoted string split across lines Thus fix the affected source code places. Signed-off-by: Markus Elfring