Re: [PATCH] crypto: cavium/nitrox - Remove default m setting from Kconfig

2017-07-10 Thread Linus Torvalds
Heh, I already did this in commit b4b8cbf679c4. I complained because I want maintainers to be aware of this issue - adding Kconfig options with defaults that don't make sense should be caught earlier than when I do a test built.. Linus On Mon, Jul 10, 2017 at 3:15 AM, Herbert

Re: [PATCH 3/3] crypto: hwrng add sysfs attribute to show user selected rng

2017-07-10 Thread PrasannaKumar Muralidharan
Hi Harald, > Hello PrasannaKumar > > here is now a version which combines patch 2 and patch 3 together > according to your suggestions: > > == cut == > > From: Harald Freudenberger > Date: Fri, 30 Jun 2017 17:06:40 +0200 > Subject: [PATCH 2/2] crypto:

Re: [PATCH] crypto: cavium/nitrox - Remove default m setting from Kconfig

2017-07-10 Thread Herbert Xu
On Mon, Jul 10, 2017 at 11:51:42AM -0700, Linus Torvalds wrote: > Heh, I already did this in commit b4b8cbf679c4. > > I complained because I want maintainers to be aware of this issue - > adding Kconfig options with defaults that don't make sense should be > caught earlier than when I do a test

[PATCH] crypto: cavium/nitrox - Remove default m setting from Kconfig

2017-07-10 Thread Herbert Xu
Drivers should not enable themselves by default, unless they're an integral part of the platform. Reported-by: Linus Torvalds Signed-off-by: Herbert Xu diff --git a/drivers/crypto/cavium/nitrox/Kconfig

[PATCH 0/2] crypto/algapi - refactor crypto_xor() to avoid memcpy()s

2017-07-10 Thread Ard Biesheuvel
>From 2/2: """ There are quite a number of occurrences in the kernel of the pattern if (dst != src) memcpy(dst, src, walk.total % AES_BLOCK_SIZE); crypto_xor(dst, final, walk.total % AES_BLOCK_SIZE); or crypto_xor(keystream, src, nbytes); memcpy(dst, keystream,

[PATCH 2/2] crypto/algapi - make crypto_xor() take separate dst and src arguments

2017-07-10 Thread Ard Biesheuvel
There are quite a number of occurrences in the kernel of the pattern if (dst != src) memcpy(dst, src, walk.total % AES_BLOCK_SIZE); crypto_xor(dst, final, walk.total % AES_BLOCK_SIZE); or crypto_xor(keystream, src, nbytes); memcpy(dst, keystream, nbytes); where

[PATCH 1/2] crypto/algapi - use separate dst and src operands for __crypto_xor()

2017-07-10 Thread Ard Biesheuvel
In preparation of updating crypto_xor() [which is what the crypto API exposes to other subsystems] to use separate operands for input and output, first modify the __crypto_xor() implementation that provides the actual functionality when not using the inline version. Signed-off-by: Ard Biesheuvel

Re: [GIT] Networking

2017-07-10 Thread Herbert Xu
On Mon, Jul 10, 2017 at 08:10:02AM -0400, Sowmini Varadhan wrote: > > The reason that the WARN_ON is triggered is that af_alg_accept() calls > sock_init_data() which does > >2636 if (sock) { > : >2639 sock->sk= sk; Oh yes. This started out with